Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652000 > unrolled thread
| Started by | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| First post | 2017-05-28 00:40 +0200 |
| Last post | 2017-05-28 00:40 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] i2c: pca954x: Add option to skip disabling PCA954x Mux device Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-28 00:40 +0200
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-28 00:40 +0200 |
| Subject | Re: [PATCH] i2c: pca954x: Add option to skip disabling PCA954x Mux device |
| Message-ID | <tLSxj-1HD-11@gated-at.bofh.it> |
On Tue, May 9, 2017 at 11:20 AM, <ying.zhang22455@nxp.com> wrote: > On some Layerscape boards like LS2085ARDB/LS2080ARDB, > input pull-up resistors on PCA954x Mux device are > missing on board. So, if mux are disabled after powered-on, > input lines will float leading to incorrect functionality. > > Hence, PCA954x Mux device should never be turned-off after > power-on. > > Add option to skip disabling PCA954x Mux device > if device tree contians "i2c-mux-never-disable" property > for pca954x device node. > +#ifdef CONFIG_ARCH_LAYERSCAPE This is 99.99% is no go. You need to spend more time to make the driver more generic (perhaps using device property instead) and not using ugly #ifdefery. -- With Best Regards, Andy Shevchenko
Back to top | Article view | linux.kernel
csiph-web