Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1651994 > unrolled thread
| Started by | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| First post | 2017-05-28 00:10 +0200 |
| Last post | 2017-05-30 09:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] mac80211: Invoke TX LED in more code paths Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-28 00:10 +0200
Re: [PATCH v2] mac80211: Invoke TX LED in more code paths Johannes Berg <johannes@sipsolutions.net> - 2017-05-30 09:20 +0200
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Date | 2017-05-28 00:10 +0200 |
| Subject | [PATCH v2] mac80211: Invoke TX LED in more code paths |
| Message-ID | <tLS4i-1vx-5@gated-at.bofh.it> |
ieee80211_tx_status() is only one of the possible ways a driver can report a handled packet, some drivers call this for every packet while others calls it rarely or never. In order to invoke the TX LED in the non-status reporting cases this patch pushes the call to ieee80211_led_tx() into ieee80211_report_used_skb(), which is shared between the various code paths. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- net/mac80211/status.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/mac80211/status.c b/net/mac80211/status.c index be47ac5cd8c8..a9fa6ee57e8f 100644 --- a/net/mac80211/status.c +++ b/net/mac80211/status.c @@ -546,6 +546,8 @@ static void ieee80211_report_used_skb(struct ieee80211_local *local, skb->wifi_acked_valid = 1; skb->wifi_acked = acked; } + + ieee80211_led_tx(local); } /* @@ -823,8 +825,6 @@ static void __ieee80211_tx_status(struct ieee80211_hw *hw, } } - ieee80211_led_tx(local); - /* SNMP counters * Fragments are passed to low-level drivers as separate skbs, so these * are actually fragments, not frames. Update frame counters only for -- 2.12.0
[toc] | [next] | [standalone]
| From | Johannes Berg <johannes@sipsolutions.net> |
|---|---|
| Date | 2017-05-30 09:20 +0200 |
| Message-ID | <tMJBE-49a-23@gated-at.bofh.it> |
| In reply to | #1651994 |
On Sat, 2017-05-27 at 14:59 -0700, Bjorn Andersson wrote: > ieee80211_tx_status() is only one of the possible ways a driver can > report a handled packet, some drivers call this for every packet > while > others calls it rarely or never. > > In order to invoke the TX LED in the non-status reporting cases this > patch pushes the call to ieee80211_led_tx() into > ieee80211_report_used_skb(), which is shared between the various code > paths. Applied. johannes
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web