Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650829 > unrolled thread
| Started by | Heiner Kallweit <hkallweit1@gmail.com> |
|---|---|
| First post | 2017-05-25 23:30 +0200 |
| Last post | 2017-05-26 09:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Why does callback irq_startup in struct irq_chip return _unsigned_ int ? Heiner Kallweit <hkallweit1@gmail.com> - 2017-05-25 23:30 +0200
Re: Why does callback irq_startup in struct irq_chip return _unsigned_ int ? Thomas Gleixner <tglx@linutronix.de> - 2017-05-26 09:20 +0200
| From | Heiner Kallweit <hkallweit1@gmail.com> |
|---|---|
| Date | 2017-05-25 23:30 +0200 |
| Subject | Why does callback irq_startup in struct irq_chip return _unsigned_ int ? |
| Message-ID | <tL8ut-55g-1@gated-at.bofh.it> |
Hi Thomas, just by chance I noticed that callback irq_startup in struct irq_chip returns an unsigned int. This doesn't seem to make sense as the result is a normal retval which is casted to a signed int in function irq_startup() anyway. Is there any specific reason for this or is it simply a bug? Rgds, Heiner
[toc] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2017-05-26 09:20 +0200 |
| Message-ID | <tLhHr-2RG-13@gated-at.bofh.it> |
| In reply to | #1650829 |
Heiner, On Thu, 25 May 2017, Heiner Kallweit wrote: > just by chance I noticed that callback irq_startup in struct irq_chip > returns an unsigned int. > This doesn't seem to make sense as the result is a normal retval which > is casted to a signed int in function irq_startup() anyway. > > Is there any specific reason for this or is it simply a bug? /me scratches head. IIRC then it was made unsigned int because that function cannot fail, but can return that an interrupt was pending. So if at all the thing should be 'bool'. Thanks, tglx
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web