Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1646666 > unrolled thread

[PATCH] drm/stm: ltdc: fix duplicated arguments

Started byPhilippe CORNU <philippe.cornu@st.com>
First post2017-05-22 11:40 +0200
Last post2017-05-23 15:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] drm/stm: ltdc: fix duplicated arguments Philippe CORNU <philippe.cornu@st.com> - 2017-05-22 11:40 +0200
    Re: [PATCH] drm/stm: ltdc: fix duplicated arguments Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-05-23 15:50 +0200

#1646666 — [PATCH] drm/stm: ltdc: fix duplicated arguments

FromPhilippe CORNU <philippe.cornu@st.com>
Date2017-05-22 11:40 +0200
Subject[PATCH] drm/stm: ltdc: fix duplicated arguments
Message-ID<tJRYJ-3Yq-3@gated-at.bofh.it>
Fix COMPILE_TEST build issue detected with the
rule: "duplicated argument to & or |"

Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
---
 drivers/gpu/drm/stm/ltdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index a40418c..700cc08 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -463,7 +463,7 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc)
 	clk_enable(ldev->pixel_clk);
 
 	/* Configures the HS, VS, DE and PC polarities. */
-	val = HSPOL_AL | HSPOL_AL | DEPOL_AL | PCPOL_IPC;
+	val = HSPOL_AL | VSPOL_AL | DEPOL_AL | PCPOL_IPC;
 
 	if (vm.flags & DISPLAY_FLAGS_HSYNC_HIGH)
 		val |= HSPOL_AH;
-- 
1.9.1

[toc] | [next] | [standalone]


#1648076

FromBenjamin Gaignard <benjamin.gaignard@linaro.org>
Date2017-05-23 15:50 +0200
Message-ID<tKime-3Tp-37@gated-at.bofh.it>
In reply to#1646666
2017-05-22 11:30 GMT+02:00 Philippe CORNU <philippe.cornu@st.com>:
> Fix COMPILE_TEST build issue detected with the
> rule: "duplicated argument to & or |"
>

I have merged it in drm-misc-next

Thanks,
Benjamin

> Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
> ---
>  drivers/gpu/drm/stm/ltdc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index a40418c..700cc08 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -463,7 +463,7 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc)
>         clk_enable(ldev->pixel_clk);
>
>         /* Configures the HS, VS, DE and PC polarities. */
> -       val = HSPOL_AL | HSPOL_AL | DEPOL_AL | PCPOL_IPC;
> +       val = HSPOL_AL | VSPOL_AL | DEPOL_AL | PCPOL_IPC;
>
>         if (vm.flags & DISPLAY_FLAGS_HSYNC_HIGH)
>                 val |= HSPOL_AH;
> --
> 1.9.1
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web