Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1643119 > unrolled thread
| Started by | Guodong Xu <guodong.xu@linaro.org> |
|---|---|
| First post | 2017-05-17 10:40 +0200 |
| Last post | 2017-05-23 14:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 12/12] arm64: dts: hikey960: add LED nodes Guodong Xu <guodong.xu@linaro.org> - 2017-05-17 10:40 +0200
Re: [PATCH 12/12] arm64: dts: hikey960: add LED nodes Rob Herring <robh@kernel.org> - 2017-05-23 02:50 +0200
Re: [PATCH 12/12] arm64: dts: hikey960: add LED nodes Guodong Xu <guodong.xu@linaro.org> - 2017-05-23 14:10 +0200
| From | Guodong Xu <guodong.xu@linaro.org> |
|---|---|
| Date | 2017-05-17 10:40 +0200 |
| Subject | [PATCH 12/12] arm64: dts: hikey960: add LED nodes |
| Message-ID | <tI2EV-J3-3@gated-at.bofh.it> |
HiKey960 has four user LEDs, and two special purpose LEDs: WiFi and BT
respectively.
All of them are implemented as GPIO.
Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 48 +++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index 6de86c0..4839885 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -48,6 +48,54 @@
linux,code = <KEY_POWER>;
};
};
+
+ leds {
+ compatible = "gpio-leds";
+ status = "disabled";
+ user_led1 {
+ label = "user_led1";
+ /* gpio_150_user_led1 */
+ gpios = <&gpio18 6 0>;
+ linux,default-trigger = "heartbeat";
+ };
+
+ user_led2 {
+ label = "user_led2";
+ /* gpio_151_user_led2 */
+ gpios = <&gpio18 7 0>;
+ linux,default-trigger = "mmc0";
+ };
+
+ user_led3 {
+ label = "user_led3";
+ /* gpio_189_user_led3 */
+ gpios = <&gpio23 5 0>;
+ default-state = "off";
+ };
+
+ user_led4 {
+ label = "user_led4";
+ /* gpio_190_user_led4 */
+ gpios = <&gpio23 6 0>;
+ linux,default-trigger = "cpu0";
+ };
+
+ wlan_active_led {
+ label = "wifi_active";
+ /* gpio_205_wifi_active */
+ gpios = <&gpio25 5 0>;
+ linux,default-trigger = "phy0tx";
+ default-state = "off";
+ };
+
+ bt_active_led {
+ label = "bt_active";
+ gpios = <&gpio25 7 0>;
+ /* gpio_207_user_led1 */
+ linux,default-trigger = "hci0rx";
+ default-state = "off";
+ };
+ };
};
};
--
2.10.2
[toc] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-05-23 02:50 +0200 |
| Message-ID | <tK6bo-4ju-41@gated-at.bofh.it> |
| In reply to | #1643119 |
On Wed, May 17, 2017 at 04:37:45PM +0800, Guodong Xu wrote:
> HiKey960 has four user LEDs, and two special purpose LEDs: WiFi and BT
> respectively.
>
> All of them are implemented as GPIO.
>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 48 +++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> index 6de86c0..4839885 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -48,6 +48,54 @@
> linux,code = <KEY_POWER>;
> };
> };
> +
> + leds {
This too should move out of the soc node.
> + compatible = "gpio-leds";
> + status = "disabled";
> + user_led1 {
> + label = "user_led1";
> + /* gpio_150_user_led1 */
> + gpios = <&gpio18 6 0>;
> + linux,default-trigger = "heartbeat";
> + };
> +
> + user_led2 {
> + label = "user_led2";
> + /* gpio_151_user_led2 */
> + gpios = <&gpio18 7 0>;
> + linux,default-trigger = "mmc0";
> + };
> +
> + user_led3 {
> + label = "user_led3";
> + /* gpio_189_user_led3 */
> + gpios = <&gpio23 5 0>;
> + default-state = "off";
> + };
> +
> + user_led4 {
> + label = "user_led4";
> + /* gpio_190_user_led4 */
> + gpios = <&gpio23 6 0>;
> + linux,default-trigger = "cpu0";
> + };
> +
> + wlan_active_led {
> + label = "wifi_active";
> + /* gpio_205_wifi_active */
> + gpios = <&gpio25 5 0>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> +
> + bt_active_led {
> + label = "bt_active";
> + gpios = <&gpio25 7 0>;
> + /* gpio_207_user_led1 */
> + linux,default-trigger = "hci0rx";
> + default-state = "off";
> + };
> + };
> };
> };
>
> --
> 2.10.2
>
[toc] | [prev] | [next] | [standalone]
| From | Guodong Xu <guodong.xu@linaro.org> |
|---|---|
| Date | 2017-05-23 14:10 +0200 |
| Message-ID | <tKgNs-30T-3@gated-at.bofh.it> |
| In reply to | #1647534 |
On Tue, May 23, 2017 at 8:48 AM, Rob Herring <robh@kernel.org> wrote:
> On Wed, May 17, 2017 at 04:37:45PM +0800, Guodong Xu wrote:
>> HiKey960 has four user LEDs, and two special purpose LEDs: WiFi and BT
>> respectively.
>>
>> All of them are implemented as GPIO.
>>
>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>> ---
>> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 48 +++++++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> index 6de86c0..4839885 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> @@ -48,6 +48,54 @@
>> linux,code = <KEY_POWER>;
>> };
>> };
>> +
>> + leds {
>
> This too should move out of the soc node.
Thanks, Rob. I will fix these.
-Guodong
>
>> + compatible = "gpio-leds";
>> + status = "disabled";
>> + user_led1 {
>> + label = "user_led1";
>> + /* gpio_150_user_led1 */
>> + gpios = <&gpio18 6 0>;
>> + linux,default-trigger = "heartbeat";
>> + };
>> +
>> + user_led2 {
>> + label = "user_led2";
>> + /* gpio_151_user_led2 */
>> + gpios = <&gpio18 7 0>;
>> + linux,default-trigger = "mmc0";
>> + };
>> +
>> + user_led3 {
>> + label = "user_led3";
>> + /* gpio_189_user_led3 */
>> + gpios = <&gpio23 5 0>;
>> + default-state = "off";
>> + };
>> +
>> + user_led4 {
>> + label = "user_led4";
>> + /* gpio_190_user_led4 */
>> + gpios = <&gpio23 6 0>;
>> + linux,default-trigger = "cpu0";
>> + };
>> +
>> + wlan_active_led {
>> + label = "wifi_active";
>> + /* gpio_205_wifi_active */
>> + gpios = <&gpio25 5 0>;
>> + linux,default-trigger = "phy0tx";
>> + default-state = "off";
>> + };
>> +
>> + bt_active_led {
>> + label = "bt_active";
>> + gpios = <&gpio25 7 0>;
>> + /* gpio_207_user_led1 */
>> + linux,default-trigger = "hci0rx";
>> + default-state = "off";
>> + };
>> + };
>> };
>> };
>>
>> --
>> 2.10.2
>>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web