Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1647896 > unrolled thread
| Started by | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| First post | 2017-05-23 11:50 +0200 |
| Last post | 2017-05-23 12:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. Chanwoo Choi <cw00.choi@samsung.com> - 2017-05-23 11:50 +0200
Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. Chanwoo Choi <cw00.choi@samsung.com> - 2017-05-23 12:00 +0200
Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. Benson Leung <bleung@chromium.org> - 2017-05-24 00:30 +0200
Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-05-23 12:00 +0200
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2017-05-23 11:50 +0200 |
| Subject | Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. |
| Message-ID | <tKeBX-1li-5@gated-at.bofh.it> |
Hi Enric, On 2017년 04월 20일 19:16, Enric Balletbo i Serra wrote: > On 05/04/17 03:21, Chanwoo Choi wrote: >> Hi Enric, >> >> On 2017년 03월 02일 16:29, Chanwoo Choi wrote: >>> Hi, >>> >>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: >>>> From: Benson Leung <bleung@chromium.org> >>>> >>>> This is the driver for the USB Type C cable detection mechanism >>>> built into the ChromeOS Embedded Controller on systems that >>>> have USB Type-C ports. >>>> >>>> At present, this allows for the presence of display out, but in >>>> future, it may also be used to notify host and device type cables >>>> and the presence of power. >>>> >>>> Signed-off-by: Benson Leung <bleung@chromium.org> >>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >>>> --- >>>> Changes since v1: >>>> Requested by Chanwoo Choi >>>> - Rename files changing _ for - >>>> - Remove the unneeded blank line on bottom of header. >>>> - Remove kobject.h and cros_ec_commands.h includes. >>>> - Remove the debug message as is not necessary. >>>> - Use the tab for indentation instead of space for if sentence. >>>> - Define each variable on different lines when the variables should be >>>> initialized. >>>> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. >>>> - Add one blank line to split out between state and property setting. >>>> - Add the author information (header and module) >>>> >>>> Enric Balletbo >>>> - As Rob suggested to rename the compatible name to something indicating that >>>> is USB Type C related I also renamed the file names, extcon-cros-ec -> >>>> extcon-usbc-cros-ec, I think it's more clear. >>>> >>>> drivers/extcon/Kconfig | 7 + >>>> drivers/extcon/Makefile | 1 + >>>> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ >>>> include/linux/mfd/cros_ec_commands.h | 75 +++++++ >>>> 4 files changed, 498 insertions(+) >>>> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c >>>> >>> >>> Looks good to me. >>> Acked-by: Chanwoo Choi <cw00.chio@samsung.com> >>> >>> I think this patch should be handled with patches[1]. >>> [1] https://lkml.org/lkml/2017/2/14/655 >>> >>> I think that one maintainer among following subsystems >>> (mfd, chrome h/w platform, rtc and extcon) >>> will apply their git repository, and then one maintainer >>> will send the pull request of immutable branch for these patches. >>> >> >> As I mentioned, these patch should be handled with related patches[1]. >> [1] https://lkml.org/lkml/2017/2/14/655 >> >> So, I can't apply these patch on extcon git because there is a merge conflict >> and we should handle these patches with immutable branch between subsystem maintainer. >> >> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1, >> please take care of these patches. >> > > CC'ied : Olof Johansson > > Olof, Benson, > > Could at least the following patch in this series [1] picked as soon as possible > if it's ok. > > 9630769 New [01/13] mfd: cros_ec: Add helper for event notifier > > This specific patch is blocking this and others like the rtc-cros-ec to land and > the series were send some time ago without received bad feedback. > > [1] https://lkml.org/lkml/2017/3/17/321 > > Many thanks, > Enric Maybe, you better to resend these patches based on v4.12-rcX. -- Best Regards, Chanwoo Choi Samsung Electronics
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2017-05-23 12:00 +0200 |
| Message-ID | <tKeLD-1oL-3@gated-at.bofh.it> |
| In reply to | #1647896 |
Hi, On 2017년 05월 23일 18:52, Enric Balletbo i Serra wrote: > > > On 23/05/17 11:46, Chanwoo Choi wrote: >> Hi Enric, >> >> On 2017년 04월 20일 19:16, Enric Balletbo i Serra wrote: >>> On 05/04/17 03:21, Chanwoo Choi wrote: >>>> Hi Enric, >>>> >>>> On 2017년 03월 02일 16:29, Chanwoo Choi wrote: >>>>> Hi, >>>>> >>>>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: >>>>>> From: Benson Leung <bleung@chromium.org> >>>>>> >>>>>> This is the driver for the USB Type C cable detection mechanism >>>>>> built into the ChromeOS Embedded Controller on systems that >>>>>> have USB Type-C ports. >>>>>> >>>>>> At present, this allows for the presence of display out, but in >>>>>> future, it may also be used to notify host and device type cables >>>>>> and the presence of power. >>>>>> >>>>>> Signed-off-by: Benson Leung <bleung@chromium.org> >>>>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >>>>>> --- >>>>>> Changes since v1: >>>>>> Requested by Chanwoo Choi >>>>>> - Rename files changing _ for - >>>>>> - Remove the unneeded blank line on bottom of header. >>>>>> - Remove kobject.h and cros_ec_commands.h includes. >>>>>> - Remove the debug message as is not necessary. >>>>>> - Use the tab for indentation instead of space for if sentence. >>>>>> - Define each variable on different lines when the variables should be >>>>>> initialized. >>>>>> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. >>>>>> - Add one blank line to split out between state and property setting. >>>>>> - Add the author information (header and module) >>>>>> >>>>>> Enric Balletbo >>>>>> - As Rob suggested to rename the compatible name to something indicating that >>>>>> is USB Type C related I also renamed the file names, extcon-cros-ec -> >>>>>> extcon-usbc-cros-ec, I think it's more clear. >>>>>> >>>>>> drivers/extcon/Kconfig | 7 + >>>>>> drivers/extcon/Makefile | 1 + >>>>>> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ >>>>>> include/linux/mfd/cros_ec_commands.h | 75 +++++++ >>>>>> 4 files changed, 498 insertions(+) >>>>>> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c >>>>>> >>>>> >>>>> Looks good to me. >>>>> Acked-by: Chanwoo Choi <cw00.chio@samsung.com> >>>>> >>>>> I think this patch should be handled with patches[1]. >>>>> [1] https://lkml.org/lkml/2017/2/14/655 >>>>> >>>>> I think that one maintainer among following subsystems >>>>> (mfd, chrome h/w platform, rtc and extcon) >>>>> will apply their git repository, and then one maintainer >>>>> will send the pull request of immutable branch for these patches. >>>>> >>>> >>>> As I mentioned, these patch should be handled with related patches[1]. >>>> [1] https://lkml.org/lkml/2017/2/14/655 >>>> >>>> So, I can't apply these patch on extcon git because there is a merge conflict >>>> and we should handle these patches with immutable branch between subsystem maintainer. >>>> >>>> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1, >>>> please take care of these patches. >>>> >>> >>> CC'ied : Olof Johansson >>> >>> Olof, Benson, >>> >>> Could at least the following patch in this series [1] picked as soon as possible >>> if it's ok. >>> >>> 9630769 New [01/13] mfd: cros_ec: Add helper for event notifier >>> >>> This specific patch is blocking this and others like the rtc-cros-ec to land and >>> the series were send some time ago without received bad feedback. >>> >>> [1] https://lkml.org/lkml/2017/3/17/321 >>> >>> Many thanks, >>> Enric >> >> Maybe, you better to resend these patches based on v4.12-rcX. >> > > I did a week ago :) The patches were rebased on top of current linux-next, > waiting for the maintainers, hope will be accepted soon so we can unblock this > patch and the rtc patches. > > https://lkml.org/lkml/2017/5/16/478 > OK. This patch must need the immutable branch. I expect that some maintainer will make the immutable branch and then send pull request to other maintainer related to them. -- Best Regards, Chanwoo Choi Samsung Electronics
[toc] | [prev] | [next] | [standalone]
| From | Benson Leung <bleung@chromium.org> |
|---|---|
| Date | 2017-05-24 00:30 +0200 |
| Message-ID | <tKqts-1iq-15@gated-at.bofh.it> |
| In reply to | #1647904 |
Hi Chanwoo, On Tue, May 23, 2017 at 2:58 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > OK. This patch must need the immutable branch. > > I expect that some maintainer will make the immutable branch > and then send pull request to other maintainer related to them. > I'll create an immutable branch with this this week. Thank you! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org
[toc] | [prev] | [next] | [standalone]
| From | Enric Balletbo i Serra <enric.balletbo@collabora.com> |
|---|---|
| Date | 2017-05-23 12:00 +0200 |
| Message-ID | <tKeLD-1oL-5@gated-at.bofh.it> |
| In reply to | #1647896 |
On 23/05/17 11:46, Chanwoo Choi wrote: > Hi Enric, > > On 2017년 04월 20일 19:16, Enric Balletbo i Serra wrote: >> On 05/04/17 03:21, Chanwoo Choi wrote: >>> Hi Enric, >>> >>> On 2017년 03월 02일 16:29, Chanwoo Choi wrote: >>>> Hi, >>>> >>>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: >>>>> From: Benson Leung <bleung@chromium.org> >>>>> >>>>> This is the driver for the USB Type C cable detection mechanism >>>>> built into the ChromeOS Embedded Controller on systems that >>>>> have USB Type-C ports. >>>>> >>>>> At present, this allows for the presence of display out, but in >>>>> future, it may also be used to notify host and device type cables >>>>> and the presence of power. >>>>> >>>>> Signed-off-by: Benson Leung <bleung@chromium.org> >>>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >>>>> --- >>>>> Changes since v1: >>>>> Requested by Chanwoo Choi >>>>> - Rename files changing _ for - >>>>> - Remove the unneeded blank line on bottom of header. >>>>> - Remove kobject.h and cros_ec_commands.h includes. >>>>> - Remove the debug message as is not necessary. >>>>> - Use the tab for indentation instead of space for if sentence. >>>>> - Define each variable on different lines when the variables should be >>>>> initialized. >>>>> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. >>>>> - Add one blank line to split out between state and property setting. >>>>> - Add the author information (header and module) >>>>> >>>>> Enric Balletbo >>>>> - As Rob suggested to rename the compatible name to something indicating that >>>>> is USB Type C related I also renamed the file names, extcon-cros-ec -> >>>>> extcon-usbc-cros-ec, I think it's more clear. >>>>> >>>>> drivers/extcon/Kconfig | 7 + >>>>> drivers/extcon/Makefile | 1 + >>>>> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ >>>>> include/linux/mfd/cros_ec_commands.h | 75 +++++++ >>>>> 4 files changed, 498 insertions(+) >>>>> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c >>>>> >>>> >>>> Looks good to me. >>>> Acked-by: Chanwoo Choi <cw00.chio@samsung.com> >>>> >>>> I think this patch should be handled with patches[1]. >>>> [1] https://lkml.org/lkml/2017/2/14/655 >>>> >>>> I think that one maintainer among following subsystems >>>> (mfd, chrome h/w platform, rtc and extcon) >>>> will apply their git repository, and then one maintainer >>>> will send the pull request of immutable branch for these patches. >>>> >>> >>> As I mentioned, these patch should be handled with related patches[1]. >>> [1] https://lkml.org/lkml/2017/2/14/655 >>> >>> So, I can't apply these patch on extcon git because there is a merge conflict >>> and we should handle these patches with immutable branch between subsystem maintainer. >>> >>> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1, >>> please take care of these patches. >>> >> >> CC'ied : Olof Johansson >> >> Olof, Benson, >> >> Could at least the following patch in this series [1] picked as soon as possible >> if it's ok. >> >> 9630769 New [01/13] mfd: cros_ec: Add helper for event notifier >> >> This specific patch is blocking this and others like the rtc-cros-ec to land and >> the series were send some time ago without received bad feedback. >> >> [1] https://lkml.org/lkml/2017/3/17/321 >> >> Many thanks, >> Enric > > Maybe, you better to resend these patches based on v4.12-rcX. > I did a week ago :) The patches were rebased on top of current linux-next, waiting for the maintainers, hope will be accepted soon so we can unblock this patch and the rtc patches. https://lkml.org/lkml/2017/5/16/478 Thanks, Enric
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web