Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1643244 > unrolled thread
| Started by | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| First post | 2017-05-17 12:30 +0200 |
| Last post | 2017-05-23 10:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 0/3] pinctrl: cherryview: Extend the DMI quirk to Intel_Strago systems Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-17 12:30 +0200
[PATCH v2 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-17 12:30 +0200
Re: [PATCH v2 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems Linus Walleij <linus.walleij@linaro.org> - 2017-05-23 10:20 +0200
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Date | 2017-05-17 12:30 +0200 |
| Subject | [PATCH v2 0/3] pinctrl: cherryview: Extend the DMI quirk to Intel_Strago systems |
| Message-ID | <tI4nn-1Pa-9@gated-at.bofh.it> |
Hi,
It turned out that there are bunch of other Chromebooks that need the DMI
quirk as well. Most of these are based on Intel_Strago reference design so
we can identify them by using DMI_PRODUCT_FAMILY introduced in this series.
The systems without the family string we add them separately.
Related bugzilla entry:
https://bugzilla.kernel.org/show_bug.cgi?id=194945
I'm including fix from Yongjun as well because I did not find it in
v4.12-rc1 possibly because it just was forgotten.
Changes from v1:
* Drop BIOS date, we can't use it because there are many different
Celes Chromebooks out there but their BIOS release date varies (and
they miss the prodyct family information as well).
* Name the machines consistently.
Mika Westerberg (2):
firmware: dmi: Add DMI_PRODUCT_FAMILY identification string
pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems
Wei Yongjun (1):
pinctrl: cherryview: Add terminate entry for dmi_system_id tables
drivers/firmware/dmi-id.c | 2 ++
drivers/firmware/dmi_scan.c | 1 +
drivers/pinctrl/intel/pinctrl-cherryview.c | 24 +++++++++++++++++++-----
include/linux/mod_devicetable.h | 1 +
4 files changed, 23 insertions(+), 5 deletions(-)
--
2.11.0
[toc] | [next] | [standalone]
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Date | 2017-05-17 12:30 +0200 |
| Subject | [PATCH v2 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems |
| Message-ID | <tI4no-1Pa-31@gated-at.bofh.it> |
| In reply to | #1643244 |
It turns out there are quite many Chromebooks out there that have the
same keyboard issue than Acer Chromebook. All of them are based on
Intel_Strago reference and report their DMI_PRODUCT_FAMILY as
"Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are exceptions
for which we add separate entries).
Instead of adding each machine to the quirk table, we use
DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the
machines out there currently.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=194945
Suggested: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index e35d0fe4c737..20f1b4493994 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1539,13 +1539,26 @@ static void chv_gpio_irq_handler(struct irq_desc *desc)
* is not listed below.
*/
static const struct dmi_system_id chv_no_valid_mask[] = {
+ /* See https://bugzilla.kernel.org/show_bug.cgi?id=194945 */
{
- /* See https://bugzilla.kernel.org/show_bug.cgi?id=194945 */
- .ident = "Acer Chromebook (CYAN)",
+ .ident = "Intel_Strago based Chromebooks (All models)",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
- DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"),
- DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"),
+ DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
+ },
+ },
+ {
+ .ident = "Acer Chromebook R11 (Cyan)",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
+ },
+ },
+ {
+ .ident = "Samsung Chromebook 3 (Celes)",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
},
},
{}
--
2.11.0
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-05-23 10:20 +0200 |
| Subject | Re: [PATCH v2 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems |
| Message-ID | <tKdcS-x7-25@gated-at.bofh.it> |
| In reply to | #1643248 |
On Wed, May 17, 2017 at 12:25 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > It turns out there are quite many Chromebooks out there that have the > same keyboard issue than Acer Chromebook. All of them are based on > Intel_Strago reference and report their DMI_PRODUCT_FAMILY as > "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are exceptions > for which we add separate entries). > > Instead of adding each machine to the quirk table, we use > DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the > machines out there currently. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=194945 > Suggested: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Patch applied with Andy's review tag. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web