Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647482 > unrolled thread

[PATCH] x86/ioapic: Remove unused function IO_APIC_irq_trigger()

Back to article view | Back to linux.kernel

Contents

  [PATCH] x86/ioapic: Remove unused function IO_APIC_irq_trigger() Matthias Kaehlcke <mka@chromium.org> - 2017-05-23 01:30 +0200
    [tip:irq/core] x86/ioapic: Remove unused IO_APIC_irq_trigger()  function tip-bot for Matthias Kaehlcke <tipbot@zytor.com> - 2017-05-23 10:50 +0200

#1647482 — [PATCH] x86/ioapic: Remove unused function IO_APIC_irq_trigger()

The function isn't used since commit 5ad274d41c1b ("x86/irq: Remove
unused old IOAPIC irqdomain interfaces"). Removing it fixes the
following warning when building with clang:

arch/x86/kernel/apic/io_apic.c:1219:19: error: unused function
    'IO_APIC_irq_trigger' [-Werror,-Wunused-function]

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Andrew, this is a practical example of clangs 'unused-function' warning
on static inline functions being useful.

 arch/x86/kernel/apic/io_apic.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 347bb9f65737..247880fc29f9 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1200,28 +1200,6 @@ EXPORT_SYMBOL(IO_APIC_get_PCI_irq_vector);
 
 static struct irq_chip ioapic_chip, ioapic_ir_chip;
 
-#ifdef CONFIG_X86_32
-static inline int IO_APIC_irq_trigger(int irq)
-{
-	int apic, idx, pin;
-
-	for_each_ioapic_pin(apic, pin) {
-		idx = find_irq_entry(apic, pin, mp_INT);
-		if ((idx != -1) && (irq == pin_2_irq(idx, apic, pin, 0)))
-			return irq_trigger(idx);
-	}
-	/*
-         * nonexistent IRQs are edge default
-         */
-	return 0;
-}
-#else
-static inline int IO_APIC_irq_trigger(int irq)
-{
-	return 1;
-}
-#endif
-
 static void __init setup_IO_APIC_irqs(void)
 {
 	unsigned int ioapic, pin;
-- 
2.13.0.303.g4ebf302169-goog

[toc] | [next] | [standalone]

#1647818 — [tip:irq/core] x86/ioapic: Remove unused IO_APIC_irq_trigger() function

Commit-ID:  b9de5068b2d7c22de1bb89d62a7119a6b8dff88f
Gitweb:     http://git.kernel.org/tip/b9de5068b2d7c22de1bb89d62a7119a6b8dff88f
Author:     Matthias Kaehlcke <mka@chromium.org>
AuthorDate: Mon, 22 May 2017 16:20:35 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 23 May 2017 09:06:32 +0200

x86/ioapic: Remove unused IO_APIC_irq_trigger() function

The function isn't used since commit:

  5ad274d41c1b ("x86/irq: Remove unused old IOAPIC irqdomain interfaces")

Removing it fixes the following warning when building with clang:

  arch/x86/kernel/apic/io_apic.c:1219:19: error: unused function
      'IO_APIC_irq_trigger' [-Werror,-Wunused-function]

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170522232035.187985-1-mka@chromium.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/apic/io_apic.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 347bb9f..247880f 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1200,28 +1200,6 @@ EXPORT_SYMBOL(IO_APIC_get_PCI_irq_vector);
 
 static struct irq_chip ioapic_chip, ioapic_ir_chip;
 
-#ifdef CONFIG_X86_32
-static inline int IO_APIC_irq_trigger(int irq)
-{
-	int apic, idx, pin;
-
-	for_each_ioapic_pin(apic, pin) {
-		idx = find_irq_entry(apic, pin, mp_INT);
-		if ((idx != -1) && (irq == pin_2_irq(idx, apic, pin, 0)))
-			return irq_trigger(idx);
-	}
-	/*
-         * nonexistent IRQs are edge default
-         */
-	return 0;
-}
-#else
-static inline int IO_APIC_irq_trigger(int irq)
-{
-	return 1;
-}
-#endif
-
 static void __init setup_IO_APIC_irqs(void)
 {
 	unsigned int ioapic, pin;

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web