Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1646906 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-05-22 15:40 +0200 |
| Last post | 2017-05-23 07:40 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe Arnd Bergmann <arnd@arndb.de> - 2017-05-22 15:40 +0200
Re: [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe Ulf Hansson <ulf.hansson@linaro.org> - 2017-05-22 18:10 +0200
Re: [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe Wolfram Sang <wsa@the-dreams.de> - 2017-05-23 10:10 +0200
Re: [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe Simon Horman <horms@verge.net.au> - 2017-05-23 07:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-05-22 15:40 +0200 |
| Subject | [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe |
| Message-ID | <tJVJ0-6iD-25@gated-at.bofh.it> |
We now build the sdhi driver in separate modules, which means we
have to export the symbols that are called from another module:
ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mmc/host/renesas_sdhi_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index 846ee1a8e5a6..fa6c188e0327 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -638,6 +638,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
eprobe:
return ret;
}
+EXPORT_SYMBOL_GPL(renesas_sdhi_probe);
int renesas_sdhi_remove(struct platform_device *pdev)
{
@@ -648,3 +649,4 @@ int renesas_sdhi_remove(struct platform_device *pdev)
return 0;
}
+EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
--
2.9.0
[toc] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2017-05-22 18:10 +0200 |
| Message-ID | <tJY49-7To-1@gated-at.bofh.it> |
| In reply to | #1646906 |
On 22 May 2017 at 15:33, Arnd Bergmann <arnd@arndb.de> wrote:
> We now build the sdhi driver in separate modules, which means we
> have to export the symbols that are called from another module:
>
> ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
>
> Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 846ee1a8e5a6..fa6c188e0327 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -638,6 +638,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> eprobe:
> return ret;
> }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_probe);
>
> int renesas_sdhi_remove(struct platform_device *pdev)
> {
> @@ -648,3 +649,4 @@ int renesas_sdhi_remove(struct platform_device *pdev)
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
> --
> 2.9.0
>
[toc] | [prev] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-05-23 10:10 +0200 |
| Message-ID | <tKd3c-sK-19@gated-at.bofh.it> |
| In reply to | #1647087 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, May 22, 2017 at 05:51:57PM +0200, Ulf Hansson wrote:
> On 22 May 2017 at 15:33, Arnd Bergmann <arnd@arndb.de> wrote:
> > We now build the sdhi driver in separate modules, which means we
> > have to export the symbols that are called from another module:
> >
> > ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> > ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> >
> > Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks, applied for next!
Wow, that was fast :) FWIW:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks, Arnd!
[toc] | [prev] | [next] | [standalone]
| From | Simon Horman <horms@verge.net.au> |
|---|---|
| Date | 2017-05-23 07:40 +0200 |
| Message-ID | <tKaI1-7h9-7@gated-at.bofh.it> |
| In reply to | #1646906 |
On Mon, May 22, 2017 at 03:33:08PM +0200, Arnd Bergmann wrote:
> We now build the sdhi driver in separate modules, which means we
> have to export the symbols that are called from another module:
>
> ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
>
> Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")
Sorry for messing this up and thanks for the fix.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 846ee1a8e5a6..fa6c188e0327 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -638,6 +638,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> eprobe:
> return ret;
> }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_probe);
>
> int renesas_sdhi_remove(struct platform_device *pdev)
> {
> @@ -648,3 +649,4 @@ int renesas_sdhi_remove(struct platform_device *pdev)
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
> --
> 2.9.0
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web