Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647770 > unrolled thread

[PATCH] iio: hi8435: remote ampersands from hi8435_info definition

Back to article view | Back to linux.kernel

Contents

  [PATCH] iio: hi8435: remote ampersands from hi8435_info definition Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-23 10:10 +0200
    Re: [PATCH] iio: hi8435: remote ampersands from hi8435_info  definition Jonathan Cameron <jic23@kernel.org> - 2017-05-24 21:30 +0200

#1647770 — [PATCH] iio: hi8435: remote ampersands from hi8435_info definition

C syntax allows apersands when initializing structures fields with
function pointers, but in Linux sources ampersands are normally not used
in thix context.

Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
---
 drivers/iio/adc/hi8435.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
index 28fc699f00f6..ef5c286c8e67 100644
--- a/drivers/iio/adc/hi8435.c
+++ b/drivers/iio/adc/hi8435.c
@@ -414,11 +414,11 @@ static const struct iio_chan_spec hi8435_channels[] = {
 static const struct iio_info hi8435_info = {
 	.driver_module = THIS_MODULE,
 	.read_raw = hi8435_read_raw,
-	.read_event_config = &hi8435_read_event_config,
+	.read_event_config = hi8435_read_event_config,
 	.write_event_config = hi8435_write_event_config,
-	.read_event_value = &hi8435_read_event_value,
-	.write_event_value = &hi8435_write_event_value,
-	.debugfs_reg_access = &hi8435_debugfs_reg_access,
+	.read_event_value = hi8435_read_event_value,
+	.write_event_value = hi8435_write_event_value,
+	.debugfs_reg_access = hi8435_debugfs_reg_access,
 };
 
 static void hi8435_iio_push_event(struct iio_dev *idev, unsigned int val)
-- 
2.11.0

[toc] | [next] | [standalone]

#1649881 — Re: [PATCH] iio: hi8435: remote ampersands from hi8435_info definition

On Tue, 23 May 2017 11:07:46 +0300
Nikita Yushchenko <nikita.yoush@cogentembedded.com> wrote:

> C syntax allows apersands when initializing structures fields with
> function pointers, but in Linux sources ampersands are normally not used
> in thix context.
> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,
Jonathan
> ---
>  drivers/iio/adc/hi8435.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
> index 28fc699f00f6..ef5c286c8e67 100644
> --- a/drivers/iio/adc/hi8435.c
> +++ b/drivers/iio/adc/hi8435.c
> @@ -414,11 +414,11 @@ static const struct iio_chan_spec hi8435_channels[] = {
>  static const struct iio_info hi8435_info = {
>  	.driver_module = THIS_MODULE,
>  	.read_raw = hi8435_read_raw,
> -	.read_event_config = &hi8435_read_event_config,
> +	.read_event_config = hi8435_read_event_config,
>  	.write_event_config = hi8435_write_event_config,
> -	.read_event_value = &hi8435_read_event_value,
> -	.write_event_value = &hi8435_write_event_value,
> -	.debugfs_reg_access = &hi8435_debugfs_reg_access,
> +	.read_event_value = hi8435_read_event_value,
> +	.write_event_value = hi8435_write_event_value,
> +	.debugfs_reg_access = hi8435_debugfs_reg_access,
>  };
>  
>  static void hi8435_iio_push_event(struct iio_dev *idev, unsigned int val)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web