Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647646 > unrolled thread

[PATCH net v2 1/2] net: ieee802154: remove explicit set skb->sk

Back to article view | Back to linux.kernel

Contents

  [PATCH net v2 1/2] net: ieee802154: remove explicit set skb->sk Lin Zhang <xiaolou4617@gmail.com> - 2017-05-23 07:30 +0200
    Re: [PATCH net v2 1/2] net: ieee802154: remove explicit set skb->sk Marcel Holtmann <marcel@holtmann.org> - 2017-05-23 20:10 +0200

#1647646 — [PATCH net v2 1/2] net: ieee802154: remove explicit set skb->sk

Explicit set skb->sk is needless, sock_alloc_send_skb is already set it.

Signed-off-by: Lin Zhang <xiaolou4617@gmail.com>
Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
---
changelog:

v1 -> v2:
        * split v1 into two patches, per Stefan Schmidt.

Thanks to Stefan Schmidt for reviewing !
---
 net/ieee802154/socket.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
index eedba76..b01a1f0 100644
--- a/net/ieee802154/socket.c
+++ b/net/ieee802154/socket.c
@@ -301,7 +301,6 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
 		goto out_skb;
 
 	skb->dev = dev;
-	skb->sk  = sk;
 	skb->protocol = htons(ETH_P_IEEE802154);
 
 	dev_put(dev);
@@ -690,7 +689,6 @@ static int dgram_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
 		goto out_skb;
 
 	skb->dev = dev;
-	skb->sk  = sk;
 	skb->protocol = htons(ETH_P_IEEE802154);
 
 	dev_put(dev);
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1648313

Hi Lin,

> Explicit set skb->sk is needless, sock_alloc_send_skb is already set it.
> 
> Signed-off-by: Lin Zhang <xiaolou4617@gmail.com>
> Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
> ---
> changelog:
> 
> v1 -> v2:
>        * split v1 into two patches, per Stefan Schmidt.
> 
> Thanks to Stefan Schmidt for reviewing !
> ---
> net/ieee802154/socket.c | 2 --
> 1 file changed, 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web