Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1649543 > unrolled thread
| Started by | "Andrey Jr. Melnikov" <temnota.am@gmail.com> |
|---|---|
| First post | 2017-05-24 14:10 +0200 |
| Last post | 2017-05-29 17:30 +0200 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch "Andrey Jr. Melnikov" <temnota.am@gmail.com> - 2017-05-24 14:10 +0200
Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch Andrew Lunn <andrew@lunn.ch> - 2017-05-24 15:30 +0200
Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch Andrey Melnikov <temnota.am@gmail.com> - 2017-05-24 16:50 +0200
Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch Florian Fainelli <f.fainelli@gmail.com> - 2017-05-26 08:00 +0200
Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch Andrey Melnikov <temnota.am@gmail.com> - 2017-05-29 12:50 +0200
Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch Andrew Lunn <andrew@lunn.ch> - 2017-05-29 17:30 +0200
| From | "Andrey Jr. Melnikov" <temnota.am@gmail.com> |
|---|---|
| Date | 2017-05-24 14:10 +0200 |
| Subject | Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch |
| Message-ID | <tKDh0-2cD-3@gated-at.bofh.it> |
In gmane.linux.kernel sean.wang@mediatek.com wrote: > From: Sean Wang <sean.wang@mediatek.com> > MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on > Mediatek router platforms such as MT7623A or MT7623N platform which > includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. > Among these ports, The port from 0 to 4 are the user ports connecting > with the remote devices while the port 5 and 6 are the CPU ports > connecting into Mediatek Ethernet GMAC. > For port 6, it can communicate with the CPU via Mediatek Ethernet GMAC > through either the TRGMII or RGMII which could be controlled by phy-mode > in the dt-bindings to specify which mode is preferred to use. And for > port 5, only RGMII can be specified. However, currently, only port 6 is > being supported in this DSA driver. > The driver is made with the reference to qca8k and other existing DSA > driver. The most of the essential callbacks of the DSA are already > support in the driver, including tag insert for user port distinguishing, > port control, bridge offloading, STP setup and ethtool operation to allow > DSA to model each user port into a standalone netdevice as the other DSA > driver had done. What about JUMBO frames and large MTU support? devlink support?
[toc] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-05-24 15:30 +0200 |
| Subject | Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch |
| Message-ID | <tKEwp-2RX-5@gated-at.bofh.it> |
| In reply to | #1649543 |
> What about JUMBO frames and large MTU support? devlink support? To get the driver merged, it is better to start small, a minimal set of features. Other features can be added later. If these features are important to you, please feel free to submit patches. Andrew
[toc] | [prev] | [next] | [standalone]
| From | Andrey Melnikov <temnota.am@gmail.com> |
|---|---|
| Date | 2017-05-24 16:50 +0200 |
| Subject | Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch |
| Message-ID | <tKFLQ-3z2-9@gated-at.bofh.it> |
| In reply to | #1649613 |
2017-05-24 16:20 GMT+03:00 Andrew Lunn <andrew@lunn.ch>: >> What about JUMBO frames and large MTU support? devlink support? > > To get the driver merged, it is better to start small, a minimal set > of features. Other features can be added later. If these features are > important to you, please feel free to submit patches. There is no documentation from mediatek about this feature. Driver from SDK v4.x contains only switching 19'th bit in GDMA1_FWD_CFG and nothing more. So, how to write patches? Peeking random bits in random SOC config registers?
[toc] | [prev] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-05-26 08:00 +0200 |
| Message-ID | <tLgs2-1UV-9@gated-at.bofh.it> |
| In reply to | #1649543 |
On May 24, 2017 4:17:39 AM PDT, "Andrey Jr. Melnikov" <temnota.am@gmail.com> wrote: >In gmane.linux.kernel sean.wang@mediatek.com wrote: >> From: Sean Wang <sean.wang@mediatek.com> > >> MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on >> Mediatek router platforms such as MT7623A or MT7623N platform which >> includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. >> Among these ports, The port from 0 to 4 are the user ports connecting >> with the remote devices while the port 5 and 6 are the CPU ports >> connecting into Mediatek Ethernet GMAC. > >> For port 6, it can communicate with the CPU via Mediatek Ethernet >GMAC >> through either the TRGMII or RGMII which could be controlled by >phy-mode >> in the dt-bindings to specify which mode is preferred to use. And for >> port 5, only RGMII can be specified. However, currently, only port 6 >is >> being supported in this DSA driver. > >> The driver is made with the reference to qca8k and other existing DSA >> driver. The most of the essential callbacks of the DSA are already >> support in the driver, including tag insert for user port >distinguishing, >> port control, bridge offloading, STP setup and ethtool operation to >allow >> DSA to model each user port into a standalone netdevice as the other >DSA >> driver had done. > >What about JUMBO frames and large MTU support? devlink support? We don't have a ndo_change_mtu callback implemented for DSA network devices but that is probably how we should do it. Regarding devlink, Andrew added basic support for it but unlike mlxsw it is currently of mild interest. Do you have something specific in mind with devlink? -- Florian
[toc] | [prev] | [next] | [standalone]
| From | Andrey Melnikov <temnota.am@gmail.com> |
|---|---|
| Date | 2017-05-29 12:50 +0200 |
| Subject | Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch |
| Message-ID | <tMqpj-72M-5@gated-at.bofh.it> |
| In reply to | #1651092 |
2017-05-26 8:54 GMT+03:00 Florian Fainelli <f.fainelli@gmail.com>: > On May 24, 2017 4:17:39 AM PDT, "Andrey Jr. Melnikov" <temnota.am@gmail.com> wrote: >>In gmane.linux.kernel sean.wang@mediatek.com wrote: >>> From: Sean Wang <sean.wang@mediatek.com> >> >>> MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on >>> Mediatek router platforms such as MT7623A or MT7623N platform which >>> includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. >>> Among these ports, The port from 0 to 4 are the user ports connecting >>> with the remote devices while the port 5 and 6 are the CPU ports >>> connecting into Mediatek Ethernet GMAC. >> >>> For port 6, it can communicate with the CPU via Mediatek Ethernet >>GMAC >>> through either the TRGMII or RGMII which could be controlled by >>phy-mode >>> in the dt-bindings to specify which mode is preferred to use. And for >>> port 5, only RGMII can be specified. However, currently, only port 6 >>is >>> being supported in this DSA driver. >> >>> The driver is made with the reference to qca8k and other existing DSA >>> driver. The most of the essential callbacks of the DSA are already >>> support in the driver, including tag insert for user port >>distinguishing, >>> port control, bridge offloading, STP setup and ethtool operation to >>allow >>> DSA to model each user port into a standalone netdevice as the other >>DSA >>> driver had done. >> >>What about JUMBO frames and large MTU support? devlink support? > > We don't have a ndo_change_mtu callback implemented for DSA network devices but that is probably how we should do it. > Regarding devlink, Andrew added basic support for it but unlike mlxsw it is currently of mild interest. Do you have something specific in mind with devlink? I want to see each ports behind the bridge as independent ethernet devices. If I understand RTFM only devlink may expose this configuration.
[toc] | [prev] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-05-29 17:30 +0200 |
| Subject | Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch |
| Message-ID | <tMuMi-1KX-33@gated-at.bofh.it> |
| In reply to | #1652405 |
> I want to see each ports behind the bridge as independent ethernet > devices. If I understand RTFM only devlink may expose this > configuration. DSA and switchdev in general gives you a linux interface per user switch port. So you can see each interface, get stats, ethtools, mii-tool, etc per interface. devlink is not needed for this. Andrew
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web