Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1643497 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-05-17 18:30 +0200 |
| Last post | 2017-05-24 15:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-17 18:30 +0200
Re: [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register() Michael Büsch <m@bues.ch> - 2017-05-17 23:10 +0200
Re: ssb: Delete an error message for a failed memory allocation in ssb_devices_register() Kalle Valo <kvalo@codeaurora.org> - 2017-05-24 15:50 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-17 18:30 +0200 |
| Subject | [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register() |
| Message-ID | <tI9ZL-5oT-3@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 17 May 2017 18:12:16 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/ssb/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index d1a750760cf3..65420a9f0e82 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -480,7 +480,6 @@ static int ssb_devices_register(struct ssb_bus *bus)
devwrap = kzalloc(sizeof(*devwrap), GFP_KERNEL);
if (!devwrap) {
- ssb_err("Could not allocate device\n");
err = -ENOMEM;
goto error;
}
--
2.13.0
[toc] | [next] | [standalone]
| From | Michael Büsch <m@bues.ch> |
|---|---|
| Date | 2017-05-17 23:10 +0200 |
| Subject | Re: [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register() |
| Message-ID | <tIemJ-8jO-1@gated-at.bofh.it> |
| In reply to | #1643497 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, 17 May 2017 18:22:49 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 17 May 2017 18:12:16 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/ssb/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index d1a750760cf3..65420a9f0e82 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -480,7 +480,6 @@ static int ssb_devices_register(struct ssb_bus *bus)
>
> devwrap = kzalloc(sizeof(*devwrap), GFP_KERNEL);
> if (!devwrap) {
> - ssb_err("Could not allocate device\n");
> err = -ENOMEM;
> goto error;
> }
This looks good.
Acked-by: Michael Büsch <m@bues.ch>
--
Michael
[toc] | [prev] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2017-05-24 15:50 +0200 |
| Subject | Re: ssb: Delete an error message for a failed memory allocation in ssb_devices_register() |
| Message-ID | <tKEPN-2YG-35@gated-at.bofh.it> |
| In reply to | #1643497 |
SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 17 May 2017 18:12:16 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > Acked-by: Michael Büsch <m@bues.ch> Patch applied to wireless-drivers-next.git, thanks. c6c092dcb21e ssb: Delete an error message for a failed memory allocation in ssb_devices_register() -- https://patchwork.kernel.org/patch/9731583/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web