Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1649192 > unrolled thread

[PATCH] ARM: dts: rockchip: correct regular setting for act8846

Started byEddie Cai <eddie.cai.linux@gmail.com>
First post2017-05-24 09:40 +0200
Last post2017-05-24 14:30 +0200
Articles 9 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: dts: rockchip: correct regular setting for act8846 Eddie Cai <eddie.cai.linux@gmail.com> - 2017-05-24 09:40 +0200
    Re: [PATCH] ARM: dts: rockchip: correct regular setting for act8846 Heiko Stuebner <heiko@sntech.de> - 2017-05-24 10:20 +0200
      Re: [PATCH] ARM: dts: rockchip: correct regular setting for act8846 Heiko Stuebner <heiko@sntech.de> - 2017-05-24 10:50 +0200
        Re: [PATCH] ARM: dts: rockchip: correct regular setting for act8846 Eddie Cai <eddie.cai.linux@gmail.com> - 2017-05-24 11:00 +0200
          Re: [PATCH] ARM: dts: rockchip: correct regular setting for act8846 Heiko Stuebner <heiko@sntech.de> - 2017-05-24 11:00 +0200
      Re: [PATCH] ARM: dts: rockchip: correct regular setting for act8846 Eddie Cai <eddie.cai.linux@gmail.com> - 2017-05-24 10:50 +0200
      Re: [PATCH] ARM: dts: rockchip: correct regular setting for act8846 Robin Murphy <robin.murphy@arm.com> - 2017-05-24 12:30 +0200
        Re: [PATCH] ARM: dts: rockchip: correct regular setting for act8846 Heiko Stuebner <heiko@sntech.de> - 2017-05-24 13:40 +0200
          Re: [PATCH] ARM: dts: rockchip: correct regular setting for act8846 Robin Murphy <robin.murphy@arm.com> - 2017-05-24 14:30 +0200

#1649192 — [PATCH] ARM: dts: rockchip: correct regular setting for act8846

FromEddie Cai <eddie.cai.linux@gmail.com>
Date2017-05-24 09:40 +0200
Subject[PATCH] ARM: dts: rockchip: correct regular setting for act8846
Message-ID<tKz3H-7GI-1@gated-at.bofh.it>
the previous setting of act8846 is just copy from firefly board. but
the reload board is a little different from firefly board. let's correct
it.

Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
---
 arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
index 8134966..4cfa109 100644
--- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
+++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
@@ -179,6 +179,7 @@
 				regulator-name = "vccio_sd";
 				regulator-min-microvolt = <3300000>;
 				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
 			};
 
 			vdd10_lcd: REG6 {
@@ -187,24 +188,23 @@
 				regulator-max-microvolt = <1000000>;
 			};
 
-			vcca_18: REG7  {
-				regulator-name = "vcca_18";
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <1800000>;
-				regulator-always-on;
+			vcca_33: REG7  {
+				regulator-name = "vcca_33";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
 			};
 
-			vcca_33: REG8 {
-				regulator-name = "vcca_33";
+			vcc_lan: REG8 {
+				regulator-name = "vcc_lan";
 				regulator-min-microvolt = <3300000>;
 				regulator-max-microvolt = <3300000>;
-				regulator-always-on;
 			};
 
-			vcc_lan: REG9 {
-				regulator-name = "vcca_lan";
+			vccio_pmu: REG9 {
+				regulator-name = "vccio_pmu";
 				regulator-min-microvolt = <3300000>;
 				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
 			};
 
 			vdd_10: REG10 {
@@ -218,6 +218,7 @@
 				regulator-name = "vcc_18";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
 			};
 
 			vcc18_lcd: REG12 {
-- 
1.9.1

[toc] | [next] | [standalone]

#1649226

FromHeiko Stuebner <heiko@sntech.de>
Date2017-05-24 10:20 +0200
Message-ID<tKzGq-8dC-25@gated-at.bofh.it>
In reply to#1649192
Hi Eddie,

Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai:
> the previous setting of act8846 is just copy from firefly board. but
> the reload board is a little different from firefly board. let's correct
> it.
> 
> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> ---
>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> index 8134966..4cfa109 100644
> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> @@ -179,6 +179,7 @@
>  				regulator-name = "vccio_sd";
>  				regulator-min-microvolt = <3300000>;
>  				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;

the rest below looks pretty straight forward, but why does vccio_sd
need to be always on?

I've checked the reload's schematics but did not find any further users
of vccio_sd that may warant this attribute.


Heiko


>  			};
>  
>  			vdd10_lcd: REG6 {
> @@ -187,24 +188,23 @@
>  				regulator-max-microvolt = <1000000>;
>  			};
>  
> -			vcca_18: REG7  {
> -				regulator-name = "vcca_18";
> -				regulator-min-microvolt = <1800000>;
> -				regulator-max-microvolt = <1800000>;
> -				regulator-always-on;
> +			vcca_33: REG7  {
> +				regulator-name = "vcca_33";
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
>  			};
>  
> -			vcca_33: REG8 {
> -				regulator-name = "vcca_33";
> +			vcc_lan: REG8 {
> +				regulator-name = "vcc_lan";
>  				regulator-min-microvolt = <3300000>;
>  				regulator-max-microvolt = <3300000>;
> -				regulator-always-on;
>  			};
>  
> -			vcc_lan: REG9 {
> -				regulator-name = "vcca_lan";
> +			vccio_pmu: REG9 {
> +				regulator-name = "vccio_pmu";
>  				regulator-min-microvolt = <3300000>;
>  				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
>  			};
>  
>  			vdd_10: REG10 {
> @@ -218,6 +218,7 @@
>  				regulator-name = "vcc_18";
>  				regulator-min-microvolt = <1800000>;
>  				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
>  			};
>  
>  			vcc18_lcd: REG12 {
>

[toc] | [prev] | [next] | [standalone]

#1649296

FromHeiko Stuebner <heiko@sntech.de>
Date2017-05-24 10:50 +0200
Message-ID<tKA9r-8rl-5@gated-at.bofh.it>
In reply to#1649226
Am Mittwoch, 24. Mai 2017, 16:44:05 CEST schrieb Eddie Cai:
> 2017-05-24 16:17 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:
> > Hi Eddie,
> >
> > Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai:
> >> the previous setting of act8846 is just copy from firefly board. but
> >> the reload board is a little different from firefly board. let's correct
> >> it.
> >>
> >> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> >> ---
> >>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++----------
> >>  1 file changed, 11 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> >> index 8134966..4cfa109 100644
> >> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> >> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> >> @@ -179,6 +179,7 @@
> >>                               regulator-name = "vccio_sd";
> >>                               regulator-min-microvolt = <3300000>;
> >>                               regulator-max-microvolt = <3300000>;
> >> +                             regulator-always-on;
> >
> > the rest below looks pretty straight forward, but why does vccio_sd
> > need to be always on?
> >
> > I've checked the reload's schematics but did not find any further users
> > of vccio_sd that may warant this attribute.
> Oh, It's default on. thank you for point out my mistake. I will modify
> it in next version.

not default-on, but the mmc-core will turn on the vccio regulator on its
own during probe. So yes, please fix :-) .


Thanks
Heiko

[toc] | [prev] | [next] | [standalone]

#1649317

FromEddie Cai <eddie.cai.linux@gmail.com>
Date2017-05-24 11:00 +0200
Message-ID<tKAj8-8uU-1@gated-at.bofh.it>
In reply to#1649296
2017-05-24 16:47 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:
> Am Mittwoch, 24. Mai 2017, 16:44:05 CEST schrieb Eddie Cai:
>> 2017-05-24 16:17 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:
>> > Hi Eddie,
>> >
>> > Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai:
>> >> the previous setting of act8846 is just copy from firefly board. but
>> >> the reload board is a little different from firefly board. let's correct
>> >> it.
>> >>
>> >> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>> >> ---
>> >>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++----------
>> >>  1 file changed, 11 insertions(+), 10 deletions(-)
>> >>
>> >> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> >> index 8134966..4cfa109 100644
>> >> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> >> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> >> @@ -179,6 +179,7 @@
>> >>                               regulator-name = "vccio_sd";
>> >>                               regulator-min-microvolt = <3300000>;
>> >>                               regulator-max-microvolt = <3300000>;
>> >> +                             regulator-always-on;
>> >
>> > the rest below looks pretty straight forward, but why does vccio_sd
>> > need to be always on?
>> >
>> > I've checked the reload's schematics but did not find any further users
>> > of vccio_sd that may warant this attribute.
>> Oh, It's default on. thank you for point out my mistake. I will modify
>> it in next version.
>
> not default-on, but the mmc-core will turn on the vccio regulator on its
> own during probe. So yes, please fix :-) .
I mean it will be default on by hardware from schematics. I just modify it to
regulator-boot-on and send v1 patch
>
>
> Thanks
> Heiko
>

[toc] | [prev] | [next] | [standalone]

#1649318

FromHeiko Stuebner <heiko@sntech.de>
Date2017-05-24 11:00 +0200
Message-ID<tKAj8-8uU-5@gated-at.bofh.it>
In reply to#1649317
Am Mittwoch, 24. Mai 2017, 16:50:51 CEST schrieb Eddie Cai:
> 2017-05-24 16:47 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:
> > Am Mittwoch, 24. Mai 2017, 16:44:05 CEST schrieb Eddie Cai:
> >> 2017-05-24 16:17 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:
> >> > Hi Eddie,
> >> >
> >> > Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai:
> >> >> the previous setting of act8846 is just copy from firefly board. but
> >> >> the reload board is a little different from firefly board. let's correct
> >> >> it.
> >> >>
> >> >> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> >> >> ---
> >> >>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++----------
> >> >>  1 file changed, 11 insertions(+), 10 deletions(-)
> >> >>
> >> >> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> >> >> index 8134966..4cfa109 100644
> >> >> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> >> >> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> >> >> @@ -179,6 +179,7 @@
> >> >>                               regulator-name = "vccio_sd";
> >> >>                               regulator-min-microvolt = <3300000>;
> >> >>                               regulator-max-microvolt = <3300000>;
> >> >> +                             regulator-always-on;
> >> >
> >> > the rest below looks pretty straight forward, but why does vccio_sd
> >> > need to be always on?
> >> >
> >> > I've checked the reload's schematics but did not find any further users
> >> > of vccio_sd that may warant this attribute.
> >> Oh, It's default on. thank you for point out my mistake. I will modify
> >> it in next version.
> >
> > not default-on, but the mmc-core will turn on the vccio regulator on its
> > own during probe. So yes, please fix :-) .
> I mean it will be default on by hardware from schematics. I just modify it to
> regulator-boot-on and send v1 patch

nice, that is even better to make that explicit.

No need to resent for that, but your new patch should actually be v2.
The patch without version number always counts as v1, we just normally
don't write that down :-)


Heiko

[toc] | [prev] | [next] | [standalone]

#1649304

FromEddie Cai <eddie.cai.linux@gmail.com>
Date2017-05-24 10:50 +0200
Message-ID<tKA9r-8rl-7@gated-at.bofh.it>
In reply to#1649226
2017-05-24 16:17 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:
> Hi Eddie,
>
> Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai:
>> the previous setting of act8846 is just copy from firefly board. but
>> the reload board is a little different from firefly board. let's correct
>> it.
>>
>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>> ---
>>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++----------
>>  1 file changed, 11 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> index 8134966..4cfa109 100644
>> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> @@ -179,6 +179,7 @@
>>                               regulator-name = "vccio_sd";
>>                               regulator-min-microvolt = <3300000>;
>>                               regulator-max-microvolt = <3300000>;
>> +                             regulator-always-on;
>
> the rest below looks pretty straight forward, but why does vccio_sd
> need to be always on?
>
> I've checked the reload's schematics but did not find any further users
> of vccio_sd that may warant this attribute.
Oh, It's default on. thank you for point out my mistake. I will modify
it in next version.
>
>
> Heiko
>
>
>>                       };
>>
>>                       vdd10_lcd: REG6 {
>> @@ -187,24 +188,23 @@
>>                               regulator-max-microvolt = <1000000>;
>>                       };
>>
>> -                     vcca_18: REG7  {
>> -                             regulator-name = "vcca_18";
>> -                             regulator-min-microvolt = <1800000>;
>> -                             regulator-max-microvolt = <1800000>;
>> -                             regulator-always-on;
>> +                     vcca_33: REG7  {
>> +                             regulator-name = "vcca_33";
>> +                             regulator-min-microvolt = <3300000>;
>> +                             regulator-max-microvolt = <3300000>;
>>                       };
>>
>> -                     vcca_33: REG8 {
>> -                             regulator-name = "vcca_33";
>> +                     vcc_lan: REG8 {
>> +                             regulator-name = "vcc_lan";
>>                               regulator-min-microvolt = <3300000>;
>>                               regulator-max-microvolt = <3300000>;
>> -                             regulator-always-on;
>>                       };
>>
>> -                     vcc_lan: REG9 {
>> -                             regulator-name = "vcca_lan";
>> +                     vccio_pmu: REG9 {
>> +                             regulator-name = "vccio_pmu";
>>                               regulator-min-microvolt = <3300000>;
>>                               regulator-max-microvolt = <3300000>;
>> +                             regulator-always-on;
>>                       };
>>
>>                       vdd_10: REG10 {
>> @@ -218,6 +218,7 @@
>>                               regulator-name = "vcc_18";
>>                               regulator-min-microvolt = <1800000>;
>>                               regulator-max-microvolt = <1800000>;
>> +                             regulator-always-on;
>>                       };
>>
>>                       vcc18_lcd: REG12 {
>>
>
>

[toc] | [prev] | [next] | [standalone]

#1649429

FromRobin Murphy <robin.murphy@arm.com>
Date2017-05-24 12:30 +0200
Message-ID<tKBIe-15d-9@gated-at.bofh.it>
In reply to#1649226
On 24/05/17 09:17, Heiko Stuebner wrote:
> Hi Eddie,
> 
> Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai:
>> the previous setting of act8846 is just copy from firefly board. but
>> the reload board is a little different from firefly board. let's correct
>> it.
>>
>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>> ---
>>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++----------
>>  1 file changed, 11 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> index 8134966..4cfa109 100644
>> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> @@ -179,6 +179,7 @@
>>  				regulator-name = "vccio_sd";
>>  				regulator-min-microvolt = <3300000>;
>>  				regulator-max-microvolt = <3300000>;
>> +				regulator-always-on;
> 
> the rest below looks pretty straight forward, but why does vccio_sd
> need to be always on?
> 
> I've checked the reload's schematics but did not find any further users
> of vccio_sd that may warant this attribute.

It looks like the card detect line is pulled up externally to vcc_sd,
which isn't always-on either, so you probably do want this - on the
(unrelated) rk3288 TV box I've been hacking on, I discovered that
powering off the sdmmc-supply domain also kills the internal pull-up and
leaves sdmmc_cd floating. The resulting stochastic card polling
mechanism is amusing, but probably undesirable ;)

Robin.

> 
> 
> Heiko
> 
> 
>>  			};
>>  
>>  			vdd10_lcd: REG6 {
>> @@ -187,24 +188,23 @@
>>  				regulator-max-microvolt = <1000000>;
>>  			};
>>  
>> -			vcca_18: REG7  {
>> -				regulator-name = "vcca_18";
>> -				regulator-min-microvolt = <1800000>;
>> -				regulator-max-microvolt = <1800000>;
>> -				regulator-always-on;
>> +			vcca_33: REG7  {
>> +				regulator-name = "vcca_33";
>> +				regulator-min-microvolt = <3300000>;
>> +				regulator-max-microvolt = <3300000>;
>>  			};
>>  
>> -			vcca_33: REG8 {
>> -				regulator-name = "vcca_33";
>> +			vcc_lan: REG8 {
>> +				regulator-name = "vcc_lan";
>>  				regulator-min-microvolt = <3300000>;
>>  				regulator-max-microvolt = <3300000>;
>> -				regulator-always-on;
>>  			};
>>  
>> -			vcc_lan: REG9 {
>> -				regulator-name = "vcca_lan";
>> +			vccio_pmu: REG9 {
>> +				regulator-name = "vccio_pmu";
>>  				regulator-min-microvolt = <3300000>;
>>  				regulator-max-microvolt = <3300000>;
>> +				regulator-always-on;
>>  			};
>>  
>>  			vdd_10: REG10 {
>> @@ -218,6 +218,7 @@
>>  				regulator-name = "vcc_18";
>>  				regulator-min-microvolt = <1800000>;
>>  				regulator-max-microvolt = <1800000>;
>> +				regulator-always-on;
>>  			};
>>  
>>  			vcc18_lcd: REG12 {
>>
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

[toc] | [prev] | [next] | [standalone]

#1649512

FromHeiko Stuebner <heiko@sntech.de>
Date2017-05-24 13:40 +0200
Message-ID<tKCNY-1KT-25@gated-at.bofh.it>
In reply to#1649429
Am Mittwoch, 24. Mai 2017, 11:26:10 CEST schrieb Robin Murphy:
> On 24/05/17 09:17, Heiko Stuebner wrote:
> > Hi Eddie,
> > 
> > Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai:
> >> the previous setting of act8846 is just copy from firefly board. but
> >> the reload board is a little different from firefly board. let's correct
> >> it.
> >>
> >> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> >> ---
> >>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++----------
> >>  1 file changed, 11 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> >> index 8134966..4cfa109 100644
> >> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> >> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> >> @@ -179,6 +179,7 @@
> >>  				regulator-name = "vccio_sd";
> >>  				regulator-min-microvolt = <3300000>;
> >>  				regulator-max-microvolt = <3300000>;
> >> +				regulator-always-on;
> > 
> > the rest below looks pretty straight forward, but why does vccio_sd
> > need to be always on?
> > 
> > I've checked the reload's schematics but did not find any further users
> > of vccio_sd that may warant this attribute.
> 
> It looks like the card detect line is pulled up externally to vcc_sd,
> which isn't always-on either, so you probably do want this - on the
> (unrelated) rk3288 TV box I've been hacking on, I discovered that
> powering off the sdmmc-supply domain also kills the internal pull-up and
> leaves sdmmc_cd floating. The resulting stochastic card polling
> mechanism is amusing, but probably undesirable ;)

Hmm, are you mixing up vcc_sd and vccio_sd?

vccio_sd is the io supply (vqmmc in mmc-terms) to the mmc-host itself
while vcc_sd is the actual card supply (vmmc in mmc-terms).


After looking through some schematics, the pull-up to vcc_sd seems to be
the common pattern for rk3288 devices. So I guess this means the fixed
regulator vcc_sd should get an regulator-always-on instead to stabilize
the card-detect?


Heiko

> > 
> > 
> > Heiko
> > 
> > 
> >>  			};
> >>  
> >>  			vdd10_lcd: REG6 {
> >> @@ -187,24 +188,23 @@
> >>  				regulator-max-microvolt = <1000000>;
> >>  			};
> >>  
> >> -			vcca_18: REG7  {
> >> -				regulator-name = "vcca_18";
> >> -				regulator-min-microvolt = <1800000>;
> >> -				regulator-max-microvolt = <1800000>;
> >> -				regulator-always-on;
> >> +			vcca_33: REG7  {
> >> +				regulator-name = "vcca_33";
> >> +				regulator-min-microvolt = <3300000>;
> >> +				regulator-max-microvolt = <3300000>;
> >>  			};
> >>  
> >> -			vcca_33: REG8 {
> >> -				regulator-name = "vcca_33";
> >> +			vcc_lan: REG8 {
> >> +				regulator-name = "vcc_lan";
> >>  				regulator-min-microvolt = <3300000>;
> >>  				regulator-max-microvolt = <3300000>;
> >> -				regulator-always-on;
> >>  			};
> >>  
> >> -			vcc_lan: REG9 {
> >> -				regulator-name = "vcca_lan";
> >> +			vccio_pmu: REG9 {
> >> +				regulator-name = "vccio_pmu";
> >>  				regulator-min-microvolt = <3300000>;
> >>  				regulator-max-microvolt = <3300000>;
> >> +				regulator-always-on;
> >>  			};
> >>  
> >>  			vdd_10: REG10 {
> >> @@ -218,6 +218,7 @@
> >>  				regulator-name = "vcc_18";
> >>  				regulator-min-microvolt = <1800000>;
> >>  				regulator-max-microvolt = <1800000>;
> >> +				regulator-always-on;
> >>  			};
> >>  
> >>  			vcc18_lcd: REG12 {
> >>
> > 
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> > 
> 
> 
>

[toc] | [prev] | [next] | [standalone]

#1649573

FromRobin Murphy <robin.murphy@arm.com>
Date2017-05-24 14:30 +0200
Message-ID<tKDAm-2jq-9@gated-at.bofh.it>
In reply to#1649512
On 24/05/17 12:34, Heiko Stuebner wrote:
> Am Mittwoch, 24. Mai 2017, 11:26:10 CEST schrieb Robin Murphy:
>> On 24/05/17 09:17, Heiko Stuebner wrote:
>>> Hi Eddie,
>>>
>>> Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai:
>>>> the previous setting of act8846 is just copy from firefly board. but
>>>> the reload board is a little different from firefly board. let's correct
>>>> it.
>>>>
>>>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>>>> ---
>>>>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++----------
>>>>  1 file changed, 11 insertions(+), 10 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>>>> index 8134966..4cfa109 100644
>>>> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>>>> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>>>> @@ -179,6 +179,7 @@
>>>>  				regulator-name = "vccio_sd";
>>>>  				regulator-min-microvolt = <3300000>;
>>>>  				regulator-max-microvolt = <3300000>;
>>>> +				regulator-always-on;
>>>
>>> the rest below looks pretty straight forward, but why does vccio_sd
>>> need to be always on?
>>>
>>> I've checked the reload's schematics but did not find any further users
>>> of vccio_sd that may warant this attribute.
>>
>> It looks like the card detect line is pulled up externally to vcc_sd,
>> which isn't always-on either, so you probably do want this - on the
>> (unrelated) rk3288 TV box I've been hacking on, I discovered that
>> powering off the sdmmc-supply domain also kills the internal pull-up and
>> leaves sdmmc_cd floating. The resulting stochastic card polling
>> mechanism is amusing, but probably undesirable ;)
> 
> Hmm, are you mixing up vcc_sd and vccio_sd?
> 
> vccio_sd is the io supply (vqmmc in mmc-terms) to the mmc-host itself
> while vcc_sd is the actual card supply (vmmc in mmc-terms).

Yes, that is what I meant, although I was implicitly assuming the case
where the MMC host driver has already turned off vcc_sd due to no card
being present. I'll double-check, but I'm 99% certain that *unlike*
Firefly, the Hotack board I've got (seemingly a straight implementation
of the "Box" reference design based on what I've managed to
reverse-engineer from scouring the internet) has no external pull-ups
for anything on its microSD socket, so is entirely reliant on everything
being pulled up internally to SDMMC0_VDD, i.e. vccio_sd.

> After looking through some schematics, the pull-up to vcc_sd seems to be
> the common pattern for rk3288 devices. So I guess this means the fixed
> regulator vcc_sd should get an regulator-always-on instead to stabilize
> the card-detect?

That might make sense, especially where vcc_sd is just vcc_io behind a
MOSFET switch, so turning it "off" when there's no card to draw power
anyway probably doesn't achieve much. Plus if you can then rely on
vcc_sd not going away it might be worth disabling the internal pull-ups
which are still being set by all the sdmmc_* pinctrl configs as well.

Robin.

>>>>  			};
>>>>  
>>>>  			vdd10_lcd: REG6 {
>>>> @@ -187,24 +188,23 @@
>>>>  				regulator-max-microvolt = <1000000>;
>>>>  			};
>>>>  
>>>> -			vcca_18: REG7  {
>>>> -				regulator-name = "vcca_18";
>>>> -				regulator-min-microvolt = <1800000>;
>>>> -				regulator-max-microvolt = <1800000>;
>>>> -				regulator-always-on;
>>>> +			vcca_33: REG7  {
>>>> +				regulator-name = "vcca_33";
>>>> +				regulator-min-microvolt = <3300000>;
>>>> +				regulator-max-microvolt = <3300000>;
>>>>  			};
>>>>  
>>>> -			vcca_33: REG8 {
>>>> -				regulator-name = "vcca_33";
>>>> +			vcc_lan: REG8 {
>>>> +				regulator-name = "vcc_lan";
>>>>  				regulator-min-microvolt = <3300000>;
>>>>  				regulator-max-microvolt = <3300000>;
>>>> -				regulator-always-on;
>>>>  			};
>>>>  
>>>> -			vcc_lan: REG9 {
>>>> -				regulator-name = "vcca_lan";
>>>> +			vccio_pmu: REG9 {
>>>> +				regulator-name = "vccio_pmu";
>>>>  				regulator-min-microvolt = <3300000>;
>>>>  				regulator-max-microvolt = <3300000>;
>>>> +				regulator-always-on;
>>>>  			};
>>>>  
>>>>  			vdd_10: REG10 {
>>>> @@ -218,6 +218,7 @@
>>>>  				regulator-name = "vcc_18";
>>>>  				regulator-min-microvolt = <1800000>;
>>>>  				regulator-max-microvolt = <1800000>;
>>>> +				regulator-always-on;
>>>>  			};
>>>>  
>>>>  			vcc18_lcd: REG12 {
>>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> linux-arm-kernel mailing list
>>> linux-arm-kernel@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>>
>>
>>
>>
> 
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web