Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1642285 > unrolled thread

[PATCH] irqchip: aspeed: Add AST2500 compatible string

Started byAndrew Jeffery <andrew@aj.id.au>
First post2017-05-16 10:00 +0200
Last post2017-05-23 02:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] irqchip: aspeed: Add AST2500 compatible string Andrew Jeffery <andrew@aj.id.au> - 2017-05-16 10:00 +0200
    Re: [PATCH] irqchip: aspeed: Add AST2500 compatible string Rob Herring <robh@kernel.org> - 2017-05-23 02:10 +0200

#1642285 — [PATCH] irqchip: aspeed: Add AST2500 compatible string

FromAndrew Jeffery <andrew@aj.id.au>
Date2017-05-16 10:00 +0200
Subject[PATCH] irqchip: aspeed: Add AST2500 compatible string
Message-ID<tHFyG-2LQ-17@gated-at.bofh.it>
In addition to introducing the new compatible string the bindings
description is reworked to be more generic.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 .../bindings/interrupt-controller/aspeed,ast2400-vic.txt         | 9 +++++----
 drivers/irqchip/irq-aspeed-vic.c                                 | 3 ++-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
index 6c6e85324b9d..e3fea0758d25 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
@@ -1,12 +1,13 @@
 Aspeed Vectored Interrupt Controller
 
-These bindings are for the Aspeed AST2400 interrupt controller register layout.
-The SoC has an legacy register layout, but this driver does not support that
-mode of operation.
+These bindings are for the Aspeed interrupt controller. The AST2400 and
+AST2500 SoC families include a legacy register layout before a re-designed
+layout, but the bindings do not prescribe the use of one or the other.
 
 Required properties:
 
-- compatible : should be "aspeed,ast2400-vic".
+- compatible : "aspeed,ast2400-vic"
+               "aspeed,ast2500-vic"
 
 - interrupt-controller : Identifies the node as an interrupt controller
 - #interrupt-cells : Specifies the number of cells needed to encode an
diff --git a/drivers/irqchip/irq-aspeed-vic.c b/drivers/irqchip/irq-aspeed-vic.c
index d24451d5bf8a..1c908ce25a9f 100644
--- a/drivers/irqchip/irq-aspeed-vic.c
+++ b/drivers/irqchip/irq-aspeed-vic.c
@@ -227,4 +227,5 @@ static int __init avic_of_init(struct device_node *node,
 	return 0;
 }
 
-IRQCHIP_DECLARE(aspeed_new_vic, "aspeed,ast2400-vic", avic_of_init);
+IRQCHIP_DECLARE(ast2400_vic, "aspeed,ast2400-vic", avic_of_init);
+IRQCHIP_DECLARE(ast2500_vic, "aspeed,ast2500-vic", avic_of_init);
-- 
2.9.3

[toc] | [next] | [standalone]


#1647505

FromRob Herring <robh@kernel.org>
Date2017-05-23 02:10 +0200
Message-ID<tK5yF-458-7@gated-at.bofh.it>
In reply to#1642285
On Tue, May 16, 2017 at 03:57:47PM +0800, Andrew Jeffery wrote:
> In addition to introducing the new compatible string the bindings
> description is reworked to be more generic.
> 
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
>  .../bindings/interrupt-controller/aspeed,ast2400-vic.txt         | 9 +++++----
>  drivers/irqchip/irq-aspeed-vic.c                                 | 3 ++-
>  2 files changed, 7 insertions(+), 5 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web