Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1647350 > unrolled thread

[PATCH] gpu: drm: gma500: remove two more dead variable

Started byArnd Bergmann <arnd@arndb.de>
First post2017-05-22 22:40 +0200
Last post2017-05-23 01:50 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] gpu: drm: gma500: remove two more dead variable Arnd Bergmann <arnd@arndb.de> - 2017-05-22 22:40 +0200
    Re: [PATCH] gpu: drm: gma500: remove two more dead variable "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-23 01:10 +0200
    Re: [PATCH] gpu: drm: gma500: remove two more dead variable Patrik Jakobsson <patrik.r.jakobsson@gmail.com> - 2017-05-23 01:50 +0200

#1647350 — [PATCH] gpu: drm: gma500: remove two more dead variable

FromArnd Bergmann <arnd@arndb.de>
Date2017-05-22 22:40 +0200
Subject[PATCH] gpu: drm: gma500: remove two more dead variable
Message-ID<tK2hr-1Tl-1@gated-at.bofh.it>
The dead code removal left two unused variables:

drivers/gpu/drm/gma500/mdfld_tpo_vid.c: In function 'tpo_vid_get_config_mode':
drivers/gpu/drm/gma500/mdfld_tpo_vid.c:34:31: error: unused variable 'ti' [-Werror=unused-variable]

This removes them as well.

Fixes: 94d7fb4982d2 ("gpu: drm: gma500: remove dead code")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/gma500/mdfld_tpo_vid.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/gma500/mdfld_tpo_vid.c b/drivers/gpu/drm/gma500/mdfld_tpo_vid.c
index d40628e6810d..a9420bf9a419 100644
--- a/drivers/gpu/drm/gma500/mdfld_tpo_vid.c
+++ b/drivers/gpu/drm/gma500/mdfld_tpo_vid.c
@@ -30,8 +30,6 @@
 static struct drm_display_mode *tpo_vid_get_config_mode(struct drm_device *dev)
 {
 	struct drm_display_mode *mode;
-	struct drm_psb_private *dev_priv = dev->dev_private;
-	struct oaktrail_timing_info *ti = &dev_priv->gct_data.DTD;
 
 	mode = kzalloc(sizeof(*mode), GFP_KERNEL);
 	if (!mode)
-- 
2.9.0

[toc] | [next] | [standalone]


#1647473

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-05-23 01:10 +0200
Message-ID<tK4CB-3wR-1@gated-at.bofh.it>
In reply to#1647350
Hi Arnd,

Quoting Arnd Bergmann <arnd@arndb.de>:

> The dead code removal left two unused variables:
>
> drivers/gpu/drm/gma500/mdfld_tpo_vid.c: In function  
> 'tpo_vid_get_config_mode':
> drivers/gpu/drm/gma500/mdfld_tpo_vid.c:34:31: error: unused variable  
> 'ti' [-Werror=unused-variable]
>
> This removes them as well.
>
> Fixes: 94d7fb4982d2 ("gpu: drm: gma500: remove dead code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/gma500/mdfld_tpo_vid.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_tpo_vid.c  
> b/drivers/gpu/drm/gma500/mdfld_tpo_vid.c
> index d40628e6810d..a9420bf9a419 100644
> --- a/drivers/gpu/drm/gma500/mdfld_tpo_vid.c
> +++ b/drivers/gpu/drm/gma500/mdfld_tpo_vid.c
> @@ -30,8 +30,6 @@
>  static struct drm_display_mode *tpo_vid_get_config_mode(struct  
> drm_device *dev)
>  {
>  	struct drm_display_mode *mode;
> -	struct drm_psb_private *dev_priv = dev->dev_private;
> -	struct oaktrail_timing_info *ti = &dev_priv->gct_data.DTD;
>
>  	mode = kzalloc(sizeof(*mode), GFP_KERNEL);
>  	if (!mode)
> --
> 2.9.0

Thank you!
--
Gustavo A. R. Silva

[toc] | [prev] | [next] | [standalone]


#1647494

FromPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Date2017-05-23 01:50 +0200
Message-ID<tK5fk-3JA-3@gated-at.bofh.it>
In reply to#1647350
On Mon, May 22, 2017 at 10:30 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The dead code removal left two unused variables:
>
> drivers/gpu/drm/gma500/mdfld_tpo_vid.c: In function 'tpo_vid_get_config_mode':
> drivers/gpu/drm/gma500/mdfld_tpo_vid.c:34:31: error: unused variable 'ti' [-Werror=unused-variable]
>
> This removes them as well.
>
> Fixes: 94d7fb4982d2 ("gpu: drm: gma500: remove dead code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, I'll take this through drm-misc

Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>

> ---
>  drivers/gpu/drm/gma500/mdfld_tpo_vid.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_tpo_vid.c b/drivers/gpu/drm/gma500/mdfld_tpo_vid.c
> index d40628e6810d..a9420bf9a419 100644
> --- a/drivers/gpu/drm/gma500/mdfld_tpo_vid.c
> +++ b/drivers/gpu/drm/gma500/mdfld_tpo_vid.c
> @@ -30,8 +30,6 @@
>  static struct drm_display_mode *tpo_vid_get_config_mode(struct drm_device *dev)
>  {
>         struct drm_display_mode *mode;
> -       struct drm_psb_private *dev_priv = dev->dev_private;
> -       struct oaktrail_timing_info *ti = &dev_priv->gct_data.DTD;
>
>         mode = kzalloc(sizeof(*mode), GFP_KERNEL);
>         if (!mode)
> --
> 2.9.0
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web