Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1646454 > unrolled thread
| Started by | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| First post | 2017-05-22 00:00 +0200 |
| Last post | 2017-05-23 01:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3] gpio: adp5588: move header file out of I2C realm Wolfram Sang <wsa@the-dreams.de> - 2017-05-22 00:00 +0200
Re: [PATCH 3/3] gpio: adp5588: move header file out of I2C realm Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-23 01:50 +0200
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-05-22 00:00 +0200 |
| Subject | [PATCH 3/3] gpio: adp5588: move header file out of I2C realm |
| Message-ID | <tJH3k-4QZ-5@gated-at.bofh.it> |
include/linux/i2c is not for client devices. Move the header file to a
more appropriate location.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
This driver could also go via the input-tree or my tree. I don't really care
and just picked some subsystem :) Let me know if you are okay with that.
arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
drivers/gpio/gpio-adp5588.c | 2 +-
drivers/input/keyboard/adp5588-keys.c | 2 +-
include/linux/{i2c => platform_data}/adp5588.h | 0
4 files changed, 3 insertions(+), 3 deletions(-)
rename include/linux/{i2c => platform_data}/adp5588.h (100%)
diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
index eaec7b4832a29a..24985e658c19cd 100644
--- a/arch/blackfin/mach-bf537/boards/stamp.c
+++ b/arch/blackfin/mach-bf537/boards/stamp.c
@@ -22,7 +22,7 @@
#include <linux/usb/isp1362.h>
#endif
#include <linux/i2c.h>
-#include <linux/i2c/adp5588.h>
+#include <linux/platform_data/adp5588.h>
#include <linux/etherdevice.h>
#include <linux/ata_platform.h>
#include <linux/irq.h>
diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c
index c0f718b1231727..e717f8dc39667c 100644
--- a/drivers/gpio/gpio-adp5588.c
+++ b/drivers/gpio/gpio-adp5588.c
@@ -16,7 +16,7 @@
#include <linux/interrupt.h>
#include <linux/irq.h>
-#include <linux/i2c/adp5588.h>
+#include <linux/platform_data/adp5588.h>
#define DRV_NAME "adp5588-gpio"
diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
index 53fe9a3fb6204d..f9d273c8b30695 100644
--- a/drivers/input/keyboard/adp5588-keys.c
+++ b/drivers/input/keyboard/adp5588-keys.c
@@ -20,7 +20,7 @@
#include <linux/gpio.h>
#include <linux/slab.h>
-#include <linux/i2c/adp5588.h>
+#include <linux/platform_data/adp5588.h>
/* Key Event Register xy */
#define KEY_EV_PRESSED (1 << 7)
diff --git a/include/linux/i2c/adp5588.h b/include/linux/platform_data/adp5588.h
similarity index 100%
rename from include/linux/i2c/adp5588.h
rename to include/linux/platform_data/adp5588.h
--
2.11.0
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-05-23 01:50 +0200 |
| Message-ID | <tK5fk-3JA-11@gated-at.bofh.it> |
| In reply to | #1646454 |
On Sun, May 21, 2017 at 11:57:27PM +0200, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> This driver could also go via the input-tree or my tree. I don't really care
> and just picked some subsystem :) Let me know if you are okay with that.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
> drivers/gpio/gpio-adp5588.c | 2 +-
> drivers/input/keyboard/adp5588-keys.c | 2 +-
> include/linux/{i2c => platform_data}/adp5588.h | 0
> 4 files changed, 3 insertions(+), 3 deletions(-)
> rename include/linux/{i2c => platform_data}/adp5588.h (100%)
>
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index eaec7b4832a29a..24985e658c19cd 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -22,7 +22,7 @@
> #include <linux/usb/isp1362.h>
> #endif
> #include <linux/i2c.h>
> -#include <linux/i2c/adp5588.h>
> +#include <linux/platform_data/adp5588.h>
> #include <linux/etherdevice.h>
> #include <linux/ata_platform.h>
> #include <linux/irq.h>
> diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c
> index c0f718b1231727..e717f8dc39667c 100644
> --- a/drivers/gpio/gpio-adp5588.c
> +++ b/drivers/gpio/gpio-adp5588.c
> @@ -16,7 +16,7 @@
> #include <linux/interrupt.h>
> #include <linux/irq.h>
>
> -#include <linux/i2c/adp5588.h>
> +#include <linux/platform_data/adp5588.h>
>
> #define DRV_NAME "adp5588-gpio"
>
> diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
> index 53fe9a3fb6204d..f9d273c8b30695 100644
> --- a/drivers/input/keyboard/adp5588-keys.c
> +++ b/drivers/input/keyboard/adp5588-keys.c
> @@ -20,7 +20,7 @@
> #include <linux/gpio.h>
> #include <linux/slab.h>
>
> -#include <linux/i2c/adp5588.h>
> +#include <linux/platform_data/adp5588.h>
>
> /* Key Event Register xy */
> #define KEY_EV_PRESSED (1 << 7)
> diff --git a/include/linux/i2c/adp5588.h b/include/linux/platform_data/adp5588.h
> similarity index 100%
> rename from include/linux/i2c/adp5588.h
> rename to include/linux/platform_data/adp5588.h
> --
> 2.11.0
>
--
Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web