Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646348 > unrolled thread

[PATCH 00/13] Linksys WRT3200ACM (Rango) support

Started byRalph Sennhauser <ralph.sennhauser@gmail.com>
First post2017-05-21 15:00 +0200
Last post2017-05-23 18:20 +0200
Articles 18 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/13] Linksys WRT3200ACM (Rango) support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-21 15:00 +0200
    [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-21 15:00 +0200
      Re: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit  prefixes Andrew Lunn <andrew@lunn.ch> - 2017-05-22 17:10 +0200
        Re: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit  prefixes Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-22 20:30 +0200
          Re: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit  prefixes Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-23 10:40 +0200
            Re: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit  prefixes Andrew Lunn <andrew@lunn.ch> - 2017-05-23 14:10 +0200
    [PATCH 03/13] ARM: dts: armada-385-linksys: flatten dependants Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-21 15:00 +0200
      Re: [PATCH 03/13] ARM: dts: armada-385-linksys: flatten dependants Andrew Lunn <andrew@lunn.ch> - 2017-05-22 17:00 +0200
    [PATCH 11/13] ARM: dts: armada-385-linksys: fixup button node names Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-21 15:00 +0200
      Re: [PATCH 11/13] ARM: dts: armada-385-linksys: fixup button node  names Andrew Lunn <andrew@lunn.ch> - 2017-05-23 14:10 +0200
    [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango) Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-21 15:00 +0200
      Re: [PATCH 13/13] ARM: dts: mvebu: add support for Linksys  WRT3200ACM (Rango) Andrew Lunn <andrew@lunn.ch> - 2017-05-23 14:20 +0200
      Re: [PATCH 13/13] ARM: dts: mvebu: add support for Linksys  WRT3200ACM (Rango) Andrew Lunn <andrew@lunn.ch> - 2017-05-23 14:30 +0200
        Re: [PATCH 13/13] ARM: dts: mvebu: add support for Linksys  WRT3200ACM (Rango) Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-23 22:10 +0200
    [PATCH 05/13] ARM: dts: armada-385-linksys: bm pools by label order Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-21 15:00 +0200
    Re: [PATCH 00/13] Linksys WRT3200ACM (Rango) support Imre Kaloz <kaloz@openwrt.org> - 2017-05-22 20:50 +0200
    Re: [PATCH 00/13] Linksys WRT3200ACM (Rango) support Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-05-23 17:30 +0200
      Re: [PATCH 00/13] Linksys WRT3200ACM (Rango) support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-05-23 18:20 +0200

#1646348 — [PATCH 00/13] Linksys WRT3200ACM (Rango) support

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-21 15:00 +0200
Subject[PATCH 00/13] Linksys WRT3200ACM (Rango) support
Message-ID<tJyCJ-7To-3@gated-at.bofh.it>
Hi everyone

This series adds support for the latest model in Linksys WRT AC series
of routers. The WRT3200ACM was released in October 2016 and the code
name is Rango.

As it comes with a flash chip twice as big the dts Imre Kaloz has
written for OpenWrt isn't based on armada-385-linksys.dtsi to avoid
conflicts. Nonetheless its part of the same family, so the bigger part
of this series is dedicated to reorganize / modernize / cleanup /
somewhat future proof the armada-385-linksys.dtsi and it's dependants so
the dts for the Rango addition can use the same dtsi.

Key differences to the earlier Armada-385 based devices in the series is
a bigger flash chip, next generation wireless modules in the mini pcie
slots as well as a Marvell SD8887. Finally the CPU is clocked at 1866
GHz by default.

The series depends on Linux 4.12-rc1 and is targeted for 4.13.

Ralph


Ralph Sennhauser (13):
  ARM: dts: armada-385-linksys: flatten dtsi
  ARM: dts: armada-385-linksys: label nodes
  ARM: dts: armada-385-linksys: flatten dependants
  ARM: dts: armada-385-linksys: drop redundant properties in dependants
  ARM: dts: armada-385-linksys: bm pools by label order
  ARM: dts: armada-385-linksys: usb3 label cleanup
  ARM: dts: armada-385-linksys: drop leagcy DSA bindings
  ARM: dts: armada-385-linksys: use binary unit prefixes
  ARM: dts: armada-385-linksys: partition layout is board specific
  ARM: dts: armada-385-linksys: group pins in pinctrl
  ARM: dts: armada-385-linksys: fixup button node names
  clk: mvebu: add support for 1866MHz variants
  ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)

 arch/arm/boot/dts/Makefile                      |   1 +
 arch/arm/boot/dts/armada-385-linksys-caiman.dts | 187 +++++++-----
 arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 187 +++++++-----
 arch/arm/boot/dts/armada-385-linksys-rango.dts  | 203 +++++++++++++
 arch/arm/boot/dts/armada-385-linksys-shelby.dts | 187 +++++++-----
 arch/arm/boot/dts/armada-385-linksys.dtsi       | 362 ++++++++----------------
 drivers/clk/mvebu/armada-38x.c                  |   3 +-
 7 files changed, 695 insertions(+), 435 deletions(-)
 create mode 100644 arch/arm/boot/dts/armada-385-linksys-rango.dts

-- 
2.10.2

[toc] | [next] | [standalone]

#1646349 — [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-21 15:00 +0200
Subject[PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes
Message-ID<tJyCK-7To-21@gated-at.bofh.it>
In reply to#1646348
Use IEEE 1541-2002 unit prefixes for sizes.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
---
 arch/arm/boot/dts/armada-385-linksys.dtsi | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
index f1d6b77..4049eaf 100644
--- a/arch/arm/boot/dts/armada-385-linksys.dtsi
+++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
@@ -52,7 +52,7 @@
 
 	memory {
 		device_type = "memory";
-		reg = <0x00000000 0x20000000>; /* 512 MB */
+		reg = <0x00000000 0x20000000>; /* 512 MiB */
 	};
 
 	soc {
@@ -180,50 +180,50 @@
 
 	partition@0 {
 		label = "u-boot";
-		reg = <0x0000000 0x200000>;  /* 2MB */
+		reg = <0x0000000 0x200000>;  /* 2MiB */
 		read-only;
 	};
 
 	partition@100000 {
 		label = "u_env";
-		reg = <0x200000 0x40000>;    /* 256KB */
+		reg = <0x200000 0x40000>;    /* 256KiB */
 	};
 
 	partition@140000 {
 		label = "s_env";
-		reg = <0x240000 0x40000>;    /* 256KB */
+		reg = <0x240000 0x40000>;    /* 256KiB */
 	};
 
 	partition@900000 {
 		label = "devinfo";
-		reg = <0x900000 0x100000>;   /* 1MB */
+		reg = <0x900000 0x100000>;   /* 1MiB */
 		read-only;
 	};
 
 	/* kernel1 overlaps with rootfs1 by design */
 	partition@a00000 {
 		label = "kernel1";
-		reg = <0xa00000 0x2800000>;  /* 40MB */
+		reg = <0xa00000 0x2800000>;  /* 40MiB */
 	};
 
 	partition@1000000 {
 		label = "rootfs1";
-		reg = <0x1000000 0x2200000>;  /* 34MB */
+		reg = <0x1000000 0x2200000>;  /* 34MiB */
 	};
 
 	/* kernel2 overlaps with rootfs2 by design */
 	partition@3200000 {
 		label = "kernel2";
-		reg = <0x3200000 0x2800000>; /* 40MB */
+		reg = <0x3200000 0x2800000>; /* 40MiB */
 	};
 
 	partition@3800000 {
 		label = "rootfs2";
-		reg = <0x3800000 0x2200000>; /* 34MB */
+		reg = <0x3800000 0x2200000>; /* 34MiB */
 	};
 
 	/*
-	 * 38MB, last MB is for the BBT, not writable
+	 * 38MiB, last MiB is for the BBT, not writable
 	 */
 	partition@5a00000 {
 		label = "syscfg";
@@ -238,7 +238,7 @@
 	 */
 	partition@180000 {
 		label = "unused_area";
-		reg = <0x280000 0x680000>;   /* 6.5MB */
+		reg = <0x280000 0x680000>;   /* 6.5MiB */
 	};
 };
 
-- 
2.10.2

[toc] | [prev] | [next] | [standalone]

#1647027 — Re: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes

FromAndrew Lunn <andrew@lunn.ch>
Date2017-05-22 17:10 +0200
SubjectRe: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes
Message-ID<tJX87-7gH-27@gated-at.bofh.it>
In reply to#1646349
On Sun, May 21, 2017 at 02:48:57PM +0200, Ralph Sennhauser wrote:
> Use IEEE 1541-2002 unit prefixes for sizes.

Does ePAPR recommend this?

I think this looks ugly, so i would not do it.

  Andrew

[toc] | [prev] | [next] | [standalone]

#1647251 — Re: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-22 20:30 +0200
SubjectRe: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes
Message-ID<tK0fE-HF-19@gated-at.bofh.it>
In reply to#1647027
On Mon, 22 May 2017 17:00:01 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> On Sun, May 21, 2017 at 02:48:57PM +0200, Ralph Sennhauser wrote:
> > Use IEEE 1541-2002 unit prefixes for sizes.  
> 
> Does ePAPR recommend this?

Not directly, but the paper (v1.1) itself is using MiB as well which
could be seen as a recommendation.

SI and NIST to my knowledge explicitly state to not use SI prefixes for
anything but powers of 10. Also as far as I'm aware any relevant
standard body adopted / endorsed these.

> 
> I think this looks ugly, so i would not do it.

Needs getting used to indeed. I for myself I can say I've gotten over
it by now. Grepping the Linux tree shows quite a few other examples of
MiB so this one wont feel lonely either.

Ralph

[toc] | [prev] | [next] | [standalone]

#1647791 — Re: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-23 10:40 +0200
SubjectRe: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes
Message-ID<tKdwd-Fm-9@gated-at.bofh.it>
In reply to#1647251
On Mon, 22 May 2017 20:24:16 +0200
Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:

> On Mon, 22 May 2017 17:00:01 +0200
> Andrew Lunn <andrew@lunn.ch> wrote:
> 
> > On Sun, May 21, 2017 at 02:48:57PM +0200, Ralph Sennhauser wrote:  
> > > Use IEEE 1541-2002 unit prefixes for sizes.    
> > 
> > Does ePAPR recommend this?  
> 
> Not directly, but the paper (v1.1) itself is using MiB as well which
> could be seen as a recommendation.

Found the pdf again on the web, so here a link:
http://elinux.org/images/c/cf/Power_ePAPR_APPROVED_v1.1.pdf

Funny thing it's using KB(instead of KiB) and MiB. So it's
inconsistent, also the unit with SI prefix would be kB and not KB. So
I'd say ePAPR doesn't care / the authors didn't pay any attention to
this.

Ralph

[toc] | [prev] | [next] | [standalone]

#1647964 — Re: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes

FromAndrew Lunn <andrew@lunn.ch>
Date2017-05-23 14:10 +0200
SubjectRe: [PATCH 08/13] ARM: dts: armada-385-linksys: use binary unit prefixes
Message-ID<tKgNr-30T-1@gated-at.bofh.it>
In reply to#1647791
On Tue, May 23, 2017 at 10:33:02AM +0200, Ralph Sennhauser wrote:
> On Mon, 22 May 2017 20:24:16 +0200
> Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:
> 
> > On Mon, 22 May 2017 17:00:01 +0200
> > Andrew Lunn <andrew@lunn.ch> wrote:
> > 
> > > On Sun, May 21, 2017 at 02:48:57PM +0200, Ralph Sennhauser wrote:  
> > > > Use IEEE 1541-2002 unit prefixes for sizes.    
> > > 
> > > Does ePAPR recommend this?  
> > 
> > Not directly, but the paper (v1.1) itself is using MiB as well which
> > could be seen as a recommendation.
> 
> Found the pdf again on the web, so here a link:
> http://elinux.org/images/c/cf/Power_ePAPR_APPROVED_v1.1.pdf
> 
> Funny thing it's using KB(instead of KiB) and MiB. So it's
> inconsistent, also the unit with SI prefix would be kB and not KB. So
> I'd say ePAPR doesn't care / the authors didn't pay any attention to
> this.

Hi Ralph

Thanks for checking into this.

My preference, and it is only a preference, is to not do this. Keep
with MB, KB.

   Andrew

[toc] | [prev] | [next] | [standalone]

#1646350 — [PATCH 03/13] ARM: dts: armada-385-linksys: flatten dependants

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-21 15:00 +0200
Subject[PATCH 03/13] ARM: dts: armada-385-linksys: flatten dependants
Message-ID<tJyCK-7To-25@gated-at.bofh.it>
In reply to#1646348
Flatten dts of individual boards to match the new style used in
armada-385-linksys.dtsi and for the Rango addition.

* Caiman - Linksys WRT1200AC v1 & v2
* Cobra - Linksys WRT1900AC v2
* Shelby - Linksys WRT1900ACS v1 & v2

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>

---

Notes:

  power and sata in &gpio_leds don't use references when they could,
  feels like overdoing things even though it violates one of the guiding
  principles of not recreating structure. If someone thinks such a
  change is meaningful I don't mind submitting a followup patch, though
  would look odd with the Rango dts.
---
 arch/arm/boot/dts/armada-385-linksys-caiman.dts | 99 ++++++++++++-------------
 arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 99 ++++++++++++-------------
 arch/arm/boot/dts/armada-385-linksys-shelby.dts | 99 ++++++++++++-------------
 3 files changed, 138 insertions(+), 159 deletions(-)

diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
index f3cee91..765c939 100644
--- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
@@ -44,71 +44,64 @@
 	model = "Linksys WRT1200AC";
 	compatible = "linksys,caiman", "linksys,armada385", "marvell,armada385",
 		     "marvell,armada380";
+};
 
-	soc {
-		internal-regs{
-			i2c@11000 {
-
-				pca9635@68 {
-				#address-cells = <1>;
-				#size-cells = <0>;
+&expander0 {
+	#address-cells = <1>;
+	#size-cells = <0>;
 
-					wan_amber@0 {
-						label = "caiman:amber:wan";
-						reg = <0x0>;
-					};
+	wan_amber@0 {
+		label = "caiman:amber:wan";
+		reg = <0x0>;
+	};
 
-					wan_white@1 {
-						label = "caiman:white:wan";
-						reg = <0x1>;
-					};
+	wan_white@1 {
+		label = "caiman:white:wan";
+		reg = <0x1>;
+	};
 
-					wlan_2g@2 {
-						label = "caiman:white:wlan_2g";
-						reg = <0x2>;
-					};
+	wlan_2g@2 {
+		label = "caiman:white:wlan_2g";
+		reg = <0x2>;
+	};
 
-					wlan_5g@3 {
-						label = "caiman:white:wlan_5g";
-						reg = <0x3>;
-					};
+	wlan_5g@3 {
+		label = "caiman:white:wlan_5g";
+		reg = <0x3>;
+	};
 
-					usb2@5 {
-						label = "caiman:white:usb2";
-						reg = <0x5>;
-					};
+	usb2@5 {
+		label = "caiman:white:usb2";
+		reg = <0x5>;
+	};
 
-					usb3_1@6 {
-						label = "caiman:white:usb3_1";
-						reg = <0x6>;
-					};
+	usb3_1@6 {
+		label = "caiman:white:usb3_1";
+		reg = <0x6>;
+	};
 
-					usb3_2@7 {
-						label = "caiman:white:usb3_2";
-						reg = <0x7>;
-					};
+	usb3_2@7 {
+		label = "caiman:white:usb3_2";
+		reg = <0x7>;
+	};
 
-					wps_white@8 {
-						label = "caiman:white:wps";
-						reg = <0x8>;
-					};
+	wps_white@8 {
+		label = "caiman:white:wps";
+		reg = <0x8>;
+	};
 
-					wps_amber@9 {
-						label = "caiman:amber:wps";
-						reg = <0x9>;
-					};
-				};
-			};
-		};
+	wps_amber@9 {
+		label = "caiman:amber:wps";
+		reg = <0x9>;
 	};
+};
 
-	gpio-leds {
-		power {
-			label = "caiman:white:power";
-		};
+&gpio_leds {
+	power {
+		label = "caiman:white:power";
+	};
 
-		sata {
-			label = "caiman:white:sata";
-		};
+	sata {
+		label = "caiman:white:sata";
 	};
 };
diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
index 1110718..2ae1e71 100644
--- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
@@ -44,71 +44,64 @@
 	model = "Linksys WRT1900ACv2";
 	compatible = "linksys,cobra", "linksys,armada385", "marvell,armada385",
 		     "marvell,armada380";
+};
 
-	soc {
-		internal-regs{
-			i2c@11000 {
-
-				pca9635@68 {
-				#address-cells = <1>;
-				#size-cells = <0>;
+&expander0 {
+	#address-cells = <1>;
+	#size-cells = <0>;
 
-					wan_amber@0 {
-						label = "cobra:amber:wan";
-						reg = <0x0>;
-					};
+	wan_amber@0 {
+		label = "cobra:amber:wan";
+		reg = <0x0>;
+	};
 
-					wan_white@1 {
-						label = "cobra:white:wan";
-						reg = <0x1>;
-					};
+	wan_white@1 {
+		label = "cobra:white:wan";
+		reg = <0x1>;
+	};
 
-					wlan_2g@2 {
-						label = "cobra:white:wlan_2g";
-						reg = <0x2>;
-					};
+	wlan_2g@2 {
+		label = "cobra:white:wlan_2g";
+		reg = <0x2>;
+	};
 
-					wlan_5g@3 {
-						label = "cobra:white:wlan_5g";
-						reg = <0x3>;
-					};
+	wlan_5g@3 {
+		label = "cobra:white:wlan_5g";
+		reg = <0x3>;
+	};
 
-					usb2@5 {
-						label = "cobra:white:usb2";
-						reg = <0x5>;
-					};
+	usb2@5 {
+		label = "cobra:white:usb2";
+		reg = <0x5>;
+	};
 
-					usb3_1@6 {
-						label = "cobra:white:usb3_1";
-						reg = <0x6>;
-					};
+	usb3_1@6 {
+		label = "cobra:white:usb3_1";
+		reg = <0x6>;
+	};
 
-					usb3_2@7 {
-						label = "cobra:white:usb3_2";
-						reg = <0x7>;
-					};
+	usb3_2@7 {
+		label = "cobra:white:usb3_2";
+		reg = <0x7>;
+	};
 
-					wps_white@8 {
-						label = "cobra:white:wps";
-						reg = <0x8>;
-					};
+	wps_white@8 {
+		label = "cobra:white:wps";
+		reg = <0x8>;
+	};
 
-					wps_amber@9 {
-						label = "cobra:amber:wps";
-						reg = <0x9>;
-					};
-				};
-			};
-		};
+	wps_amber@9 {
+		label = "cobra:amber:wps";
+		reg = <0x9>;
 	};
+};
 
-	gpio-leds {
-		power {
-			label = "cobra:white:power";
-		};
+&gpio_leds {
+	power {
+		label = "cobra:white:power";
+	};
 
-		sata {
-			label = "cobra:white:sata";
-		};
+	sata {
+		label = "cobra:white:sata";
 	};
 };
diff --git a/arch/arm/boot/dts/armada-385-linksys-shelby.dts b/arch/arm/boot/dts/armada-385-linksys-shelby.dts
index c7a8ddd..74f4273 100644
--- a/arch/arm/boot/dts/armada-385-linksys-shelby.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-shelby.dts
@@ -44,71 +44,64 @@
 	model = "Linksys WRT1900ACS";
 	compatible = "linksys,shelby", "linksys,armada385", "marvell,armada385",
 		     "marvell,armada380";
+};
 
-	soc {
-		internal-regs{
-			i2c@11000 {
-
-				pca9635@68 {
-				#address-cells = <1>;
-				#size-cells = <0>;
+&expander0 {
+	#address-cells = <1>;
+	#size-cells = <0>;
 
-					wan_amber@0 {
-						label = "shelby:amber:wan";
-						reg = <0x0>;
-					};
+	wan_amber@0 {
+		label = "shelby:amber:wan";
+		reg = <0x0>;
+	};
 
-					wan_white@1 {
-						label = "shelby:white:wan";
-						reg = <0x1>;
-					};
+	wan_white@1 {
+		label = "shelby:white:wan";
+		reg = <0x1>;
+	};
 
-					wlan_2g@2 {
-						label = "shelby:white:wlan_2g";
-						reg = <0x2>;
-					};
+	wlan_2g@2 {
+		label = "shelby:white:wlan_2g";
+		reg = <0x2>;
+	};
 
-					wlan_5g@3 {
-						label = "shelby:white:wlan_5g";
-						reg = <0x3>;
-					};
+	wlan_5g@3 {
+		label = "shelby:white:wlan_5g";
+		reg = <0x3>;
+	};
 
-					usb2@5 {
-						label = "shelby:white:usb2";
-						reg = <0x5>;
-					};
+	usb2@5 {
+		label = "shelby:white:usb2";
+		reg = <0x5>;
+	};
 
-					usb3_1@6 {
-						label = "shelby:white:usb3_1";
-						reg = <0x6>;
-					};
+	usb3_1@6 {
+		label = "shelby:white:usb3_1";
+		reg = <0x6>;
+	};
 
-					usb3_2@7 {
-						label = "shelby:white:usb3_2";
-						reg = <0x7>;
-					};
+	usb3_2@7 {
+		label = "shelby:white:usb3_2";
+		reg = <0x7>;
+	};
 
-					wps_white@8 {
-						label = "shelby:white:wps";
-						reg = <0x8>;
-					};
+	wps_white@8 {
+		label = "shelby:white:wps";
+		reg = <0x8>;
+	};
 
-					wps_amber@9 {
-						label = "shelby:amber:wps";
-						reg = <0x9>;
-					};
-				};
-			};
-		};
+	wps_amber@9 {
+		label = "shelby:amber:wps";
+		reg = <0x9>;
 	};
+};
 
-	gpio-leds {
-		power {
-			label = "shelby:white:power";
-		};
+&gpio_leds {
+	power {
+		label = "shelby:white:power";
+	};
 
-		sata {
-			label = "shelby:white:sata";
-		};
+	sata {
+		label = "shelby:white:sata";
 	};
 };
-- 
2.10.2

[toc] | [prev] | [next] | [standalone]

#1647018 — Re: [PATCH 03/13] ARM: dts: armada-385-linksys: flatten dependants

FromAndrew Lunn <andrew@lunn.ch>
Date2017-05-22 17:00 +0200
SubjectRe: [PATCH 03/13] ARM: dts: armada-385-linksys: flatten dependants
Message-ID<tJWYq-6XB-15@gated-at.bofh.it>
In reply to#1646350
On Sun, May 21, 2017 at 02:48:52PM +0200, Ralph Sennhauser wrote:
> Flatten dts of individual boards to match the new style used in
> armada-385-linksys.dtsi and for the Rango addition.
> 
> * Caiman - Linksys WRT1200AC v1 & v2
> * Cobra - Linksys WRT1900AC v2
> * Shelby - Linksys WRT1900ACS v1 & v2
> 
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

[toc] | [prev] | [next] | [standalone]

#1646351 — [PATCH 11/13] ARM: dts: armada-385-linksys: fixup button node names

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-21 15:00 +0200
Subject[PATCH 11/13] ARM: dts: armada-385-linksys: fixup button node names
Message-ID<tJyCL-7To-29@gated-at.bofh.it>
In reply to#1646348
Buttons don't have a reg property; drop pseudo address and fixup names
of individual button nodes. Also drop #address-cells and #size-cells
properties.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
---
 arch/arm/boot/dts/armada-385-linksys.dtsi | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
index 1bb974a..e1f355f 100644
--- a/arch/arm/boot/dts/armada-385-linksys.dtsi
+++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
@@ -81,18 +81,16 @@
 
 	gpio_keys: gpio-keys {
 		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
 		pinctrl-0 = <&gpio_keys_pins>;
 		pinctrl-names = "default";
 
-		button@1 {
+		wps {
 			label = "WPS";
 			linux,code = <KEY_WPS_BUTTON>;
 			gpios = <&gpio0 24 GPIO_ACTIVE_LOW>;
 		};
 
-		button@2 {
+		reset {
 			label = "Factory Reset Button";
 			linux,code = <KEY_RESTART>;
 			gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
-- 
2.10.2

[toc] | [prev] | [next] | [standalone]

#1647968 — Re: [PATCH 11/13] ARM: dts: armada-385-linksys: fixup button node names

FromAndrew Lunn <andrew@lunn.ch>
Date2017-05-23 14:10 +0200
SubjectRe: [PATCH 11/13] ARM: dts: armada-385-linksys: fixup button node names
Message-ID<tKgNs-30T-17@gated-at.bofh.it>
In reply to#1646351
On Sun, May 21, 2017 at 02:49:00PM +0200, Ralph Sennhauser wrote:
> Buttons don't have a reg property; drop pseudo address and fixup names
> of individual button nodes. Also drop #address-cells and #size-cells
> properties.
> 
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

[toc] | [prev] | [next] | [standalone]

#1646353 — [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-21 15:00 +0200
Subject[PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)
Message-ID<tJyCL-7To-31@gated-at.bofh.it>
In reply to#1646348
The Linksys WRT3200ACM (Rango) is the lates Armada-385 based router in
the Linksys WRT AC Series which got released in October 2016.

The file armada-385-linksys-rango.dts is loosly based off of a DTS
authored by Imre Kaloz.

As Rango is part of the armada-385-linksys family of boards use the
armada-385-linksys.dtsi as basis. As for functional differences to Imre
Kaloz dts, the wlan LEDs aren't connected to the expander chip pca9635
but directly to GPIOs. Then mpp47 controls the USB2.0 port and not the
USB3.0 port, so use the correct GPIO mpp44 for it.

Other changes can be categorized as just cleanup / reorganization due to
using the armada-385-linksys.dtsi.

URL: https://github.com/openwrt/openwrt/blob/0abc3fa5a996daf7dafdc7794ccfe3fa7e955c5a/target/linux/mvebu/files/arch/arm/boot/dts/armada-385-linksys-rango.dts
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>

---

Notes:

  The sdhci node is taken as is, the current node lets one use the
  wireless part of the attached sd8887. There is an issue with the
  initalization of the bluetooth firmware though. Haven't had the time
  to investigate that in depth so far but shouldn't hold up the Rango
  addition.

  The non-removable property might be more appropriate than broken-cd
  though.

  Checkpatch complains about the line length of the URL, though not much
  room there. Checkpatch also complains about the vendor prefix linksys
  not being documented, however this follows the examples given by the
  other boards.
---
 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/armada-385-linksys-rango.dts | 203 +++++++++++++++++++++++++
 2 files changed, 204 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-385-linksys-rango.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 9c5e1d9..6be2974 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -999,6 +999,7 @@ dtb-$(CONFIG_MACH_ARMADA_38X) += \
 	armada-385-db-ap.dtb \
 	armada-385-linksys-caiman.dtb \
 	armada-385-linksys-cobra.dtb \
+	armada-385-linksys-rango.dtb \
 	armada-385-linksys-shelby.dtb \
 	armada-385-synology-ds116.dtb \
 	armada-385-turris-omnia.dtb \
diff --git a/arch/arm/boot/dts/armada-385-linksys-rango.dts b/arch/arm/boot/dts/armada-385-linksys-rango.dts
new file mode 100644
index 0000000..86f3207
--- /dev/null
+++ b/arch/arm/boot/dts/armada-385-linksys-rango.dts
@@ -0,0 +1,203 @@
+/*
+ * Device Tree file for the Linksys WRT3200ACM (Rango)
+ *
+ * Copyright (C) 2016 Imre Kaloz <kaloz@openwrt.org>
+ *
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is licensed under the terms of the GNU General Public
+ *     License version 2.  This program is licensed "as is" without
+ *     any warranty of any kind, whether express or implied.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include "armada-385-linksys.dtsi"
+
+/ {
+	model = "Linksys WRT3200ACM";
+	compatible = "linksys,rango", "linksys,armada385", "marvell,armada385",
+		     "marvell,armada380";
+};
+
+&expander0 {
+	wan_amber@0 {
+		label = "rango:amber:wan";
+		reg = <0x0>;
+	};
+
+	wan_white@1 {
+		label = "rango:white:wan";
+		reg = <0x1>;
+	};
+
+	usb2@5 {
+		label = "rango:white:usb2";
+		reg = <0x5>;
+	};
+
+	usb3_1@6 {
+		label = "rango:white:usb3_1";
+		reg = <0x6>;
+	};
+
+	usb3_2@7 {
+		label = "rango:white:usb3_2";
+		reg = <0x7>;
+	};
+
+	wps_white@8 {
+		label = "rango:white:wps";
+		reg = <0x8>;
+	};
+
+	wps_amber@9 {
+		label = "rango:amber:wps";
+		reg = <0x9>;
+	};
+};
+
+&gpio_leds {
+	power {
+		gpios = <&gpio1 24 GPIO_ACTIVE_HIGH>;
+		label = "rango:white:power";
+	};
+
+	sata {
+		gpios = <&gpio0 21 GPIO_ACTIVE_LOW>;
+		label = "rango:white:sata";
+	};
+
+	wlan_2g {
+		gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
+		label = "rango:white:wlan_2g";
+	};
+
+	wlan_5g {
+		gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
+		label = "rango:white:wlan_5g";
+	};
+};
+
+&gpio_leds_pins {
+	marvell,pins = "mpp21", "mpp45", "mpp46", "mpp56";
+};
+
+&nand {
+	/* AMD/Spansion S34ML02G2 256MiB, OEM Layout */
+
+	partition@0 {
+		label = "u-boot";
+		reg = <0x0000000 0x200000>;  /* 2MiB */
+		read-only;
+	};
+
+	partition@200000 {
+		label = "u_env";
+		reg = <0x200000 0x20000>;    /* 128KiB */
+	};
+
+	partition@220000 {
+		label = "s_env";
+		reg = <0x220000 0x40000>;    /* 256KiB */
+	};
+
+	partition@7e0000 {
+		label = "devinfo";
+		reg = <0x7e0000 0x40000>;   /* 256KiB */
+		read-only;
+	};
+
+	partition@820000 {
+		label = "sysdiag";
+		reg = <0x820000 0x1e0000>;   /* 1920KiB */
+		read-only;
+	};
+
+	/* kernel1 overlaps with rootfs1 by design */
+	partition@a00000 {
+		label = "kernel1";
+		reg = <0xa00000 0x5000000>;  /* 80MiB */
+	};
+
+	partition@1000000 {
+		label = "rootfs1";
+		reg = <0x1000000 0x4a00000>;  /* 74MiB */
+	};
+
+	/* kernel2 overlaps with rootfs2 by design */
+	partition@5a00000 {
+		label = "kernel2";
+		reg = <0x5a00000 0x5000000>; /* 80MiB */
+	};
+
+	partition@6000000 {
+		label = "rootfs2";
+		reg = <0x6000000 0x4a00000>; /* 74MiB */
+	};
+
+	/*
+	 * 86MiB, last MiB is for the BBT, not writable
+	 */
+	partition@aa00000 {
+		label = "syscfg";
+		reg = <0xaa00000 0x5600000>;
+	};
+
+	/*
+	 * Unused area between "s_env" and "devinfo".
+	 * Moved here because otherwise the renumbered
+	 * partitions would break the bootloader
+	 * supplied bootargs
+	 */
+	partition@180000 {
+		label = "unused_area";
+		reg = <0x260000 0x5c0000>;   /* 5.75MiB */
+	};
+};
+
+&sdhci {
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdhci_pins>;
+	no-1-8-v;
+	broken-cd;
+	wp-inverted;
+	bus-width = <8>;
+	status = "okay";
+};
+
+&usb3_1_vbus {
+	gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>;
+};
+
+&usb3_1_vbus_pins {
+	marvell,pins = "mpp44";
+};
-- 
2.10.2

[toc] | [prev] | [next] | [standalone]

#1647972 — Re: [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)

FromAndrew Lunn <andrew@lunn.ch>
Date2017-05-23 14:20 +0200
SubjectRe: [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)
Message-ID<tKgX8-34J-3@gated-at.bofh.it>
In reply to#1646353
>   Checkpatch also complains about the vendor prefix linksys
>   not being documented, however this follows the examples given by the
>   other boards.

Hi Ralph

Please feel free to submit a patch adding linksys to
Documentation/devicetree/binding/vendor-prefixes.txt

	Andrew

[toc] | [prev] | [next] | [standalone]

#1647978 — Re: [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)

FromAndrew Lunn <andrew@lunn.ch>
Date2017-05-23 14:30 +0200
SubjectRe: [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)
Message-ID<tKh6N-38u-7@gated-at.bofh.it>
In reply to#1646353
>   The non-removable property might be more appropriate than broken-cd
>   though.

I think non-removable is also better.

Otherwise, this looks good.

	   Andrew

[toc] | [prev] | [next] | [standalone]

#1648388 — Re: [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-23 22:10 +0200
SubjectRe: [PATCH 13/13] ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)
Message-ID<tKohY-887-19@gated-at.bofh.it>
In reply to#1647978
On Tue, 23 May 2017 14:25:21 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> >   The non-removable property might be more appropriate than
> > broken-cd though.  
> 
> I think non-removable is also better.
> 
> Otherwise, this looks good.
> 
> 	   Andrew

Hi Andrew

Will send out a V2 using non-removable and with updated commit message.

About adding the vendor prefix linksys to the documentation, I put it on
my TODO list.

Thanks for all your review work.
Ralph

[toc] | [prev] | [next] | [standalone]

#1646354 — [PATCH 05/13] ARM: dts: armada-385-linksys: bm pools by label order

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-21 15:00 +0200
Subject[PATCH 05/13] ARM: dts: armada-385-linksys: bm pools by label order
Message-ID<tJyCL-7To-33@gated-at.bofh.it>
In reply to#1646348
Which pools we assing doesn't matter. Use the order which doesen't leave
a chance for questions for first time readers.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
---
 arch/arm/boot/dts/armada-385-linksys.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
index b7f0a16..932fca4 100644
--- a/arch/arm/boot/dts/armada-385-linksys.dtsi
+++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
@@ -180,8 +180,8 @@
 	status = "okay";
 	phy-mode = "rgmii-id";
 	buffer-manager = <&bm>;
-	bm,pool-long = <2>;
-	bm,pool-short = <3>;
+	bm,pool-long = <0>;
+	bm,pool-short = <1>;
 	fixed-link {
 		speed = <1000>;
 		full-duplex;
@@ -192,8 +192,8 @@
 	status = "okay";
 	phy-mode = "sgmii";
 	buffer-manager = <&bm>;
-	bm,pool-long = <0>;
-	bm,pool-short = <1>;
+	bm,pool-long = <2>;
+	bm,pool-short = <3>;
 	fixed-link {
 		speed = <1000>;
 		full-duplex;
-- 
2.10.2

[toc] | [prev] | [next] | [standalone]

#1647265

FromImre Kaloz <kaloz@openwrt.org>
Date2017-05-22 20:50 +0200
Message-ID<tK0z0-NW-31@gated-at.bofh.it>
In reply to#1646348
Hi everyone,

For the whole series feel free to add

Signed-off-by: Imre Kaloz <kaloz@openwrt.org>


Best,

Imre

On 2017-05-21 05:48, Ralph Sennhauser wrote:
> Hi everyone
>
> This series adds support for the latest model in Linksys WRT AC series
> of routers. The WRT3200ACM was released in October 2016 and the code
> name is Rango.
>
> As it comes with a flash chip twice as big the dts Imre Kaloz has
> written for OpenWrt isn't based on armada-385-linksys.dtsi to avoid
> conflicts. Nonetheless its part of the same family, so the bigger part
> of this series is dedicated to reorganize / modernize / cleanup /
> somewhat future proof the armada-385-linksys.dtsi and it's dependants so
> the dts for the Rango addition can use the same dtsi.
>
> Key differences to the earlier Armada-385 based devices in the series is
> a bigger flash chip, next generation wireless modules in the mini pcie
> slots as well as a Marvell SD8887. Finally the CPU is clocked at 1866
> GHz by default.
>
> The series depends on Linux 4.12-rc1 and is targeted for 4.13.
>
> Ralph
>
>
> Ralph Sennhauser (13):
>    ARM: dts: armada-385-linksys: flatten dtsi
>    ARM: dts: armada-385-linksys: label nodes
>    ARM: dts: armada-385-linksys: flatten dependan
>    ARM: dts: armada-385-linksys: drop redundant properties in dependants
>    ARM: dts: armada-385-linksys: bm pools by label order
>    ARM: dts: armada-385-linksys: usb3 label cleanup
>    ARM: dts: armada-385-linksys: drop leagcy DSA bindings
>    ARM: dts: armada-385-linksys: use binary unit prefixes
>    ARM: dts: armada-385-linksys: partition layout is board specific
>    ARM: dts: armada-385-linksys: group pins in pinctrl
>    ARM: dts: armada-385-linksys: fixup button node names
>    clk: mvebu: add support for 1866MHz variants
>    ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)
>
>   arch/arm/boot/dts/Makefile                      |   1 +
>   arch/arm/boot/dts/armada-385-linksys-caiman.dts | 187 +++++++-----
>   arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 187 +++++++-----
>   arch/arm/boot/dts/armada-385-linksys-rango.dts  | 203 +++++++++++++
>   arch/arm/boot/dts/armada-385-linksys-shelby.dts | 187 +++++++-----
>   arch/arm/boot/dts/armada-385-linksys.dtsi       | 362 ++++++++----------------
>   drivers/clk/mvebu/armada-38x.c                  |   3 +-
>   7 files changed, 695 insertions(+), 435 deletions(-)
>   create mode 100644 arch/arm/boot/dts/armada-385-linksys-rango.dts
>

[toc] | [prev] | [next] | [standalone]

#1648196

FromGregory CLEMENT <gregory.clement@free-electrons.com>
Date2017-05-23 17:30 +0200
Message-ID<tKjV1-51B-27@gated-at.bofh.it>
In reply to#1646348
Hi Ralph,
 
 On dim., mai 21 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:

> Hi everyone
>
> This series adds support for the latest model in Linksys WRT AC series
> of routers. The WRT3200ACM was released in October 2016 and the code
> name is Rango.
>
> As it comes with a flash chip twice as big the dts Imre Kaloz has
> written for OpenWrt isn't based on armada-385-linksys.dtsi to avoid
> conflicts. Nonetheless its part of the same family, so the bigger part
> of this series is dedicated to reorganize / modernize / cleanup /
> somewhat future proof the armada-385-linksys.dtsi and it's dependants so
> the dts for the Rango addition can use the same dtsi.
>
> Key differences to the earlier Armada-385 based devices in the series is
> a bigger flash chip, next generation wireless modules in the mini pcie
> slots as well as a Marvell SD8887. Finally the CPU is clocked at 1866
> GHz by default.
>
> The series depends on Linux 4.12-rc1 and is targeted for 4.13.
>
> Ralph
>
>

I applied the 11 first patches on mvebu/dt. I added the "Signed-off-by"
from Imre Kaloz <kaloz@openwrt.org> on all of them and the "Reviewed-by"
from Andrew Lunn <andrew@lunn.ch> when approriate.

I also did the following things:

> Ralph Sennhauser (13):
>   ARM: dts: armada-385-linksys: flatten dtsi
>   ARM: dts: armada-385-linksys: label nodes
Fixed typo pointed by Andrew

>   ARM: dts: armada-385-linksys: flatten dependants
Fixed typo pointed by Andrew

Something that I didn't change is the word "dependants", I don't know
what do you means exactly. But not being native speaker I maybe missed
something.

>   ARM: dts: armada-385-linksys: drop redundant properties in dependants
>   ARM: dts: armada-385-linksys: bm pools by label order
>   ARM: dts: armada-385-linksys: usb3 label cleanup

I applied this one because I found Ralph explanation convincing about not
modifying the ABI

>   ARM: dts: armada-385-linksys: drop leagcy DSA bindings
Fixed typo in title and commit log

>   ARM: dts: armada-385-linksys: use binary unit prefixes

As Ralph I prefer that we use normalized unit. Especially when we use
MiB or KiB then we are sure that we use a power of 2, whereas when we
see KB we don't know if it is 1024B or 1000B.

>   ARM: dts: armada-385-linksys: partition layout is board specific
>   ARM: dts: armada-385-linksys: group pins in pinctrl
>   ARM: dts: armada-385-linksys: fixup button node names

>   clk: mvebu: add support for 1866MHz variants

I didn't apply this one as it must go through the clk tree and there was
also a pending question from Andrew.

>   ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)

For this last one do you finally agree to use "non-removable" instead of
"broken-cd" ?

Gregory

>
>  arch/arm/boot/dts/Makefile                      |   1 +
>  arch/arm/boot/dts/armada-385-linksys-caiman.dts | 187 +++++++-----
>  arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 187 +++++++-----
>  arch/arm/boot/dts/armada-385-linksys-rango.dts  | 203 +++++++++++++
>  arch/arm/boot/dts/armada-385-linksys-shelby.dts | 187 +++++++-----
>  arch/arm/boot/dts/armada-385-linksys.dtsi       | 362 ++++++++----------------
>  drivers/clk/mvebu/armada-38x.c                  |   3 +-
>  7 files changed, 695 insertions(+), 435 deletions(-)
>  create mode 100644 arch/arm/boot/dts/armada-385-linksys-rango.dts
>
> -- 
> 2.10.2
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1648243

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-05-23 18:20 +0200
Message-ID<tKkHn-5y2-5@gated-at.bofh.it>
In reply to#1648196
On Tue, 23 May 2017 17:22:05 +0200
Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi Ralph,
>  
>  On dim., mai 21 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com>
> wrote:
> 
> > Hi everyone
> >
> > This series adds support for the latest model in Linksys WRT AC
> > series of routers. The WRT3200ACM was released in October 2016 and
> > the code name is Rango.
> >
> > As it comes with a flash chip twice as big the dts Imre Kaloz has
> > written for OpenWrt isn't based on armada-385-linksys.dtsi to avoid
> > conflicts. Nonetheless its part of the same family, so the bigger
> > part of this series is dedicated to reorganize / modernize /
> > cleanup / somewhat future proof the armada-385-linksys.dtsi and
> > it's dependants so the dts for the Rango addition can use the same
> > dtsi.
> >
> > Key differences to the earlier Armada-385 based devices in the
> > series is a bigger flash chip, next generation wireless modules in
> > the mini pcie slots as well as a Marvell SD8887. Finally the CPU is
> > clocked at 1866 GHz by default.
> >
> > The series depends on Linux 4.12-rc1 and is targeted for 4.13.
> >
> > Ralph
> >
> >  
> 

Hi Gregory,

> I applied the 11 first patches on mvebu/dt. I added the
> "Signed-off-by" from Imre Kaloz <kaloz@openwrt.org> on all of them
> and the "Reviewed-by" from Andrew Lunn <andrew@lunn.ch> when
> approriate.

That was a lot faster than expected

> 
> I also did the following things:
> 
> > Ralph Sennhauser (13):
> >   ARM: dts: armada-385-linksys: flatten dtsi

Just noticed the commit message has "helps helps" in it.

> >   ARM: dts: armada-385-linksys: label nodes  
> Fixed typo pointed by Andrew
> 
> >   ARM: dts: armada-385-linksys: flatten dependants  
> Fixed typo pointed by Andrew
> 
> Something that I didn't change is the word "dependants", I don't know
> what do you means exactly. But not being native speaker I maybe missed
> something.

Dependants is the noun, tho that might be a British English thing (what
I had in school). I learned English as 4th/5th language together with
Latin, so beside being a mixture of American and British English some
custom English surfaces from time to time. :)

> 
> >   ARM: dts: armada-385-linksys: drop redundant properties in
> > dependants ARM: dts: armada-385-linksys: bm pools by label order
> >   ARM: dts: armada-385-linksys: usb3 label cleanup  
> 
> I applied this one because I found Ralph explanation convincing about
> not modifying the ABI
> 
> >   ARM: dts: armada-385-linksys: drop leagcy DSA bindings  
> Fixed typo in title and commit log
> 

Didn't notice until you pointed it out. Thanks.

> >   ARM: dts: armada-385-linksys: use binary unit prefixes  
> 
> As Ralph I prefer that we use normalized unit. Especially when we use
> MiB or KiB then we are sure that we use a power of 2, whereas when we
> see KB we don't know if it is 1024B or 1000B.
> 
> >   ARM: dts: armada-385-linksys: partition layout is board specific
> >   ARM: dts: armada-385-linksys: group pins in pinctrl
> >   ARM: dts: armada-385-linksys: fixup button node names  
> 
> >   clk: mvebu: add support for 1866MHz variants  
> 
> I didn't apply this one as it must go through the clk tree and there
> was also a pending question from Andrew.

And the way he formulated it he probably already knows that more is
needed. I'll investigate it.

> 
> >   ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)  
> 
> For this last one do you finally agree to use "non-removable" instead
> of "broken-cd" ?

The card isn't really accessible and as such polling sort of pointless.
I prefer non-removable but left it as-is for V1.

Thanks
Ralph

PS: Also thanks for applying the reminder of the pwm-fan series.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web