Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1646253 > unrolled thread

[PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs

Started byRyder Lee <ryder.lee@mediatek.com>
First post2017-05-21 05:50 +0200
Last post2017-05-25 00:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs Ryder Lee <ryder.lee@mediatek.com> - 2017-05-21 05:50 +0200
    Re: [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs Bjorn Helgaas <helgaas@kernel.org> - 2017-05-25 00:00 +0200

#1646253 — [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs

FromRyder Lee <ryder.lee@mediatek.com>
Date2017-05-21 05:50 +0200
Subject[PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs
Message-ID<tJq2t-2b3-9@gated-at.bofh.it>
Hi,

This patch series add Mediatek Gen2 PCIe host controller driver and
dt-binding document. It can be found on MT7623 series SoCs.

This driver was validated using Broadcom Tigon3 and Intel(R) 82575/82576
gigabit ethernet card.


Changes since v5:
- rebase to Linux 4.12-rc1.
- remove redundant module.h header and MODULE macros.

Changes since v4:
- move the per-port registers to the parent node.
- use a valid compatible for hifsys controller.
- use the 'sysirq' instead of 'gic' as a correct 'interrupt-parent' of the
  interrupt-map properties.

  'sysirq' is an interrupt-controller that could help us to reverse GIC SPIs polarity
  so that we could properly set irq type to level low without any extra properties.
  It was a mistake to select wrong interrupt-parent on the previous versions.
  Now, we could remove unnecessary interrupt properties entirely from binding.

Changes since v3:
- correct sub-nodes unit addresses.

Changes since v2:
- modify Kconfig to avoid kbuild test error on some architecture.
- change compatible string.
- revise binding document:
  add missing interrupt-names.
  remove the board dts example and drop 'status' properties.
  remove unnecessary descriptions bout standard PCI bus binding.

Changes since v1:
- add .suppress_bind_attrs.
- remove unnecessary *_valid_device() pattern.
- remove PCI_PROBE_ONLY.
- use the regular readl() instead of readl_relaxed().
- add .map_bus() and change to use pci_generic_config_read/pci_generic_config_write.
- revise dt-binding document and move nonstandard properties to root node.
- change compatible string.
- use interrupt-map property and replace mtk_pcie_map_irq() with of_irq_parse_and_map_pci().
- use the new pci_register_host_bridge() method instead of pci_scan_root_bus()*

Ryder Lee (2):
  PCI: mediatek: Add Mediatek PCIe host controller support
  dt-bindings: pcie: Add documentation for Mediatek PCIe

 .../bindings/pci/mediatek,mt7623-pcie.txt          | 130 +++++
 drivers/pci/host/Kconfig                           |  11 +
 drivers/pci/host/Makefile                          |   1 +
 drivers/pci/host/pcie-mediatek.c                   | 553 +++++++++++++++++++++
 4 files changed, 695 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/mediatek,mt7623-pcie.txt
 create mode 100644 drivers/pci/host/pcie-mediatek.c

-- 
1.9.1

[toc] | [next] | [standalone]


#1649982

FromBjorn Helgaas <helgaas@kernel.org>
Date2017-05-25 00:00 +0200
Message-ID<tKMtX-7Lj-9@gated-at.bofh.it>
In reply to#1646253
On Sun, May 21, 2017 at 11:42:23AM +0800, Ryder Lee wrote:
> Hi,
> 
> This patch series add Mediatek Gen2 PCIe host controller driver and
> dt-binding document. It can be found on MT7623 series SoCs.
> 
> This driver was validated using Broadcom Tigon3 and Intel(R) 82575/82576
> gigabit ethernet card.
> 
> 
> Changes since v5:
> - rebase to Linux 4.12-rc1.
> - remove redundant module.h header and MODULE macros.
> 
> Changes since v4:
> - move the per-port registers to the parent node.
> - use a valid compatible for hifsys controller.
> - use the 'sysirq' instead of 'gic' as a correct 'interrupt-parent' of the
>   interrupt-map properties.
> 
>   'sysirq' is an interrupt-controller that could help us to reverse GIC SPIs polarity
>   so that we could properly set irq type to level low without any extra properties.
>   It was a mistake to select wrong interrupt-parent on the previous versions.
>   Now, we could remove unnecessary interrupt properties entirely from binding.
> 
> Changes since v3:
> - correct sub-nodes unit addresses.
> 
> Changes since v2:
> - modify Kconfig to avoid kbuild test error on some architecture.
> - change compatible string.
> - revise binding document:
>   add missing interrupt-names.
>   remove the board dts example and drop 'status' properties.
>   remove unnecessary descriptions bout standard PCI bus binding.
> 
> Changes since v1:
> - add .suppress_bind_attrs.
> - remove unnecessary *_valid_device() pattern.
> - remove PCI_PROBE_ONLY.
> - use the regular readl() instead of readl_relaxed().
> - add .map_bus() and change to use pci_generic_config_read/pci_generic_config_write.
> - revise dt-binding document and move nonstandard properties to root node.
> - change compatible string.
> - use interrupt-map property and replace mtk_pcie_map_irq() with of_irq_parse_and_map_pci().
> - use the new pci_register_host_bridge() method instead of pci_scan_root_bus()*
> 
> Ryder Lee (2):
>   PCI: mediatek: Add Mediatek PCIe host controller support
>   dt-bindings: pcie: Add documentation for Mediatek PCIe
> 
>  .../bindings/pci/mediatek,mt7623-pcie.txt          | 130 +++++
>  drivers/pci/host/Kconfig                           |  11 +
>  drivers/pci/host/Makefile                          |   1 +
>  drivers/pci/host/pcie-mediatek.c                   | 553 +++++++++++++++++++++
>  4 files changed, 695 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/mediatek,mt7623-pcie.txt
>  create mode 100644 drivers/pci/host/pcie-mediatek.c

Applied to pci/host-mediatek for v4.13, thanks!

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web