Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646206 > unrolled thread

[PATCH] vlynq: Delete an error message for a failed memory allocation in vlynq_probe()

Back to article view | Back to linux.kernel

Contents

  [PATCH] vlynq: Delete an error message for a failed memory allocation  in vlynq_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 22:10 +0200

#1646206 — [PATCH] vlynq: Delete an error message for a failed memory allocation in vlynq_probe()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 20 May 2017 21:53:55 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/vlynq/vlynq.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index c0227f9418eb..08173463e7eb 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -684,11 +684,8 @@ static int vlynq_probe(struct platform_device *pdev)
 		return -ENODEV;
 
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
-	if (!dev) {
-		printk(KERN_ERR
-		       "vlynq: failed to allocate device structure\n");
+	if (!dev)
 		return -ENOMEM;
-	}
 
 	dev->id = pdev->id;
 	dev->dev.bus = &vlynq_bus_type;
-- 
2.13.0

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web