Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1646741 > unrolled thread

[PATCH v2 2/3] of/platform: Make of_platform_device_destroy globally visible

Started byJan Glauber <jglauber@cavium.com>
First post2017-05-22 13:10 +0200
Last post2017-05-22 15:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v2 2/3] of/platform: Make of_platform_device_destroy globally visible Jan Glauber <jglauber@cavium.com> - 2017-05-22 13:10 +0200
    Re: [PATCH v2 2/3] of/platform: Make of_platform_device_destroy  globally visible Rob Herring <robh+dt@kernel.org> - 2017-05-22 15:40 +0200

#1646741 — [PATCH v2 2/3] of/platform: Make of_platform_device_destroy globally visible

FromJan Glauber <jglauber@cavium.com>
Date2017-05-22 13:10 +0200
Subject[PATCH v2 2/3] of/platform: Make of_platform_device_destroy globally visible
Message-ID<tJTnP-4Xw-15@gated-at.bofh.it>
of_platform_device_destroy is the counterpart to
of_platform_device_create which is a non-static function.

After creating a platform device it might be neccessary
to destroy it to deal with -EPROBE_DEFER where a
repeated of_platform_device_create call would fail otherwise.

Therefore also make of_platform_device_destroy globally visible.

Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
 drivers/of/platform.c       | 3 ++-
 include/linux/of_platform.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 71fecc2..703a421 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -523,7 +523,7 @@ static int __init of_platform_default_populate_init(void)
 arch_initcall_sync(of_platform_default_populate_init);
 #endif
 
-static int of_platform_device_destroy(struct device *dev, void *data)
+int of_platform_device_destroy(struct device *dev, void *data)
 {
 	/* Do not touch devices not populated from the device tree */
 	if (!dev->of_node || !of_node_check_flag(dev->of_node, OF_POPULATED))
@@ -544,6 +544,7 @@ static int of_platform_device_destroy(struct device *dev, void *data)
 	of_node_clear_flag(dev->of_node, OF_POPULATED_BUS);
 	return 0;
 }
+EXPORT_SYMBOL_GPL(of_platform_device_destroy);
 
 /**
  * of_platform_depopulate() - Remove devices populated from device tree
diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h
index dc8224a..e0d1946 100644
--- a/include/linux/of_platform.h
+++ b/include/linux/of_platform.h
@@ -64,6 +64,7 @@ extern struct platform_device *of_platform_device_create(struct device_node *np,
 						   const char *bus_id,
 						   struct device *parent);
 
+extern int of_platform_device_destroy(struct device *dev, void *data);
 extern int of_platform_bus_probe(struct device_node *root,
 				 const struct of_device_id *matches,
 				 struct device *parent);
-- 
2.9.0.rc0.21.g7777322

[toc] | [next] | [standalone]


#1646898 — Re: [PATCH v2 2/3] of/platform: Make of_platform_device_destroy globally visible

FromRob Herring <robh+dt@kernel.org>
Date2017-05-22 15:40 +0200
SubjectRe: [PATCH v2 2/3] of/platform: Make of_platform_device_destroy globally visible
Message-ID<tJVIZ-6iD-9@gated-at.bofh.it>
In reply to#1646741
On Mon, May 22, 2017 at 6:09 AM, Jan Glauber <jglauber@cavium.com> wrote:
> of_platform_device_destroy is the counterpart to
> of_platform_device_create which is a non-static function.
>
> After creating a platform device it might be neccessary
> to destroy it to deal with -EPROBE_DEFER where a
> repeated of_platform_device_create call would fail otherwise.
>
> Therefore also make of_platform_device_destroy globally visible.
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
> ---
>  drivers/of/platform.c       | 3 ++-
>  include/linux/of_platform.h | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web