Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646684 > unrolled thread

Re: Build regressions/improvements in v4.12-rc2

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: Build regressions/improvements in v4.12-rc2 Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-22 12:00 +0200
    Re: Build regressions/improvements in v4.12-rc2 Arnd Bergmann <arnd@arndb.de> - 2017-05-22 16:20 +0200
      Re: Build regressions/improvements in v4.12-rc2 Helge Deller <deller@gmx.de> - 2017-05-22 18:00 +0200
    Re: Build regressions/improvements in v4.12-rc2 John David Anglin <dave.anglin@bell.net> - 2017-05-22 21:10 +0200
      Re: Build regressions/improvements in v4.12-rc2 Arnd Bergmann <arnd@arndb.de> - 2017-05-22 23:10 +0200

#1646684 — Re: Build regressions/improvements in v4.12-rc2

Hi Arnd, Helge,

On Mon, May 22, 2017 at 11:35 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.12-rc2[1] compared to v4.11[2].
>
> Summarized:
>   - build errors: +2/-3
>   - build warnings: +27717/-896

> [1] http://kisskb.ellerman.id.au/kisskb/head/08332893e37af6ae779367e78e444f8f9571511d/ (267 out of 270 configs)

> 27717 warning regressions:
>
> [Deleted 26393 lines about "warning: ... [-Wpointer-sign]" on parisc-allmodconfig]

Do you know where these are coming from? They appeared in v4.12-rc1.
The toolchain on kisskb hasn't changed (still gcc-4.6.3-nolibc).

> [Deleted 1166 lines about "warning: -ffunction-sections disabled; it makes profiling impossible [enabled by default]" on parisc-allmodconfig]

This has been introduced a while ago.  Would be good to get it fixed, too.
I guess the "cflags-y += -ffunction-sections" still needs some CONFIG check,
despite commit 366dd4ea9d5f0eb7 ("parisc: Fix ftrace function tracer")?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [next] | [standalone]

#1646970

On Mon, May 22, 2017 at 11:49 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Arnd, Helge,
>
> On Mon, May 22, 2017 at 11:35 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> Below is the list of build error/warning regressions/improvements in
>> v4.12-rc2[1] compared to v4.11[2].
>>
>> Summarized:
>>   - build errors: +2/-3
>>   - build warnings: +27717/-896
>
>> [1] http://kisskb.ellerman.id.au/kisskb/head/08332893e37af6ae779367e78e444f8f9571511d/ (267 out of 270 configs)
>
>> 27717 warning regressions:
>>
>> [Deleted 26393 lines about "warning: ... [-Wpointer-sign]" on parisc-allmodconfig]
>
> Do you know where these are coming from? They appeared in v4.12-rc1.
> The toolchain on kisskb hasn't changed (still gcc-4.6.3-nolibc).
>
>> [Deleted 1166 lines about "warning: -ffunction-sections disabled; it makes profiling impossible [enabled by default]" on parisc-allmodconfig]
>
> This has been introduced a while ago.  Would be good to get it fixed, too.
> I guess the "cflags-y += -ffunction-sections" still needs some CONFIG check,
> despite commit 366dd4ea9d5f0eb7 ("parisc: Fix ftrace function tracer")?

I found this mailing list discussion:

https://gcc.gnu.org/ml/gcc-help/2008-11/msg00141.html
https://gcc.gnu.org/ml/gcc-help/2008-11/msg00139.html

This patch was merged into gcc-4.8:

https://patchwork.ozlabs.org/patch/197134/

As the -ffunction-sections is a workaround for another problem, we could
use make it conditional on having a more recent compiler here.

        Arnd

[toc] | [prev] | [next] | [standalone]

#1647070

On 22.05.2017 16:19, Arnd Bergmann wrote:
> On Mon, May 22, 2017 at 11:49 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> Hi Arnd, Helge,
>>
>> On Mon, May 22, 2017 at 11:35 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>>> Below is the list of build error/warning regressions/improvements in
>>> v4.12-rc2[1] compared to v4.11[2].
>>>
>>> Summarized:
>>>   - build errors: +2/-3
>>>   - build warnings: +27717/-896
>>
>>> [1] http://kisskb.ellerman.id.au/kisskb/head/08332893e37af6ae779367e78e444f8f9571511d/ (267 out of 270 configs)
>>
>>> 27717 warning regressions:
>>>
>>> [Deleted 26393 lines about "warning: ... [-Wpointer-sign]" on parisc-allmodconfig]
>>
>> Do you know where these are coming from? They appeared in v4.12-rc1.

No idea.

>> The toolchain on kisskb hasn't changed (still gcc-4.6.3-nolibc).

Ok.

>>> [Deleted 1166 lines about "warning: -ffunction-sections disabled; it makes profiling impossible [enabled by default]" on parisc-allmodconfig]
>>
>> This has been introduced a while ago.  Would be good to get it fixed, too.
>> I guess the "cflags-y += -ffunction-sections" still needs some CONFIG check,
>> despite commit 366dd4ea9d5f0eb7 ("parisc: Fix ftrace function tracer")?
> 
> I found this mailing list discussion:
> 
> https://gcc.gnu.org/ml/gcc-help/2008-11/msg00141.html
> https://gcc.gnu.org/ml/gcc-help/2008-11/msg00139.html
> 
> This patch was merged into gcc-4.8:
> 
> https://patchwork.ozlabs.org/patch/197134/
> 
> As the -ffunction-sections is a workaround for another problem, we could
> use make it conditional on having a more recent compiler here.

Yes, please update the compiler. I suggested that last time already.
I'm using gcc-6.1.1-cross from Fedora:
hppa-linux-gnu-gcc (GCC) 6.1.1 20160621 (Red Hat Cross 6.1.1-2)
downloaded the given parisc-allmodconfig and it does not show any of those warnings.  

Helge

[toc] | [prev] | [next] | [standalone]

#1647277

On 2017-05-22, at 5:49 AM, Geert Uytterhoeven wrote:

>> [Deleted 1166 lines about "warning: -ffunction-sections disabled; it makes profiling impossible [enabled by default]" on parisc-allmodconfig]

Although this issue may be fixed in gcc, do we really want to enable profiling by default?

Dave
--
John David Anglin	dave.anglin@bell.net

[toc] | [prev] | [next] | [standalone]

#1647390

On Mon, May 22, 2017 at 8:46 PM, John David Anglin <dave.anglin@bell.net> wrote:
> On 2017-05-22, at 5:49 AM, Geert Uytterhoeven wrote:
>
>>> [Deleted 1166 lines about "warning: -ffunction-sections disabled; it makes profiling impossible [enabled by default]" on parisc-allmodconfig]
>
> Although this issue may be fixed in gcc, do we really want to enable profiling by default?

This is ftrace, which uses the same compiler flag as gprof, and the option
is only enabled in allmodconfig, which seems reasonable.

       Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web