Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1646513 > unrolled thread
| Started by | Gang He <ghe@suse.com> |
|---|---|
| First post | 2017-05-22 07:00 +0200 |
| Last post | 2017-05-22 23:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ocfs2: fix a static checker warning Gang He <ghe@suse.com> - 2017-05-22 07:00 +0200
Re: [Ocfs2-devel] [PATCH] ocfs2: fix a static checker warning Joseph Qi <jiangqi903@gmail.com> - 2017-05-22 11:20 +0200
Re: [PATCH] ocfs2: fix a static checker warning Andrew Morton <akpm@linux-foundation.org> - 2017-05-22 23:30 +0200
| From | Gang He <ghe@suse.com> |
|---|---|
| Date | 2017-05-22 07:00 +0200 |
| Subject | [PATCH] ocfs2: fix a static checker warning |
| Message-ID | <tJNBM-Rs-23@gated-at.bofh.it> |
This patch will fix a static checker warning, this warning was
caused by commit d56a8f32e4c662509ce50a37e78fa66c777977d3. after
apply this patch, the error return value will not be NULL(zero).
Signed-off-by: Gang He <ghe@suse.com>
---
fs/ocfs2/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 382401d..1a1e007 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -136,7 +136,7 @@ struct inode *ocfs2_ilookup(struct super_block *sb, u64 blkno)
struct inode *ocfs2_iget(struct ocfs2_super *osb, u64 blkno, unsigned flags,
int sysfile_type)
{
- int rc = 0;
+ int rc = -ESTALE;
struct inode *inode = NULL;
struct super_block *sb = osb->sb;
struct ocfs2_find_inode_args args;
--
1.8.5.6
[toc] | [next] | [standalone]
| From | Joseph Qi <jiangqi903@gmail.com> |
|---|---|
| Date | 2017-05-22 11:20 +0200 |
| Subject | Re: [Ocfs2-devel] [PATCH] ocfs2: fix a static checker warning |
| Message-ID | <tJRFp-3IZ-45@gated-at.bofh.it> |
| In reply to | #1646513 |
On 17/5/22 12:54, Gang He wrote:
> This patch will fix a static checker warning, this warning was
> caused by commit d56a8f32e4c662509ce50a37e78fa66c777977d3. after
> apply this patch, the error return value will not be NULL(zero).
>
> Signed-off-by: Gang He <ghe@suse.com>
Reviewed-by: Joseph Qi <jiangqi903@gmail.com>
Thanks,
Joseph
> ---
> fs/ocfs2/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
> index 382401d..1a1e007 100644
> --- a/fs/ocfs2/inode.c
> +++ b/fs/ocfs2/inode.c
> @@ -136,7 +136,7 @@ struct inode *ocfs2_ilookup(struct super_block *sb, u64 blkno)
> struct inode *ocfs2_iget(struct ocfs2_super *osb, u64 blkno, unsigned flags,
> int sysfile_type)
> {
> - int rc = 0;
> + int rc = -ESTALE;
> struct inode *inode = NULL;
> struct super_block *sb = osb->sb;
> struct ocfs2_find_inode_args args;
>
[toc] | [prev] | [next] | [standalone]
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Date | 2017-05-22 23:30 +0200 |
| Message-ID | <tK33Q-2tD-7@gated-at.bofh.it> |
| In reply to | #1646513 |
On Mon, 22 May 2017 12:54:37 +0800 Gang He <ghe@suse.com> wrote:
> This patch will fix a static checker warning, this warning was
> caused by commit d56a8f32e4c662509ce50a37e78fa66c777977d3. after
> apply this patch, the error return value will not be NULL(zero).
When identifying another commit, please use the form
d56a8f32e4c6 ("ocfs2: check/fix inode block for online file check")
And when fixing warnings such as this, please quote the warning in full
and identify which checker tool generated that warning.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web