Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1646414 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-05-21 22:20 +0200 |
| Last post | 2017-05-23 06:40 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/5] atm: Adjustments for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-21 22:20 +0200
[PATCH 1/5] atm: Improve a size determination in four functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-21 22:20 +0200
[PATCH 2/5] atm: Delete an error message for a failed memory allocation in make_entry() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-21 22:20 +0200
Re: [PATCH 0/5] atm: Adjustments for some function implementations Kees Cook <keescook@chromium.org> - 2017-05-23 06:40 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-21 22:20 +0200 |
| Subject | [PATCH 0/5] atm: Adjustments for some function implementations |
| Message-ID | <tJFux-42X-3@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 21 May 2017 22:09:11 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Improve a size determination in four functions Delete an error message for a failed memory allocation in make_entry() Adjust 19 checks for null pointers Use seq_puts() in lec_info() Use seq_putc() in lec_info() net/atm/lec.c | 55 +++++++++++++++++++++++++++---------------------------- 1 file changed, 27 insertions(+), 28 deletions(-) -- 2.13.0
[toc] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-21 22:20 +0200 |
| Subject | [PATCH 1/5] atm: Improve a size determination in four functions |
| Message-ID | <tJFux-42X-11@gated-at.bofh.it> |
| In reply to | #1646414 |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 21 May 2017 21:20:44 +0200
Replace the specification of four data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
net/atm/lec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/atm/lec.c b/net/atm/lec.c
index 09cfe87f0a44..6ad3ca625a44 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -518,5 +518,5 @@ send_to_lecd(struct lec_priv *priv, atmlec_msg_type type,
return -1;
skb->len = sizeof(struct atmlec_msg);
mesg = (struct atmlec_msg *)skb->data;
- memset(mesg, 0, sizeof(struct atmlec_msg));
+ memset(mesg, 0, sizeof(*mesg));
mesg->type = type;
@@ -690,5 +690,5 @@ static int lec_vcc_attach(struct atm_vcc *vcc, void __user *arg)
if (ioc_data.dev_num < 0 || ioc_data.dev_num >= MAX_LEC_ITF ||
!dev_lec[ioc_data.dev_num])
return -EINVAL;
- vpriv = kmalloc(sizeof(struct lec_vcc_priv), GFP_KERNEL);
+ vpriv = kmalloc(sizeof(*vpriv), GFP_KERNEL);
if (!vpriv)
@@ -1552,5 +1552,5 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
{
struct lec_arp_table *to_return;
- to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
+ to_return = kzalloc(sizeof(*to_return), GFP_ATOMIC);
if (!to_return) {
@@ -2156,5 +2156,5 @@ static int lec_mcast_make(struct lec_priv *priv, struct atm_vcc *vcc)
struct lec_vcc_priv *vpriv;
int err = 0;
- vpriv = kmalloc(sizeof(struct lec_vcc_priv), GFP_KERNEL);
+ vpriv = kmalloc(sizeof(*vpriv), GFP_KERNEL);
if (!vpriv)
--
2.13.0
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-21 22:20 +0200 |
| Subject | [PATCH 2/5] atm: Delete an error message for a failed memory allocation in make_entry() |
| Message-ID | <tJFuy-42X-15@gated-at.bofh.it> |
| In reply to | #1646414 |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 21 May 2017 21:24:45 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
net/atm/lec.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/atm/lec.c b/net/atm/lec.c
index 6ad3ca625a44..a11dbd3a5119 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -1556,7 +1556,6 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
- if (!to_return) {
- pr_info("LEC: Arp entry kmalloc failed\n");
+ if (!to_return)
return NULL;
- }
+
ether_addr_copy(to_return->mac_addr, mac_addr);
INIT_HLIST_NODE(&to_return->next);
setup_timer(&to_return->timer, lec_arp_expire_arp,
--
2.13.0
[toc] | [prev] | [next] | [standalone]
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2017-05-23 06:40 +0200 |
| Message-ID | <tK9LY-6FW-5@gated-at.bofh.it> |
| In reply to | #1646414 |
On Sun, May 21, 2017 at 1:12 PM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 21 May 2017 22:09:11 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): > Improve a size determination in four functions > Delete an error message for a failed memory allocation in make_entry() > Adjust 19 checks for null pointers > Use seq_puts() in lec_info() > Use seq_putc() in lec_info() > > net/atm/lec.c | 55 +++++++++++++++++++++++++++---------------------------- > 1 file changed, 27 insertions(+), 28 deletions(-) These all look fine to me. Thanks! Reviewed-by: Kees Cook <keescook@chromium.org> -Kees -- Kees Cook Pixel Security
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web