Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646429 > unrolled thread

[PATCH 0/1] hid: move include files out of include/linux/i2c

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/1] hid: move include files out of include/linux/i2c Wolfram Sang <wsa@the-dreams.de> - 2017-05-21 22:40 +0200
    [PATCH 1/1] hid: i2c-hid: move header file out of I2C realm Wolfram Sang <wsa@the-dreams.de> - 2017-05-21 22:40 +0200
      Re: [PATCH 1/1] hid: i2c-hid: move header file out of I2C realm Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-22 10:00 +0200
      Re: [PATCH 1/1] hid: i2c-hid: move header file out of I2C realm Jiri Kosina <jikos@kernel.org> - 2017-05-22 14:10 +0200

#1646429 — [PATCH 0/1] hid: move include files out of include/linux/i2c

It doesn't make sense to use include/linux/i2c for client drivers which may in
fact rather be hwmon or input or whatever devices. As a result, I want to
deprecate include/linux/i2c for good. This series moves the include files to a
better location, largely include/platform_data because that is what most of the
moved include files contain. Note that some files don't seem to have upstream
users in board code, so they maybe could even be removed? I didn't check for
that now, but I did it for one i2c master driver recently. So, it may be
possible.

I prefer the series to go upstream via the subsystem tree; if you prefer that I
take it via I2C, just let me know.

No runtime testing because of no HW, but buildbot is happy with this series at
least. A branch can be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data

Thanks and kind regards,

   Wolfram


Wolfram Sang (1):
  hid: i2c-hid: move header file out of I2C realm

 drivers/hid/i2c-hid/i2c-hid.c                  | 2 +-
 include/linux/{i2c => platform_data}/i2c-hid.h | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename include/linux/{i2c => platform_data}/i2c-hid.h (100%)

-- 
2.11.0

[toc] | [next] | [standalone]

#1646432 — [PATCH 1/1] hid: i2c-hid: move header file out of I2C realm

include/linux/i2c is not for client devices. Move the header file to a
more appropriate location.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
 drivers/hid/i2c-hid/i2c-hid.c                  | 2 +-
 include/linux/{i2c => platform_data}/i2c-hid.h | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename include/linux/{i2c => platform_data}/i2c-hid.h (100%)

diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index 8daa8ce64ebba5..841aa43526eba4 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -40,7 +40,7 @@
 #include <linux/of.h>
 #include <linux/regulator/consumer.h>
 
-#include <linux/i2c/i2c-hid.h>
+#include <linux/platform_data/i2c-hid.h>
 
 #include "../hid-ids.h"
 
diff --git a/include/linux/i2c/i2c-hid.h b/include/linux/platform_data/i2c-hid.h
similarity index 100%
rename from include/linux/i2c/i2c-hid.h
rename to include/linux/platform_data/i2c-hid.h
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1646583 — Re: [PATCH 1/1] hid: i2c-hid: move header file out of I2C realm

On May 21 2017 or thereabouts, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---

Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

>  drivers/hid/i2c-hid/i2c-hid.c                  | 2 +-
>  include/linux/{i2c => platform_data}/i2c-hid.h | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename include/linux/{i2c => platform_data}/i2c-hid.h (100%)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 8daa8ce64ebba5..841aa43526eba4 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -40,7 +40,7 @@
>  #include <linux/of.h>
>  #include <linux/regulator/consumer.h>
>  
> -#include <linux/i2c/i2c-hid.h>
> +#include <linux/platform_data/i2c-hid.h>
>  
>  #include "../hid-ids.h"
>  
> diff --git a/include/linux/i2c/i2c-hid.h b/include/linux/platform_data/i2c-hid.h
> similarity index 100%
> rename from include/linux/i2c/i2c-hid.h
> rename to include/linux/platform_data/i2c-hid.h
> -- 
> 2.11.0
> 

[toc] | [prev] | [next] | [standalone]

#1646803 — Re: [PATCH 1/1] hid: i2c-hid: move header file out of I2C realm

On Sun, 21 May 2017, Wolfram Sang wrote:

> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

Applied to for-4.13/upstream. Thanks,

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web