Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646423 > unrolled thread

[PATCH 0/6] UBIFS NFS export support v2

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/6] UBIFS NFS export support v2 Richard Weinberger <richard@nod.at> - 2017-05-21 22:30 +0200
    [PATCH 1/6] ext4: Move is_32bit_api() to generic code Richard Weinberger <richard@nod.at> - 2017-05-21 22:30 +0200
      Re: [PATCH 1/6] ext4: Move is_32bit_api() to generic code Christoph Hellwig <hch@infradead.org> - 2017-05-23 10:40 +0200

#1646423 — [PATCH 0/6] UBIFS NFS export support v2

Adding fscrypto support to UBIFS forced us to implement 64bit
cookies. Using this building block we can finally implement
export operations and allow UBIFS being exported via NFS.
This series adds the last missing bits.

It can be obtained from:
git://git.infradead.org/users/rw/linux.git ubifs_export_v2

Changes since v1, https://lkml.org/lkml/2016/12/1/711
 - Addressed comments from Marcus Folkesson, Hyunchul Lee and J. Bruce Fields
 - Added Acks/Reviewed-bys from J. Bruce Fields and Andreas Dilger

Richard Weinberger (6):
  ext4: Move is_32bit_api() to generic code
  ubifs: Provide a custom llseek for directories
  ubifs: Use 64bit readdir cookies
  ubifs: Maintain a parent pointer
  ubifs: Implement export_operations
  ubifs: Wire up NFS support

 fs/ext4/dir.c          |  9 -----
 fs/ubifs/dir.c         | 89 +++++++++++++++++++++++++++++++++++++-------------
 fs/ubifs/journal.c     |  5 ++-
 fs/ubifs/key.h         | 61 ++++++++++++++++++++++++++++++++++
 fs/ubifs/sb.c          |  2 ++
 fs/ubifs/super.c       | 39 ++++++++++++++++++++++
 fs/ubifs/ubifs-media.h | 18 ++++++++--
 fs/ubifs/ubifs.h       |  6 ++++
 include/linux/compat.h |  2 ++
 9 files changed, 195 insertions(+), 36 deletions(-)

-- 
2.12.0

[toc] | [next] | [standalone]

#1646424 — [PATCH 1/6] ext4: Move is_32bit_api() to generic code

Since UBIFS will also use this function, move it to compat.h.

Signed-off-by: Richard Weinberger <richard@nod.at>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
---
 fs/ext4/dir.c          | 9 ---------
 include/linux/compat.h | 2 ++
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
index e8b365000d73..464e6e99d744 100644
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
@@ -290,15 +290,6 @@ static int ext4_readdir(struct file *file, struct dir_context *ctx)
 	return err;
 }
 
-static inline int is_32bit_api(void)
-{
-#ifdef CONFIG_COMPAT
-	return in_compat_syscall();
-#else
-	return (BITS_PER_LONG == 32);
-#endif
-}
-
 /*
  * These functions convert from the major/minor hash to an f_pos
  * value for dx directories
diff --git a/include/linux/compat.h b/include/linux/compat.h
index 1c5f3152cbb5..f33ffd8040a1 100644
--- a/include/linux/compat.h
+++ b/include/linux/compat.h
@@ -736,6 +736,7 @@ asmlinkage long compat_sys_arch_prctl(int option, unsigned long arg2);
 #ifndef in_compat_syscall
 static inline bool in_compat_syscall(void) { return is_compat_task(); }
 #endif
+static inline int is_32bit_api(void) { return in_compat_syscall(); }
 
 /**
  * ns_to_compat_timeval - Compat version of ns_to_timeval
@@ -759,6 +760,7 @@ static inline struct compat_timeval ns_to_compat_timeval(s64 nsec)
 
 #define is_compat_task() (0)
 static inline bool in_compat_syscall(void) { return false; }
+static inline int is_32bit_api(void) { return BITS_PER_LONG == 32; }
 
 #endif /* CONFIG_COMPAT */
 
-- 
2.12.0

[toc] | [prev] | [next] | [standalone]

#1647802 — Re: [PATCH 1/6] ext4: Move is_32bit_api() to generic code

On Sun, May 21, 2017 at 10:20:46PM +0200, Richard Weinberger wrote:
> Since UBIFS will also use this function, move it to compat.h.

The name is very generic for a common header.  Please give it a
better name.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web