Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1643153 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-05-17 11:00 +0200 |
| Last post | 2017-05-18 16:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] udp: make function udp_skb_dtor_locked static Colin King <colin.king@canonical.com> - 2017-05-17 11:00 +0200
Re: [PATCH] udp: make function udp_skb_dtor_locked static Paolo Abeni <pabeni@redhat.com> - 2017-05-17 11:20 +0200
Re: [PATCH] udp: make function udp_skb_dtor_locked static David Miller <davem@davemloft.net> - 2017-05-18 16:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-05-17 11:00 +0200 |
| Subject | [PATCH] udp: make function udp_skb_dtor_locked static |
| Message-ID | <tI2Yh-Rs-5@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Function udp_skb_dtor_locked does not need to be in global scope
so make it static to fix sparse warning:
net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not
declared. Should it be static?
Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/ipv4/udp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 7bd56c9889b3..922a62d45714 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1218,7 +1218,7 @@ void udp_skb_destructor(struct sock *sk, struct sk_buff *skb)
EXPORT_SYMBOL(udp_skb_destructor);
/* as above, but the caller held the rx queue lock, too */
-void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
+static void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
{
udp_rmem_release(sk, skb->dev_scratch, 1, true);
}
--
2.11.0
[toc] | [next] | [standalone]
| From | Paolo Abeni <pabeni@redhat.com> |
|---|---|
| Date | 2017-05-17 11:20 +0200 |
| Message-ID | <tI3hD-1cV-1@gated-at.bofh.it> |
| In reply to | #1643153 |
On Wed, 2017-05-17 at 09:50 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Function udp_skb_dtor_locked does not need to be in global scope
> so make it static to fix sparse warning:
>
> net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not
> declared. Should it be static?
>
> Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/ipv4/udp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index 7bd56c9889b3..922a62d45714 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -1218,7 +1218,7 @@ void udp_skb_destructor(struct sock *sk, struct sk_buff *skb)
> EXPORT_SYMBOL(udp_skb_destructor);
>
> /* as above, but the caller held the rx queue lock, too */
> -void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
> +static void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
> {
> udp_rmem_release(sk, skb->dev_scratch, 1, true);
> }
Acked-by: Paolo Abeni <pabeni@redhat.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-05-18 16:20 +0200 |
| Message-ID | <tIurv-3RH-1@gated-at.bofh.it> |
| In reply to | #1643153 |
From: Colin King <colin.king@canonical.com>
Date: Wed, 17 May 2017 09:50:36 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Function udp_skb_dtor_locked does not need to be in global scope
> so make it static to fix sparse warning:
>
> net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not
> declared. Should it be static?
>
> Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Please explcitily say "[PATCH net-next]" in your Subject line next time
so that it is clear what tree your patch is targetting.
Thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web