Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1644005 > unrolled thread

[PATCH] liquidio: make the spinlock octeon_devices_lock static

Back to article view | Back to linux.kernel

Contents

  [PATCH] liquidio: make the spinlock octeon_devices_lock static Colin King <colin.king@canonical.com> - 2017-05-18 11:20 +0200
    Re: [PATCH] liquidio: make the spinlock octeon_devices_lock static David Miller <davem@davemloft.net> - 2017-05-18 17:30 +0200

#1644005 — [PATCH] liquidio: make the spinlock octeon_devices_lock static

From: Colin Ian King <colin.king@canonical.com>

octeon_devices_lock can be made static as it does not need to be
in global scope.

Cleans up sparse warning: "warning: symbol 'octeon_devices_lock'
was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/cavium/liquidio/octeon_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
index 3cc56675359a..b5be7074f3de 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
@@ -547,7 +547,7 @@ static atomic_t adapter_refcounts[MAX_OCTEON_DEVICES];
 
 static u32 octeon_device_count;
 /* locks device array (i.e. octeon_device[]) */
-spinlock_t octeon_devices_lock;
+static spinlock_t octeon_devices_lock;
 
 static struct octeon_core_setup core_setup[MAX_OCTEON_DEVICES];
 
-- 
2.11.0

[toc] | [next] | [standalone]

#1644688

From: Colin King <colin.king@canonical.com>
Date: Thu, 18 May 2017 10:14:01 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> octeon_devices_lock can be made static as it does not need to be
> in global scope.
> 
> Cleans up sparse warning: "warning: symbol 'octeon_devices_lock'
> was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web