Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1643639 > unrolled thread

[PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM

Started byArnd Bergmann <arnd@arndb.de>
First post2017-05-17 23:30 +0200
Last post2017-05-18 09:00 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM Arnd Bergmann <arnd@arndb.de> - 2017-05-17 23:30 +0200
    Re: [PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM Chen-Yu Tsai <wens@csie.org> - 2017-05-18 04:30 +0200
      Re: [PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-18 09:00 +0200

#1643639 — [PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM

FromArnd Bergmann <arnd@arndb.de>
Date2017-05-17 23:30 +0200
Subject[PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM
Message-ID<tIeG5-8t7-1@gated-at.bofh.it>
The newly added PRCM CCU driver uses SUNXI_CCU_MP_WITH_MUX_GATE, which causes
a link error when no other driver enables SUNXI_CCU_MP:

drivers/clk/built-in.o:(.data+0x5c8c8): undefined reference to `ccu_mp_ops'

This adds an explicit 'select' statement for it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/sunxi-ng/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index b0d551a8efe4..eb89c7801f00 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -156,6 +156,7 @@ config SUN8I_R_CCU
 	bool "Support for Allwinner SoCs' PRCM CCUs"
 	select SUNXI_CCU_DIV
 	select SUNXI_CCU_GATE
+	select SUNXI_CCU_MP
 	default MACH_SUN8I || (ARCH_SUNXI && ARM64)
 
 endif
-- 
2.9.0

[toc] | [next] | [standalone]


#1643747

FromChen-Yu Tsai <wens@csie.org>
Date2017-05-18 04:30 +0200
Message-ID<tIjmp-3i3-1@gated-at.bofh.it>
In reply to#1643639
On Thu, May 18, 2017 at 5:19 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added PRCM CCU driver uses SUNXI_CCU_MP_WITH_MUX_GATE, which causes
> a link error when no other driver enables SUNXI_CCU_MP:
>
> drivers/clk/built-in.o:(.data+0x5c8c8): undefined reference to `ccu_mp_ops'
>
> This adds an explicit 'select' statement for it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Chen-Yu Tsai <wens@csie.org>

[toc] | [prev] | [next] | [standalone]


#1643881

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-05-18 09:00 +0200
Message-ID<tInzI-6pb-17@gated-at.bofh.it>
In reply to#1643747

[Multipart message — attachments visible in raw view] — view raw

On Thu, May 18, 2017 at 10:25:23AM +0800, Chen-Yu Tsai wrote:
> On Thu, May 18, 2017 at 5:19 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The newly added PRCM CCU driver uses SUNXI_CCU_MP_WITH_MUX_GATE, which causes
> > a link error when no other driver enables SUNXI_CCU_MP:
> >
> > drivers/clk/built-in.o:(.data+0x5c8c8): undefined reference to `ccu_mp_ops'
> >
> > This adds an explicit 'select' statement for it.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web