Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643659 > unrolled thread

[PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check on req

Back to article view | Back to linux.kernel

Contents

  [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check on req Colin King <colin.king@canonical.com> - 2017-05-18 00:00 +0200
    Re: [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check  on req Vinod Koul <vinod.koul@intel.com> - 2017-05-19 05:30 +0200

#1643659 — [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check on req

From: Colin Ian King <colin.king@canonical.com>

Req is never null on at the point of the null check, so
remove this redundant check and just return &req->tx.

Detected by CoverityScan, CID#1436147 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/dma/bcm-sba-raid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
index 7daa883eeded..8246c26eabe5 100644
--- a/drivers/dma/bcm-sba-raid.c
+++ b/drivers/dma/bcm-sba-raid.c
@@ -582,7 +582,7 @@ sba_prep_dma_interrupt(struct dma_chan *dchan, unsigned long flags)
 	req->tx.flags = flags;
 	req->tx.cookie = -EBUSY;
 
-	return (req) ? &req->tx : NULL;
+	return &req->tx;
 }
 
 static void sba_fillup_memcpy_msg(struct sba_request *req,
-- 
2.11.0

[toc] | [next] | [standalone]

#1645163 — Re: [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check on req

On Wed, May 17, 2017 at 10:58:50PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Req is never null on at the point of the null check, so
> remove this redundant check and just return &req->tx.
> 
> Detected by CoverityScan, CID#1436147 ("Logically dead code")


Applied, thanks

-- 
~Vinod

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web