Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1643634 > unrolled thread

[PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins

Started byThomas Meyer <thomas@m3y3r.de>
First post2017-05-17 23:20 +0200
Last post2017-05-21 23:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins Thomas Meyer <thomas@m3y3r.de> - 2017-05-17 23:20 +0200
    Re: [uml-devel] [PATCH] um: Don't build arch/x86/um/user-offsets.s  with gcc plugins Richard Weinberger <richard.weinberger@gmail.com> - 2017-05-21 23:40 +0200

#1643634 — [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins

FromThomas Meyer <thomas@m3y3r.de>
Date2017-05-17 23:20 +0200
Subject[PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins
Message-ID<tIewp-8p4-3@gated-at.bofh.it>
For some reasons I don't know users-offsets.s get's build before the
gcc-plugins itself.
This patch fixes the problem by not using the gcc-plugins for building
user-offsets.s

make order example:
$ make ARCH=um
  CHK     include/generated/uapi/linux/version.h
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/basic/bin2c
  HOSTCC  scripts/unifdef
  CC      arch/x86/um/user-offsets.s
  CHK     include/generated/user_constants.h
  CHK     include/config/kernel.release
  CHK     include/generated/utsrelease.h
  HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o
  HOSTLLD -shared scripts/gcc-plugins/latent_entropy_plugin.so
  HOSTCXX -fPIC scripts/gcc-plugins/structleak_plugin.o
  HOSTLLD -shared scripts/gcc-plugins/structleak_plugin.so

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
 arch/x86/um/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/um/Makefile b/arch/x86/um/Makefile
index 46cbbfe..d67c78a 100644
--- a/arch/x86/um/Makefile
+++ b/arch/x86/um/Makefile
@@ -36,7 +36,7 @@ subarch-$(CONFIG_MODULES) += ../kernel/module.o
 USER_OBJS := bugs_$(BITS).o ptrace_user.o fault.o
 
 extra-y += user-offsets.s
-$(obj)/user-offsets.s: c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) \
+$(obj)/user-offsets.s: c_flags = -Wp,-MD,$(depfile) $(filter-out $(GCC_PLUGINS_CFLAGS), $(USER_CFLAGS) ) \
 	-Iarch/x86/include/generated
 
 UNPROFILE_OBJS := stub_segv.o

[toc] | [next] | [standalone]


#1646449 — Re: [uml-devel] [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins

FromRichard Weinberger <richard.weinberger@gmail.com>
Date2017-05-21 23:40 +0200
SubjectRe: [uml-devel] [PATCH] um: Don't build arch/x86/um/user-offsets.s with gcc plugins
Message-ID<tJGJX-4JY-3@gated-at.bofh.it>
In reply to#1643634
Thomas,

On Wed, May 17, 2017 at 10:41 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> For some reasons I don't know users-offsets.s get's build before the
> gcc-plugins itself.

Can you please figure? I want to make sure that we really fix the root cause
and not just papering over a symptom.

-- 
Thanks,
//richard

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web