Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1642054 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-05-15 22:50 +0200 |
| Last post | 2017-05-17 23:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] char: ipmi: remove unnecessary code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-15 22:50 +0200
Re: [PATCH] char: ipmi: remove unnecessary code Corey Minyard <minyard@acm.org> - 2017-05-17 15:20 +0200
Re: [PATCH] char: ipmi: remove unnecessary code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-17 23:00 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-05-15 22:50 +0200 |
| Subject | [PATCH] char: ipmi: remove unnecessary code |
| Message-ID | <tHv6i-4wd-27@gated-at.bofh.it> |
The array field name in struct i2c_adapter is a fixed size array
so it can never be NULL.
Addresses-Coverity-ID: 1397986
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/char/ipmi/ipmi_ssif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index cca6e5b..df4fea7 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1415,7 +1415,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
list_for_each_entry(info, &ssif_infos, link) {
if (info->binfo.addr != client->addr)
continue;
- if (info->adapter_name && client->adapter->name &&
+ if (info->adapter_name &&
strcmp_nospace(info->adapter_name,
client->adapter->name))
continue;
--
2.5.0
[toc] | [next] | [standalone]
| From | Corey Minyard <minyard@acm.org> |
|---|---|
| Date | 2017-05-17 15:20 +0200 |
| Message-ID | <tI71T-3xU-5@gated-at.bofh.it> |
| In reply to | #1642054 |
On 05/15/2017 03:46 PM, Gustavo A. R. Silva wrote:
> The array field name in struct i2c_adapter is a fixed size array
> so it can never be NULL.
This was already caught by Colin Ian King, a patch is already queued for
this.
Thanks,
-corey
> Addresses-Coverity-ID: 1397986
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/char/ipmi/ipmi_ssif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index cca6e5b..df4fea7 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1415,7 +1415,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
> list_for_each_entry(info, &ssif_infos, link) {
> if (info->binfo.addr != client->addr)
> continue;
> - if (info->adapter_name && client->adapter->name &&
> + if (info->adapter_name &&
> strcmp_nospace(info->adapter_name,
> client->adapter->name))
> continue;
[toc] | [prev] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-05-17 23:00 +0200 |
| Message-ID | <tIed3-7Z1-7@gated-at.bofh.it> |
| In reply to | #1643354 |
Hi Corey, Quoting Corey Minyard <minyard@acm.org>: > On 05/15/2017 03:46 PM, Gustavo A. R. Silva wrote: >> The array field name in struct i2c_adapter is a fixed size array >> so it can never be NULL. > > This was already caught by Colin Ian King, a patch is already queued > for this. > Great, it's good to know. Thanks -- Gustavo A. R. Silva
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web