Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1645162 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2017-05-19 05:30 +0200 |
| Last post | 2017-05-22 20:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-19 05:30 +0200
Re: linux-next: build warning after merge of the drivers-x86 tree Darren Hart <dvhart@infradead.org> - 2017-05-20 00:10 +0200
Re: linux-next: build warning after merge of the drivers-x86 tree Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 20:10 +0200
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-05-19 05:30 +0200 |
| Subject | linux-next: build warning after merge of the drivers-x86 tree |
| Message-ID | <tIGM1-4u0-11@gated-at.bofh.it> |
Hi Darren,
After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
static ssize_t touchpad_store(struct device *dev,
^
Introduced by commit
7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
--
Cheers,
Stephen Rothwell
[toc] | [next] | [standalone]
| From | Darren Hart <dvhart@infradead.org> |
|---|---|
| Date | 2017-05-20 00:10 +0200 |
| Message-ID | <tIYfU-57-3@gated-at.bofh.it> |
| In reply to | #1645162 |
On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
> Hi Darren,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
> static ssize_t touchpad_store(struct device *dev,
> ^
>
> Introduced by commit
>
> 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
Thank you Stephen,
Andy, you warned me about this and I had forgotten before I included it in next.
Would you like to drop this change, or drop the touchpad_store function?
--
Darren Hart
VMware Open Source Technology Center
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-22 20:10 +0200 |
| Message-ID | <tJZWh-z3-1@gated-at.bofh.it> |
| In reply to | #1645978 |
On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> Hi Darren,
>>
>> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
>> static ssize_t touchpad_store(struct device *dev,
>> ^
>>
>> Introduced by commit
>>
>> 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
>
> Thank you Stephen,
>
> Andy, you warned me about this and I had forgotten before I included it in next.
>
> Would you like to drop this change, or drop the touchpad_store function?
I would go with Arnd's patch if he respins one addressing my comment.
--
With Best Regards,
Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web