Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1645957 > unrolled thread
| Started by | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| First post | 2017-05-19 23:30 +0200 |
| Last post | 2017-05-20 18:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] iio: light: isl29018: Only declare ACPI table when ACPI is enabled Matthias Kaehlcke <mka@chromium.org> - 2017-05-19 23:30 +0200
Re: [PATCH] iio: light: isl29018: Only declare ACPI table when ACPI is enabled Guenter Roeck <groeck@google.com> - 2017-05-20 00:00 +0200
Re: [PATCH] iio: light: isl29018: Only declare ACPI table when ACPI is enabled Jonathan Cameron <jic23@kernel.org> - 2017-05-20 18:10 +0200
| From | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| Date | 2017-05-19 23:30 +0200 |
| Subject | [PATCH] iio: light: isl29018: Only declare ACPI table when ACPI is enabled |
| Message-ID | <tIXDb-823-1@gated-at.bofh.it> |
This fixes the following warning when building with clang:
drivers/iio/light/isl29018.c:808:36: error: variable
'isl29018_acpi_match' is not needed and will not be emitted
[-Werror,-Wunneeded-internal-declaration]
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/iio/light/isl29018.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/light/isl29018.c b/drivers/iio/light/isl29018.c
index 917dd8b43e72..61f5924b472d 100644
--- a/drivers/iio/light/isl29018.c
+++ b/drivers/iio/light/isl29018.c
@@ -807,6 +807,7 @@ static SIMPLE_DEV_PM_OPS(isl29018_pm_ops, isl29018_suspend, isl29018_resume);
#define ISL29018_PM_OPS NULL
#endif
+#ifdef CONFIG_ACPI
static const struct acpi_device_id isl29018_acpi_match[] = {
{"ISL29018", isl29018},
{"ISL29023", isl29023},
@@ -814,6 +815,7 @@ static const struct acpi_device_id isl29018_acpi_match[] = {
{},
};
MODULE_DEVICE_TABLE(acpi, isl29018_acpi_match);
+#endif
static const struct i2c_device_id isl29018_id[] = {
{"isl29018", isl29018},
--
2.13.0.303.g4ebf302169-goog
[toc] | [next] | [standalone]
| From | Guenter Roeck <groeck@google.com> |
|---|---|
| Date | 2017-05-20 00:00 +0200 |
| Subject | Re: [PATCH] iio: light: isl29018: Only declare ACPI table when ACPI is enabled |
| Message-ID | <tIY6e-8ec-7@gated-at.bofh.it> |
| In reply to | #1645957 |
On Fri, May 19, 2017 at 2:28 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> This fixes the following warning when building with clang:
>
> drivers/iio/light/isl29018.c:808:36: error: variable
> 'isl29018_acpi_match' is not needed and will not be emitted
> [-Werror,-Wunneeded-internal-declaration]
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/iio/light/isl29018.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/light/isl29018.c b/drivers/iio/light/isl29018.c
> index 917dd8b43e72..61f5924b472d 100644
> --- a/drivers/iio/light/isl29018.c
> +++ b/drivers/iio/light/isl29018.c
> @@ -807,6 +807,7 @@ static SIMPLE_DEV_PM_OPS(isl29018_pm_ops, isl29018_suspend, isl29018_resume);
> #define ISL29018_PM_OPS NULL
> #endif
>
> +#ifdef CONFIG_ACPI
> static const struct acpi_device_id isl29018_acpi_match[] = {
> {"ISL29018", isl29018},
> {"ISL29023", isl29023},
> @@ -814,6 +815,7 @@ static const struct acpi_device_id isl29018_acpi_match[] = {
> {},
> };
> MODULE_DEVICE_TABLE(acpi, isl29018_acpi_match);
> +#endif
>
> static const struct i2c_device_id isl29018_id[] = {
> {"isl29018", isl29018},
> --
> 2.13.0.303.g4ebf302169-goog
>
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-05-20 18:10 +0200 |
| Subject | Re: [PATCH] iio: light: isl29018: Only declare ACPI table when ACPI is enabled |
| Message-ID | <tJf74-3G7-11@gated-at.bofh.it> |
| In reply to | #1645975 |
On 19/05/17 22:57, Guenter Roeck wrote:
> On Fri, May 19, 2017 at 2:28 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
>> This fixes the following warning when building with clang:
>>
>> drivers/iio/light/isl29018.c:808:36: error: variable
>> 'isl29018_acpi_match' is not needed and will not be emitted
>> [-Werror,-Wunneeded-internal-declaration]
>>
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
I wondered if we would be slightly neater if we went with
__maybe_unused markings but realised I didn't really care enough
to make you respin the patch ;) So if anyone else has strong
feelings on the two options, shout out now.
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
>
>> ---
>> drivers/iio/light/isl29018.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/iio/light/isl29018.c b/drivers/iio/light/isl29018.c
>> index 917dd8b43e72..61f5924b472d 100644
>> --- a/drivers/iio/light/isl29018.c
>> +++ b/drivers/iio/light/isl29018.c
>> @@ -807,6 +807,7 @@ static SIMPLE_DEV_PM_OPS(isl29018_pm_ops, isl29018_suspend, isl29018_resume);
>> #define ISL29018_PM_OPS NULL
>> #endif
>>
>> +#ifdef CONFIG_ACPI
>> static const struct acpi_device_id isl29018_acpi_match[] = {
>> {"ISL29018", isl29018},
>> {"ISL29023", isl29023},
>> @@ -814,6 +815,7 @@ static const struct acpi_device_id isl29018_acpi_match[] = {
>> {},
>> };
>> MODULE_DEVICE_TABLE(acpi, isl29018_acpi_match);
>> +#endif
>>
>> static const struct i2c_device_id isl29018_id[] = {
>> {"isl29018", isl29018},
>> --
>> 2.13.0.303.g4ebf302169-goog
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web