Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640304 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2017-05-12 10:20 +0200 |
| Last post | 2017-05-22 11:40 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Lee Jones <lee.jones@linaro.org> - 2017-05-12 10:20 +0200
Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-19 10:00 +0200
Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-19 16:30 +0200
Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-19 16:40 +0200
Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Lee Jones <lee.jones@linaro.org> - 2017-05-22 11:40 +0200
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-05-12 10:20 +0200 |
| Subject | Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform |
| Message-ID | <tGdXQ-1DJ-11@gated-at.bofh.it> |
On Tue, 09 May 2017, Andy Shevchenko wrote:
> On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote:
> > The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares
> > its I2C frequency.
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> > Signed-off-by: Sascha Weisenberger <sascha.weisenberger@siemens.com>
>
> Hmm... I thought that SoB chain goes from first author to last. (Or in
> case of maintainer / submitter their SoB goes at the end, which is
> apparently not the case here).
Yes, that's correct. I will switch them when I apply the patch.
> Other than above
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > ---
> > drivers/mfd/intel_quark_i2c_gpio.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/mfd/intel_quark_i2c_gpio.c
> > b/drivers/mfd/intel_quark_i2c_gpio.c
> > index 7946d6e38b87..98dddf2831ad 100644
> > --- a/drivers/mfd/intel_quark_i2c_gpio.c
> > +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> > @@ -72,6 +72,10 @@ static const struct i2c_mode_info
> > platform_i2c_mode_info[] = {
> > .name = "GalileoGen2",
> > .i2c_scl_freq = 400000,
> > },
> > + {
> > + .name = "SIMATIC IOT2000",
> > + .i2c_scl_freq = 400000,
> > + },
> > {}
> > };
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [next] | [standalone]
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-19 10:00 +0200 |
| Message-ID | <tIKZk-7rF-17@gated-at.bofh.it> |
| In reply to | #1640304 |
On 2017-05-12 10:12, Lee Jones wrote:
> On Tue, 09 May 2017, Andy Shevchenko wrote:
>
>> On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote:
>>> The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares
>>> its I2C frequency.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>
>>> Signed-off-by: Sascha Weisenberger <sascha.weisenberger@siemens.com>
>>
>> Hmm... I thought that SoB chain goes from first author to last. (Or in
>> case of maintainer / submitter their SoB goes at the end, which is
>> apparently not the case here).
>
> Yes, that's correct. I will switch them when I apply the patch.
Apparently, the patch is not yet in mfd-next, so let me retract it: I
just realized we should rather do an exact name/asset-tags match here as
well (like for exar and stmmac).
Moreover, I'd like to rework the DMI matching along Andy's suggestion
and use native matching methods (dmi_system_id table) instead of the
current open-code one. Patches will follow soon.
Jan
>
>> Other than above
>>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
>>>
>>> ---
>>> drivers/mfd/intel_quark_i2c_gpio.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c
>>> b/drivers/mfd/intel_quark_i2c_gpio.c
>>> index 7946d6e38b87..98dddf2831ad 100644
>>> --- a/drivers/mfd/intel_quark_i2c_gpio.c
>>> +++ b/drivers/mfd/intel_quark_i2c_gpio.c
>>> @@ -72,6 +72,10 @@ static const struct i2c_mode_info
>>> platform_i2c_mode_info[] = {
>>> .name = "GalileoGen2",
>>> .i2c_scl_freq = 400000,
>>> },
>>> + {
>>> + .name = "SIMATIC IOT2000",
>>> + .i2c_scl_freq = 400000,
>>> + },
>>> {}
>>> };
>>>
>>
>
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-19 16:30 +0200 |
| Message-ID | <tIR4J-3uF-7@gated-at.bofh.it> |
| In reply to | #1645304 |
On Fri, May 19, 2017 at 10:55 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-05-12 10:12, Lee Jones wrote: >> On Tue, 09 May 2017, Andy Shevchenko wrote: >> On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote: >>>> The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares >>>> its I2C frequency. > Apparently, the patch is not yet in mfd-next, so let me retract it: I > just realized we should rather do an exact name/asset-tags match here as > well (like for exar and stmmac). > > Moreover, I'd like to rework the DMI matching along Andy's suggestion > and use native matching methods (dmi_system_id table) instead of the > current open-code one. Patches will follow soon. Suggestion was made regarding another driver and code. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-19 16:40 +0200 |
| Message-ID | <tIRep-3xO-5@gated-at.bofh.it> |
| In reply to | #1645645 |
On 2017-05-19 16:22, Andy Shevchenko wrote: > On Fri, May 19, 2017 at 10:55 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> On 2017-05-12 10:12, Lee Jones wrote: >>> On Tue, 09 May 2017, Andy Shevchenko wrote: >>> On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote: >>>>> The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares >>>>> its I2C frequency. > >> Apparently, the patch is not yet in mfd-next, so let me retract it: I >> just realized we should rather do an exact name/asset-tags match here as >> well (like for exar and stmmac). >> >> Moreover, I'd like to rework the DMI matching along Andy's suggestion >> and use native matching methods (dmi_system_id table) instead of the >> current open-code one. Patches will follow soon. > > Suggestion was made regarding another driver and code. > Yes, but it applies here analogously, just like to stmmac_pci. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-05-22 11:40 +0200 |
| Message-ID | <tJRYK-3Yq-17@gated-at.bofh.it> |
| In reply to | #1645304 |
On Fri, 19 May 2017, Jan Kiszka wrote:
> On 2017-05-12 10:12, Lee Jones wrote:
> > On Tue, 09 May 2017, Andy Shevchenko wrote:
> >
> >> On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote:
> >>> The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares
> >>> its I2C frequency.
> >>>
> >>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >>> Signed-off-by: Sascha Weisenberger <sascha.weisenberger@siemens.com>
> >>
> >> Hmm... I thought that SoB chain goes from first author to last. (Or in
> >> case of maintainer / submitter their SoB goes at the end, which is
> >> apparently not the case here).
> >
> > Yes, that's correct. I will switch them when I apply the patch.
>
> Apparently, the patch is not yet in mfd-next, so let me retract it: I
> just realized we should rather do an exact name/asset-tags match here as
> well (like for exar and stmmac).
Consider it done.
> Moreover, I'd like to rework the DMI matching along Andy's suggestion
> and use native matching methods (dmi_system_id table) instead of the
> current open-code one. Patches will follow soon.
>
> Jan
>
> >
> >> Other than above
> >>
> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> >>>
> >>> ---
> >>> drivers/mfd/intel_quark_i2c_gpio.c | 4 ++++
> >>> 1 file changed, 4 insertions(+)
> >>>
> >>> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c
> >>> b/drivers/mfd/intel_quark_i2c_gpio.c
> >>> index 7946d6e38b87..98dddf2831ad 100644
> >>> --- a/drivers/mfd/intel_quark_i2c_gpio.c
> >>> +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> >>> @@ -72,6 +72,10 @@ static const struct i2c_mode_info
> >>> platform_i2c_mode_info[] = {
> >>> .name = "GalileoGen2",
> >>> .i2c_scl_freq = 400000,
> >>> },
> >>> + {
> >>> + .name = "SIMATIC IOT2000",
> >>> + .i2c_scl_freq = 400000,
> >>> + },
> >>> {}
> >>> };
> >>>
> >>
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web