Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1640510 > unrolled thread

[PATCH v4 1/2] clk: at91: fix clk-generated parenting

Back to article view | Back to linux.kernel

Contents

  [PATCH v4 1/2] clk: at91: fix clk-generated parenting Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-12 16:30 +0200
    Re: [PATCH v4 1/2] clk: at91: fix clk-generated parenting Stephen Boyd <sboyd@codeaurora.org> - 2017-05-19 03:40 +0200

#1640510 — [PATCH v4 1/2] clk: at91: fix clk-generated parenting

clk_generated_startup is called after clk_hw_register. So the first call to
get_parent will not have the correct value (i.e. 0) and because this is
cached, it may never be updated.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/clk/at91/clk-generated.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c
index 4e1cd5aa69d8..70474bd97a10 100644
--- a/drivers/clk/at91/clk-generated.c
+++ b/drivers/clk/at91/clk-generated.c
@@ -260,13 +260,12 @@ at91_clk_register_generated(struct regmap *regmap, spinlock_t *lock,
 	gck->lock = lock;
 	gck->range = *range;
 
+	clk_generated_startup(gck);
 	hw = &gck->hw;
 	ret = clk_hw_register(NULL, &gck->hw);
 	if (ret) {
 		kfree(gck);
 		hw = ERR_PTR(ret);
-	} else
-		clk_generated_startup(gck);
 
 	return hw;
 }
-- 
2.11.0

[toc] | [next] | [standalone]

#1645066

On 05/12, Alexandre Belloni wrote:
> clk_generated_startup is called after clk_hw_register. So the first call to
> get_parent will not have the correct value (i.e. 0) and because this is
> cached, it may never be updated.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---

Fixes tag?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web