Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1644832 > unrolled thread
| Started by | Joel Fernandes <joelaf@google.com> |
|---|---|
| First post | 2017-05-18 20:40 +0200 |
| Last post | 2017-05-19 07:10 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] cpufreq: Make iowait boost a policy option Joel Fernandes <joelaf@google.com> - 2017-05-18 20:40 +0200
Re: [PATCH 1/2] cpufreq: Make iowait boost a policy option "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-19 03:10 +0200
Re: [PATCH 1/2] cpufreq: Make iowait boost a policy option Joel Fernandes <joelaf@google.com> - 2017-05-19 03:30 +0200
Re: [PATCH 1/2] cpufreq: Make iowait boost a policy option Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-19 06:20 +0200
Re: [PATCH 1/2] cpufreq: Make iowait boost a policy option Joel Fernandes <joelaf@google.com> - 2017-05-19 07:10 +0200
| From | Joel Fernandes <joelaf@google.com> |
|---|---|
| Date | 2017-05-18 20:40 +0200 |
| Subject | [PATCH 1/2] cpufreq: Make iowait boost a policy option |
| Message-ID | <tIyv7-6vH-9@gated-at.bofh.it> |
Make iowait boost a cpufreq policy option and enable it for intel_pstate
cpufreq driver. Governors like schedutil can use it to determine if
boosting for tasks that wake up with p->in_iowait set is needed.
Signed-off-by: Joel Fernandes <joelaf@google.com>
---
drivers/cpufreq/intel_pstate.c | 1 +
include/linux/cpufreq.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index b7de5bd76a31..a3099f099779 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -2239,6 +2239,7 @@ static int intel_cpufreq_cpu_init(struct cpufreq_policy *policy)
policy->cpuinfo.transition_latency = INTEL_CPUFREQ_TRANSITION_LATENCY;
policy->transition_delay_us = INTEL_CPUFREQ_TRANSITION_DELAY;
+ policy->iowait_boost_enable = 1;
/* This reflects the intel_pstate_get_cpu_pstates() setting. */
policy->cur = policy->cpuinfo.min_freq;
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index a5ce0bbeadb5..4bb086dbe7ec 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -127,6 +127,9 @@ struct cpufreq_policy {
*/
unsigned int transition_delay_us;
+ /* Boost switch for tasks with p->in_iowait set */
+ unsigned int iowait_boost_enable;
+
/* Cached frequency lookup from cpufreq_driver_resolve_freq. */
unsigned int cached_target_freq;
int cached_resolved_idx;
--
2.13.0.303.g4ebf302169-goog
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rafael@kernel.org> |
|---|---|
| Date | 2017-05-19 03:10 +0200 |
| Message-ID | <tIEAx-31W-7@gated-at.bofh.it> |
| In reply to | #1644832 |
On Thu, May 18, 2017 at 8:30 PM, Joel Fernandes <joelaf@google.com> wrote:
> Make iowait boost a cpufreq policy option and enable it for intel_pstate
> cpufreq driver. Governors like schedutil can use it to determine if
> boosting for tasks that wake up with p->in_iowait set is needed.
>
> Signed-off-by: Joel Fernandes <joelaf@google.com>
> ---
> drivers/cpufreq/intel_pstate.c | 1 +
> include/linux/cpufreq.h | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index b7de5bd76a31..a3099f099779 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2239,6 +2239,7 @@ static int intel_cpufreq_cpu_init(struct cpufreq_policy *policy)
>
> policy->cpuinfo.transition_latency = INTEL_CPUFREQ_TRANSITION_LATENCY;
> policy->transition_delay_us = INTEL_CPUFREQ_TRANSITION_DELAY;
> + policy->iowait_boost_enable = 1;
> /* This reflects the intel_pstate_get_cpu_pstates() setting. */
> policy->cur = policy->cpuinfo.min_freq;
>
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index a5ce0bbeadb5..4bb086dbe7ec 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -127,6 +127,9 @@ struct cpufreq_policy {
> */
> unsigned int transition_delay_us;
>
> + /* Boost switch for tasks with p->in_iowait set */
> + unsigned int iowait_boost_enable;
Could that be a bool field?
> +
> /* Cached frequency lookup from cpufreq_driver_resolve_freq. */
> unsigned int cached_target_freq;
> int cached_resolved_idx;
> --
> 2.13.0.303.g4ebf302169-goog
>
Thanks,
Rafael
[toc] | [prev] | [next] | [standalone]
| From | Joel Fernandes <joelaf@google.com> |
|---|---|
| Date | 2017-05-19 03:30 +0200 |
| Message-ID | <tIETU-39a-27@gated-at.bofh.it> |
| In reply to | #1644998 |
On Thu, May 18, 2017 at 6:03 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
[..]
>> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
>> index a5ce0bbeadb5..4bb086dbe7ec 100644
>> --- a/include/linux/cpufreq.h
>> +++ b/include/linux/cpufreq.h
>> @@ -127,6 +127,9 @@ struct cpufreq_policy {
>> */
>> unsigned int transition_delay_us;
>>
>> + /* Boost switch for tasks with p->in_iowait set */
>> + unsigned int iowait_boost_enable;
>
> Could that be a bool field?
Yes that would be better, will do.
thanks,
-Joel
[toc] | [prev] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2017-05-19 06:20 +0200 |
| Message-ID | <tIHyp-50x-1@gated-at.bofh.it> |
| In reply to | #1644832 |
On Fri, May 19, 2017 at 12:00 AM, Joel Fernandes <joelaf@google.com> wrote: > Make iowait boost a cpufreq policy option and enable it for intel_pstate > cpufreq driver. Governors like schedutil can use it to determine if > boosting for tasks that wake up with p->in_iowait set is needed. > > Signed-off-by: Joel Fernandes <joelaf@google.com> > --- > drivers/cpufreq/intel_pstate.c | 1 + > include/linux/cpufreq.h | 3 +++ > 2 files changed, 4 insertions(+) Hi Joel, Please refer to MAINTAINERS file to find the list of people/list you need to send these patches to. You can take help from scripts/get_maintainers.pl as well. -- viresh
[toc] | [prev] | [next] | [standalone]
| From | Joel Fernandes <joelaf@google.com> |
|---|---|
| Date | 2017-05-19 07:10 +0200 |
| Message-ID | <tIIkO-5Eh-5@gated-at.bofh.it> |
| In reply to | #1645182 |
On Thu, May 18, 2017 at 9:17 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On Fri, May 19, 2017 at 12:00 AM, Joel Fernandes <joelaf@google.com> wrote: >> Make iowait boost a cpufreq policy option and enable it for intel_pstate >> cpufreq driver. Governors like schedutil can use it to determine if >> boosting for tasks that wake up with p->in_iowait set is needed. >> >> Signed-off-by: Joel Fernandes <joelaf@google.com> >> --- >> drivers/cpufreq/intel_pstate.c | 1 + >> include/linux/cpufreq.h | 3 +++ >> 2 files changed, 4 insertions(+) > > Hi Joel, > > Please refer to MAINTAINERS file to find the list of people/list you need to > send these patches to. You can take help from scripts/get_maintainers.pl > as well. Ok with me. thanks,
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web