Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642585 > unrolled thread

[PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

Back to article view | Back to linux.kernel

Contents

  [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets Anoob Soman <anoob.soman@citrix.com> - 2017-05-16 16:30 +0200
    Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets Joe Stringer <joe@ovn.org> - 2017-05-16 22:00 +0200
    Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding  packets Greg KH <gregkh@linuxfoundation.org> - 2017-05-17 10:20 +0200
      Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding  packets Anoob Soman <anoob.soman@citrix.com> - 2017-05-17 11:30 +0200
        Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding  packets Greg KH <gregkh@linuxfoundation.org> - 2017-05-18 10:20 +0200
          Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding  packets Anoob Soman <anoob.soman@citrix.com> - 2017-05-19 12:30 +0200

#1642585 — [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
forwarding") the skb->sender_cpu needs to be cleared before forwarding
packets.

Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
---
 net/openvswitch/vport.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 31cbc8c..a4887e7 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -503,6 +503,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb)
 	}
 
 	skb->dev = vport->dev;
+	skb_sender_cpu_clear(skb);
 	vport->ops->send(skb);
 	return;
 
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1642785

On 16 May 2017 at 07:25, Anoob Soman <anoob.soman@citrix.com> wrote:
> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
> forwarding") the skb->sender_cpu needs to be cleared before forwarding
> packets.
>
> Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
> Signed-off-by: Anoob Soman <anoob.soman@citrix.com>

Is this needed for 4.1 too?

[toc] | [prev] | [next] | [standalone]

#1643106 — Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

On Tue, May 16, 2017 at 03:25:10PM +0100, Anoob Soman wrote:
> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
> forwarding") the skb->sender_cpu needs to be cleared before forwarding
> packets.
> 
> Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
> Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
> ---
>  net/openvswitch/vport.c | 1 +
>  1 file changed, 1 insertion(+)

Why is this a non-upstream patch?  What commit in Linus's tree fixed
this?  Why not just backport that?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1643169 — Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

On 17/05/17 09:19, Greg KH wrote:
> Why is this a non-upstream patch?  What commit in Linus's tree fixed
> this?  Why not just backport that?
>
> thanks,
>
> greg k-h

Agreed, I think it is sensible to backport 52bd2d62ce67 "net: better 
skb->sender_cpu and skb->napi_id cohabitation" to 4.4, rather than 
having a different patch.

I think backport might be required for 4.1 as well, but I haven't checked.

-Anoob.

[toc] | [prev] | [next] | [standalone]

#1643943 — Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

On Wed, May 17, 2017 at 10:21:09AM +0100, Anoob Soman wrote:
> On 17/05/17 09:19, Greg KH wrote:
> > Why is this a non-upstream patch?  What commit in Linus's tree fixed
> > this?  Why not just backport that?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Agreed, I think it is sensible to backport 52bd2d62ce67 "net: better
> skb->sender_cpu and skb->napi_id cohabitation" to 4.4, rather than having a
> different patch.

So backporting that one patch solves the issue here?  Can you please
verify it, and let me know before I apply it?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1645495 — Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

On 18/05/17 09:11, Greg KH wrote:
> So backporting that one patch solves the issue here?  Can you please
> verify it, and let me know before I apply it?
>
> thanks,
>
> greg k-h

yes, I can do that.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web