Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643133 > unrolled thread

[PATCH] frv: use generic fb.h

Back to article view | Back to linux.kernel

Contents

  [PATCH] frv: use generic fb.h Tobias Klauser <tklauser@distanz.ch> - 2017-05-17 10:40 +0200
    Re: [PATCH] frv: use generic fb.h David Howells <dhowells@redhat.com> - 2017-05-24 15:00 +0200

#1643133 — [PATCH] frv: use generic fb.h

The arch uses a verbatim copy of the asm-generic version and does not
add any own implemntations to the header, so use asm-generic/fb.h
instead of duplicating code.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 arch/frv/include/asm/Kbuild |  1 +
 arch/frv/include/asm/fb.h   | 12 ------------
 2 files changed, 1 insertion(+), 12 deletions(-)
 delete mode 100644 arch/frv/include/asm/fb.h

diff --git a/arch/frv/include/asm/Kbuild b/arch/frv/include/asm/Kbuild
index cce3bc3603ea..7d4ab04c657f 100644
--- a/arch/frv/include/asm/Kbuild
+++ b/arch/frv/include/asm/Kbuild
@@ -2,6 +2,7 @@
 generic-y += clkdev.h
 generic-y += exec.h
 generic-y += extable.h
+generic-y += fb.h
 generic-y += irq_work.h
 generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
diff --git a/arch/frv/include/asm/fb.h b/arch/frv/include/asm/fb.h
deleted file mode 100644
index c7df38030992..000000000000
--- a/arch/frv/include/asm/fb.h
+++ /dev/null
@@ -1,12 +0,0 @@
-#ifndef _ASM_FB_H_
-#define _ASM_FB_H_
-#include <linux/fb.h>
-
-#define fb_pgprotect(...) do {} while (0)
-
-static inline int fb_is_primary_device(struct fb_info *info)
-{
-	return 0;
-}
-
-#endif /* _ASM_FB_H_ */
-- 
2.13.0

[toc] | [next] | [standalone]

#1649596

Tobias Klauser <tklauser@distanz.ch> wrote:

> The arch uses a verbatim copy of the asm-generic version and does not
> add any own implemntations to the header, so use asm-generic/fb.h
> instead of duplicating code.

"implementations".  This goes for the mn10300 patch also.

> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Reviewed-by: David Howells <dhowells@redhat.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web