Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1642900 > unrolled thread

[PATCH 1/2] ubifs: Fix inode data budget in ubifs_mknod

Started byHyunchul Lee <cheol.lee@lge.com>
First post2017-05-17 02:10 +0200
Last post2017-05-17 09:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/2] ubifs: Fix inode data budget in ubifs_mknod Hyunchul Lee <cheol.lee@lge.com> - 2017-05-17 02:10 +0200
    Re: [PATCH 1/2] ubifs: Fix inode data budget in ubifs_mknod Richard Weinberger <richard@nod.at> - 2017-05-17 09:00 +0200

#1642900 — [PATCH 1/2] ubifs: Fix inode data budget in ubifs_mknod

FromHyunchul Lee <cheol.lee@lge.com>
Date2017-05-17 02:10 +0200
Subject[PATCH 1/2] ubifs: Fix inode data budget in ubifs_mknod
Message-ID<tHUHn-4dm-5@gated-at.bofh.it>
Assign inode data budget to budget request correctly.

Signed-off-by: Hyunchul Lee <cheol.lee@lge.com>
---
 fs/ubifs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index b777bdd..df67236 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -1050,7 +1050,6 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
 	int sz_change;
 	int err, devlen = 0;
 	struct ubifs_budget_req req = { .new_ino = 1, .new_dent = 1,
-					.new_ino_d = ALIGN(devlen, 8),
 					.dirtied_ino = 1 };
 	struct fscrypt_name nm;
 
@@ -1068,6 +1067,7 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
 		devlen = ubifs_encode_dev(dev, rdev);
 	}
 
+	req.new_ino_d = ALIGN(devlen, 8);
 	err = ubifs_budget_space(c, &req);
 	if (err) {
 		kfree(dev);
-- 
1.9.1

[toc] | [next] | [standalone]


#1643014

FromRichard Weinberger <richard@nod.at>
Date2017-05-17 09:00 +0200
Message-ID<tI16a-86C-17@gated-at.bofh.it>
In reply to#1642900
Hyunchul,

Am 17.05.2017 um 01:57 schrieb Hyunchul Lee:
> Assign inode data budget to budget request correctly.
> 
> Signed-off-by: Hyunchul Lee <cheol.lee@lge.com>
> ---
>  fs/ubifs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
> index b777bdd..df67236 100644
> --- a/fs/ubifs/dir.c
> +++ b/fs/ubifs/dir.c
> @@ -1050,7 +1050,6 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
>  	int sz_change;
>  	int err, devlen = 0;
>  	struct ubifs_budget_req req = { .new_ino = 1, .new_dent = 1,
> -					.new_ino_d = ALIGN(devlen, 8),
>  					.dirtied_ino = 1 };
>  	struct fscrypt_name nm;
>  
> @@ -1068,6 +1067,7 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
>  		devlen = ubifs_encode_dev(dev, rdev);
>  	}
>  
> +	req.new_ino_d = ALIGN(devlen, 8);

Good find!

Thanks,
//richard

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web