Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1642261 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-05-16 09:20 +0200 |
| Last post | 2017-05-17 08:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v1] cpufreq: kirkwood-cpufreq:- Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-05-16 09:20 +0200
Re: [PATCH v1] cpufreq: kirkwood-cpufreq:- Handle return value of clk_prepare_enable Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-17 06:40 +0200
Re: [PATCH v1] cpufreq: kirkwood-cpufreq:- Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-05-17 08:00 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-05-16 09:20 +0200 |
| Subject | [PATCH v1] cpufreq: kirkwood-cpufreq:- Handle return value of clk_prepare_enable |
| Message-ID | <tHEVX-2xx-7@gated-at.bofh.it> |
Here, Clock enable can failed. So adding an error check for
clk_prepare_enable.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/cpufreq/kirkwood-cpufreq.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c
index 1b9bcd7..4c30103 100644
--- a/drivers/cpufreq/kirkwood-cpufreq.c
+++ b/drivers/cpufreq/kirkwood-cpufreq.c
@@ -127,7 +127,12 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
return PTR_ERR(priv.cpu_clk);
}
- clk_prepare_enable(priv.cpu_clk);
+ err = clk_prepare_enable(priv.cpu_clk);
+ if (err) {
+ dev_err(priv.dev, "Unable to prepare cpuclk\n");
+ return err;
+ }
+
kirkwood_freq_table[0].frequency = clk_get_rate(priv.cpu_clk) / 1000;
priv.ddr_clk = of_clk_get_by_name(np, "ddrclk");
@@ -137,7 +142,11 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
goto out_cpu;
}
- clk_prepare_enable(priv.ddr_clk);
+ err = clk_prepare_enable(priv.ddr_clk);
+ if (err) {
+ dev_err(priv.dev, "Unable to prepare ddrclk\n");
+ goto out_cpu;
+ }
kirkwood_freq_table[1].frequency = clk_get_rate(priv.ddr_clk) / 1000;
priv.powersave_clk = of_clk_get_by_name(np, "powersave");
--
1.9.1
[toc] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2017-05-17 06:40 +0200 |
| Subject | Re: [PATCH v1] cpufreq: kirkwood-cpufreq:- Handle return value of clk_prepare_enable |
| Message-ID | <tHYUF-6PQ-5@gated-at.bofh.it> |
| In reply to | #1642261 |
On 16-05-17, 12:41, Arvind Yadav wrote:
> Here, Clock enable can failed. So adding an error check for
> clk_prepare_enable.
Rewrite it as:
clk_prepare_enable() can fail here and we must check its return value.
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/cpufreq/kirkwood-cpufreq.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c
> index 1b9bcd7..4c30103 100644
> --- a/drivers/cpufreq/kirkwood-cpufreq.c
> +++ b/drivers/cpufreq/kirkwood-cpufreq.c
> @@ -127,7 +127,12 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
> return PTR_ERR(priv.cpu_clk);
> }
>
> - clk_prepare_enable(priv.cpu_clk);
> + err = clk_prepare_enable(priv.cpu_clk);
> + if (err) {
> + dev_err(priv.dev, "Unable to prepare cpuclk\n");
> + return err;
> + }
> +
> kirkwood_freq_table[0].frequency = clk_get_rate(priv.cpu_clk) / 1000;
>
> priv.ddr_clk = of_clk_get_by_name(np, "ddrclk");
> @@ -137,7 +142,11 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
> goto out_cpu;
> }
>
> - clk_prepare_enable(priv.ddr_clk);
> + err = clk_prepare_enable(priv.ddr_clk);
> + if (err) {
> + dev_err(priv.dev, "Unable to prepare ddrclk\n");
> + goto out_cpu;
> + }
> kirkwood_freq_table[1].frequency = clk_get_rate(priv.ddr_clk) / 1000;
>
> priv.powersave_clk = of_clk_get_by_name(np, "powersave");
There is one more prepare-enable after this. Why not fix that as well
?
--
viresh
[toc] | [prev] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-05-17 08:00 +0200 |
| Subject | Re: [PATCH v1] cpufreq: kirkwood-cpufreq:- Handle return value of clk_prepare_enable |
| Message-ID | <tI0a5-7yt-1@gated-at.bofh.it> |
| In reply to | #1642965 |
Yes, I will add check for powersave clk.
Thanks
- Arvind
On Wednesday 17 May 2017 10:04 AM, Viresh Kumar wrote:
> On 16-05-17, 12:41, Arvind Yadav wrote:
>> Here, Clock enable can failed. So adding an error check for
>> clk_prepare_enable.
> Rewrite it as:
>
> clk_prepare_enable() can fail here and we must check its return value.
>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/cpufreq/kirkwood-cpufreq.c | 13 +++++++++++--
>> 1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c
>> index 1b9bcd7..4c30103 100644
>> --- a/drivers/cpufreq/kirkwood-cpufreq.c
>> +++ b/drivers/cpufreq/kirkwood-cpufreq.c
>> @@ -127,7 +127,12 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>> return PTR_ERR(priv.cpu_clk);
>> }
>>
>> - clk_prepare_enable(priv.cpu_clk);
>> + err = clk_prepare_enable(priv.cpu_clk);
>> + if (err) {
>> + dev_err(priv.dev, "Unable to prepare cpuclk\n");
>> + return err;
>> + }
>> +
>> kirkwood_freq_table[0].frequency = clk_get_rate(priv.cpu_clk) / 1000;
>>
>> priv.ddr_clk = of_clk_get_by_name(np, "ddrclk");
>> @@ -137,7 +142,11 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>> goto out_cpu;
>> }
>>
>> - clk_prepare_enable(priv.ddr_clk);
>> + err = clk_prepare_enable(priv.ddr_clk);
>> + if (err) {
>> + dev_err(priv.dev, "Unable to prepare ddrclk\n");
>> + goto out_cpu;
>> + }
>> kirkwood_freq_table[1].frequency = clk_get_rate(priv.ddr_clk) / 1000;
>>
>> priv.powersave_clk = of_clk_get_by_name(np, "powersave");
> There is one more prepare-enable after this. Why not fix that as well
> ?
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web