Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641875 > unrolled thread

[PATCH] soc: imx: Select PM_GENERIC_DOMAINS only if PM is enabled

Back to article view | Back to linux.kernel

Contents

  [PATCH] soc: imx: Select PM_GENERIC_DOMAINS only if PM is enabled Guenter Roeck <linux@roeck-us.net> - 2017-05-15 18:40 +0200
    Re: [PATCH] soc: imx: Select PM_GENERIC_DOMAINS only if PM is enabled Fabio Estevam <festevam@gmail.com> - 2017-05-15 19:30 +0200

#1641875 — [PATCH] soc: imx: Select PM_GENERIC_DOMAINS only if PM is enabled

Selecting PM_GENERIC_DOMAINS without PM results in the following build
errors, seen when building sparc32:allmodconfig.

drivers/base/power/domain.c: In function 'genpd_queue_power_off_work':
drivers/base/power/domain.c:279:13: error: 'pm_wq' undeclared
drivers/base/power/domain.c: In function 'genpd_dev_pm_qos_notifier':
drivers/base/power/domain.c:462:25: error:
	'struct dev_pm_info' has no member named 'ignore_children'
drivers/base/power/domain.c: In function 'rtpm_status_str':
drivers/base/power/domain.c:2207:16: error:
	'struct dev_pm_info' has no member named 'runtime_error'
drivers/base/power/domain.c:2209:21: error:
	'struct dev_pm_info' has no member named 'disable_depth'
drivers/base/power/domain.c:2211:21: error:
	'struct dev_pm_info' has no member named 'runtime_status'
drivers/base/power/domain.c:2212:31: error:
	'struct dev_pm_info' has no member named 'runtime_status'

Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/soc/imx/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 357a5d8f8da0..9c1c75f282c2 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -2,7 +2,7 @@ menu "i.MX SoC drivers"
 
 config IMX7_PM_DOMAINS
 	bool "i.MX7 PM domains"
-	select PM_GENERIC_DOMAINS
+	select PM_GENERIC_DOMAINS if PM
 	depends on SOC_IMX7D || (COMPILE_TEST && OF)
 	default y if SOC_IMX7D
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1641909

Hi Guenter,

On Mon, May 15, 2017 at 1:33 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> Selecting PM_GENERIC_DOMAINS without PM results in the following build
> errors, seen when building sparc32:allmodconfig.
>
> drivers/base/power/domain.c: In function 'genpd_queue_power_off_work':
> drivers/base/power/domain.c:279:13: error: 'pm_wq' undeclared
> drivers/base/power/domain.c: In function 'genpd_dev_pm_qos_notifier':
> drivers/base/power/domain.c:462:25: error:
>         'struct dev_pm_info' has no member named 'ignore_children'
> drivers/base/power/domain.c: In function 'rtpm_status_str':
> drivers/base/power/domain.c:2207:16: error:
>         'struct dev_pm_info' has no member named 'runtime_error'
> drivers/base/power/domain.c:2209:21: error:
>         'struct dev_pm_info' has no member named 'disable_depth'
> drivers/base/power/domain.c:2211:21: error:
>         'struct dev_pm_info' has no member named 'runtime_status'
> drivers/base/power/domain.c:2212:31: error:
>         'struct dev_pm_info' has no member named 'runtime_status'
>
> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
> Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

This patch from Arnd should fix it:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/fixes&id=e23c7f7d57831fdae444be9d507e67716ab601d4

This one should land in linux-next tomorrow.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web