Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641669 > unrolled thread

Re: [PATCH 4/9] power: supply: axp20x_usb_power: Drop unnecessary static

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 4/9] power: supply: axp20x_usb_power: Drop unnecessary  static Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 15:30 +0200

#1641669 — Re: [PATCH 4/9] power: supply: axp20x_usb_power: Drop unnecessary static

[Multipart message — attachments visible in raw view] — view raw

Hi Julia,

On Thu, May 04, 2017 at 10:10:49PM +0200, Julia Lawall wrote:
> Drop static on a local variable, when the variable is either first
> initialized or never used, on every possible execution path through the
> function.  The static has no benefit, and dropping it reduces the code
> size.
> 
> [...]
> 
> before:
>    text    data     bss     dec     hex filename
>    2865     252       8    3125     c35 drivers/power/supply/axp20x_usb_power.o
> 
> after:
>    text    data     bss     dec     hex filename
>    2822     252       0    3074     c02 drivers/power/supply/axp20x_usb_power.o

Thanks, queued.

-- Sebastian

> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/power/supply/axp20x_usb_power.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c
> index 2397c48..44f70dc 100644
> --- a/drivers/power/supply/axp20x_usb_power.c
> +++ b/drivers/power/supply/axp20x_usb_power.c
> @@ -339,7 +339,7 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
>  		"VBUS_REMOVAL", "VBUS_VALID", "VBUS_NOT_VALID", NULL };
>  	static const char * const axp22x_irq_names[] = {
>  		"VBUS_PLUGIN", "VBUS_REMOVAL", NULL };
> -	static const char * const *irq_names;
> +	const char * const *irq_names;
>  	const struct power_supply_desc *usb_power_desc;
>  	int i, irq, ret;
>  
> 

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web