Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641033 > unrolled thread

xfs_iomap.c:undefined reference to `put_dax'

Started bykbuild test robot <fengguang.wu@intel.com>
First post2017-05-14 01:30 +0200
Last post2017-05-15 16:30 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  xfs_iomap.c:undefined reference to `put_dax' kbuild test robot <fengguang.wu@intel.com> - 2017-05-14 01:30 +0200
    Re: xfs_iomap.c:undefined reference to `put_dax' Arnd Bergmann <arnd@arndb.de> - 2017-05-15 15:30 +0200
      Re: xfs_iomap.c:undefined reference to `put_dax' Dan Williams <dan.j.williams@intel.com> - 2017-05-15 15:40 +0200
        Re: xfs_iomap.c:undefined reference to `put_dax' Arnd Bergmann <arnd@arndb.de> - 2017-05-15 16:00 +0200
          Re: xfs_iomap.c:undefined reference to `put_dax' Dan Williams <dan.j.williams@intel.com> - 2017-05-15 16:10 +0200
            Re: xfs_iomap.c:undefined reference to `put_dax' Arnd Bergmann <arnd@arndb.de> - 2017-05-15 16:30 +0200

#1641033 — xfs_iomap.c:undefined reference to `put_dax'

Fromkbuild test robot <fengguang.wu@intel.com>
Date2017-05-14 01:30 +0200
Subjectxfs_iomap.c:undefined reference to `put_dax'
Message-ID<tGOE1-1ZD-3@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   cd636458904a04de2349c728323c5d2af1203bdf
commit: ef51042472f55b325fd7f2b26a2e29fd89757234 block, dax: move "select DAX" from BLOCK to FS_DAX
date:   5 days ago
config: ia64-bigsur_defconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout ef51042472f55b325fd7f2b26a2e29fd89757234
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   fs/built-in.o: In function `xfs_file_iomap_end':
>> xfs_iomap.c:(.text+0x2e3022): undefined reference to `put_dax'
   fs/built-in.o: In function `xfs_file_iomap_begin':
>> xfs_iomap.c:(.text+0x2e4502): undefined reference to `dax_get_by_host'

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]

#1641668

FromArnd Bergmann <arnd@arndb.de>
Date2017-05-15 15:30 +0200
Message-ID<tHoeu-iQ-17@gated-at.bofh.it>
In reply to#1641033
On Sun, May 14, 2017 at 1:21 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   cd636458904a04de2349c728323c5d2af1203bdf
> commit: ef51042472f55b325fd7f2b26a2e29fd89757234 block, dax: move "select DAX" from BLOCK to FS_DAX
> date:   5 days ago
> config: ia64-bigsur_defconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 6.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout ef51042472f55b325fd7f2b26a2e29fd89757234
>         # save the attached .config to linux build tree
>         make.cross ARCH=ia64
>
> All errors (new ones prefixed by >>):
>
>    fs/built-in.o: In function `xfs_file_iomap_end':
>>> xfs_iomap.c:(.text+0x2e3022): undefined reference to `put_dax'
>    fs/built-in.o: In function `xfs_file_iomap_begin':
>>> xfs_iomap.c:(.text+0x2e4502): undefined reference to `dax_get_by_host'

This is caused by CONFIG_DAX now being allowed to be '=m' while used by
a built-in file system. This only happens for XFS at the moment though, as the
other file systems check for CONFIG_FS_DAX already.

I have a patch that I'm testing at the moment.

       Arnd

[toc] | [prev] | [next] | [standalone]

#1641679

FromDan Williams <dan.j.williams@intel.com>
Date2017-05-15 15:40 +0200
Message-ID<tHoo9-lZ-19@gated-at.bofh.it>
In reply to#1641668
On Mon, May 15, 2017 at 6:25 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Sun, May 14, 2017 at 1:21 AM, kbuild test robot
> <fengguang.wu@intel.com> wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   cd636458904a04de2349c728323c5d2af1203bdf
>> commit: ef51042472f55b325fd7f2b26a2e29fd89757234 block, dax: move "select DAX" from BLOCK to FS_DAX
>> date:   5 days ago
>> config: ia64-bigsur_defconfig (attached as .config)
>> compiler: ia64-linux-gcc (GCC) 6.2.0
>> reproduce:
>>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         git checkout ef51042472f55b325fd7f2b26a2e29fd89757234
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=ia64
>>
>> All errors (new ones prefixed by >>):
>>
>>    fs/built-in.o: In function `xfs_file_iomap_end':
>>>> xfs_iomap.c:(.text+0x2e3022): undefined reference to `put_dax'
>>    fs/built-in.o: In function `xfs_file_iomap_begin':
>>>> xfs_iomap.c:(.text+0x2e4502): undefined reference to `dax_get_by_host'
>
> This is caused by CONFIG_DAX now being allowed to be '=m' while used by
> a built-in file system. This only happens for XFS at the moment though, as the
> other file systems check for CONFIG_FS_DAX already.
>
> I have a patch that I'm testing at the moment.
>

Hi Arnd,

I have this patch out for testing.

https://patchwork.kernel.org/patch/9725515/

[toc] | [prev] | [next] | [standalone]

#1641713

FromArnd Bergmann <arnd@arndb.de>
Date2017-05-15 16:00 +0200
Message-ID<tHoHw-sA-7@gated-at.bofh.it>
In reply to#1641679
On Mon, May 15, 2017 at 3:38 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, May 15, 2017 at 6:25 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Sun, May 14, 2017 at 1:21 AM, kbuild test robot
>> <fengguang.wu@intel.com> wrote:
>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>> head:   cd636458904a04de2349c728323c5d2af1203bdf
>>> commit: ef51042472f55b325fd7f2b26a2e29fd89757234 block, dax: move "select DAX" from BLOCK to FS_DAX
>>> date:   5 days ago
>>> config: ia64-bigsur_defconfig (attached as .config)
>>> compiler: ia64-linux-gcc (GCC) 6.2.0
>>> reproduce:
>>>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>         chmod +x ~/bin/make.cross
>>>         git checkout ef51042472f55b325fd7f2b26a2e29fd89757234
>>>         # save the attached .config to linux build tree
>>>         make.cross ARCH=ia64
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>    fs/built-in.o: In function `xfs_file_iomap_end':
>>>>> xfs_iomap.c:(.text+0x2e3022): undefined reference to `put_dax'
>>>    fs/built-in.o: In function `xfs_file_iomap_begin':
>>>>> xfs_iomap.c:(.text+0x2e4502): undefined reference to `dax_get_by_host'
>>
>> This is caused by CONFIG_DAX now being allowed to be '=m' while used by
>> a built-in file system. This only happens for XFS at the moment though, as the
>> other file systems check for CONFIG_FS_DAX already.
>>
>> I have a patch that I'm testing at the moment.
>>
>
> Hi Arnd,
>
> I have this patch out for testing.
>
> https://patchwork.kernel.org/patch/9725515/

That looks good for the file system parts, but what about drivers/md/dm.c,
do you have another patch for that one? With just the one patch you
quoted, that would break when dax_get_by_host() gets removed.

        Arnd

[toc] | [prev] | [next] | [standalone]

#1641718

FromDan Williams <dan.j.williams@intel.com>
Date2017-05-15 16:10 +0200
Message-ID<tHoRb-KQ-11@gated-at.bofh.it>
In reply to#1641713
On Mon, May 15, 2017 at 6:59 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Mon, May 15, 2017 at 3:38 PM, Dan Williams <dan.j.williams@intel.com> wrote:
>> On Mon, May 15, 2017 at 6:25 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Sun, May 14, 2017 at 1:21 AM, kbuild test robot
>>> <fengguang.wu@intel.com> wrote:
>>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>>> head:   cd636458904a04de2349c728323c5d2af1203bdf
>>>> commit: ef51042472f55b325fd7f2b26a2e29fd89757234 block, dax: move "select DAX" from BLOCK to FS_DAX
>>>> date:   5 days ago
>>>> config: ia64-bigsur_defconfig (attached as .config)
>>>> compiler: ia64-linux-gcc (GCC) 6.2.0
>>>> reproduce:
>>>>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>         chmod +x ~/bin/make.cross
>>>>         git checkout ef51042472f55b325fd7f2b26a2e29fd89757234
>>>>         # save the attached .config to linux build tree
>>>>         make.cross ARCH=ia64
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>>    fs/built-in.o: In function `xfs_file_iomap_end':
>>>>>> xfs_iomap.c:(.text+0x2e3022): undefined reference to `put_dax'
>>>>    fs/built-in.o: In function `xfs_file_iomap_begin':
>>>>>> xfs_iomap.c:(.text+0x2e4502): undefined reference to `dax_get_by_host'
>>>
>>> This is caused by CONFIG_DAX now being allowed to be '=m' while used by
>>> a built-in file system. This only happens for XFS at the moment though, as the
>>> other file systems check for CONFIG_FS_DAX already.
>>>
>>> I have a patch that I'm testing at the moment.
>>>
>>
>> Hi Arnd,
>>
>> I have this patch out for testing.
>>
>> https://patchwork.kernel.org/patch/9725515/
>
> That looks good for the file system parts, but what about drivers/md/dm.c,
> do you have another patch for that one? With just the one patch you
> quoted, that would break when dax_get_by_host() gets removed.
>

BLK_DEV_DM selects DAX so dax_get_by_host() should always be available.

[toc] | [prev] | [next] | [standalone]

#1641737

FromArnd Bergmann <arnd@arndb.de>
Date2017-05-15 16:30 +0200
Message-ID<tHpax-Ra-1@gated-at.bofh.it>
In reply to#1641718
On Mon, May 15, 2017 at 4:05 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, May 15, 2017 at 6:59 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Mon, May 15, 2017 at 3:38 PM, Dan Williams <dan.j.williams@intel.com> wrote:

>>>
>>> I have this patch out for testing.
>>>
>>> https://patchwork.kernel.org/patch/9725515/
>>
>> That looks good for the file system parts, but what about drivers/md/dm.c,
>> do you have another patch for that one? With just the one patch you
>> quoted, that would break when dax_get_by_host() gets removed.
>>
>
> BLK_DEV_DM selects DAX so dax_get_by_host() should always be available.

Got it, I just misread your patch and I agree this should work fine.

        Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web