Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641549 > unrolled thread

[PATCH 0/3] pinctrl: cherryview: Extend the DMI quirk to Intel_Strago systems

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] pinctrl: cherryview: Extend the DMI quirk to Intel_Strago systems Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-15 13:10 +0200
    [PATCH 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-15 13:10 +0200
    Re: [PATCH 0/3] pinctrl: cherryview: Extend the DMI quirk to  Intel_Strago systems Linus Walleij <linus.walleij@linaro.org> - 2017-05-23 10:10 +0200

#1641549 — [PATCH 0/3] pinctrl: cherryview: Extend the DMI quirk to Intel_Strago systems

Hi,

It turned out that there are bunch of other Chromebooks that need the DMI
quirk as well. Most of these are based on Intel_Strago reference design so
we can identify them by using DMI_PRODUCT_FAMILY introduced in this series.
The systems without the family string we add them separately.

Related bugzilla entry:

  https://bugzilla.kernel.org/show_bug.cgi?id=194945

I'm including fix from Yongjun as well because I did not find it in
v4.12-rc1 possibly because it just was forgotten.

Mika Westerberg (2):
  firmware: dmi: Add DMI_PRODUCT_FAMILY identification string
  pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems

Wei Yongjun (1):
  pinctrl: cherryview: Add terminate entry for dmi_system_id tables

 drivers/firmware/dmi-id.c                  |  2 ++
 drivers/firmware/dmi_scan.c                |  1 +
 drivers/pinctrl/intel/pinctrl-cherryview.c | 26 +++++++++++++++++++++-----
 include/linux/mod_devicetable.h            |  1 +
 4 files changed, 25 insertions(+), 5 deletions(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1641550 — [PATCH 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables

From: Wei Yongjun <weiyongjun1@huawei.com>

Make sure dmi_system_id tables are NULL terminated.

Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-cherryview.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index 2debba62fac9..e35d0fe4c737 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1547,7 +1547,8 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"),
 			DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"),
 		},
-	}
+	},
+	{}
 };
 
 static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq)
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1647773 — Re: [PATCH 0/3] pinctrl: cherryview: Extend the DMI quirk to Intel_Strago systems

On Mon, May 15, 2017 at 1:01 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:

> It turned out that there are bunch of other Chromebooks that need the DMI
> quirk as well. Most of these are based on Intel_Strago reference design so
> we can identify them by using DMI_PRODUCT_FAMILY introduced in this series.
> The systems without the family string we add them separately.

I guess this is fixes material.

Who can ACK the firmware patch?

That subsystem seems to be weirdly floating between maintainers...

Andy generally seems to know what is going on with Intel
firmwares, so Andy can you ACK this patch set?

Jean Delvare's review would also be appreciated.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web