Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1641543 > unrolled thread
| Started by | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| First post | 2017-05-15 13:10 +0200 |
| Last post | 2017-05-16 00:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-15 13:10 +0200
Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-15 13:20 +0200
Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-15 13:20 +0200
Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-16 00:30 +0200
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Date | 2017-05-15 13:10 +0200 |
| Subject | [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems |
| Message-ID | <tHm2Z-7kX-7@gated-at.bofh.it> |
It turns out there are quite many Chromebooks out there that have the
same keyboard issue than Acer Chromebook. All of them are based on
Intel_Strago reference and report their DMI_PRODUCT_FAMILY as
"Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are exceptions
for which we add separate entries).
Instead of adding each machine to the quirk table, we use
DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the
machines out there currently.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=194945
Suggested: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index e35d0fe4c737..3366959cf988 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1539,13 +1539,28 @@ static void chv_gpio_irq_handler(struct irq_desc *desc)
* is not listed below.
*/
static const struct dmi_system_id chv_no_valid_mask[] = {
+ /* See https://bugzilla.kernel.org/show_bug.cgi?id=194945 */
{
- /* See https://bugzilla.kernel.org/show_bug.cgi?id=194945 */
- .ident = "Acer Chromebook (CYAN)",
+ .ident = "Intel_Strago based Chromebooks",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
- DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"),
- DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"),
+ DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
+ },
+ },
+ {
+ .ident = "Cyan Chromebook",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
+ DMI_MATCH(DMI_BIOS_DATE, "05/20/2016"),
+ },
+ },
+ {
+ .ident = "Samsung Chromebook 3",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
+ DMI_MATCH(DMI_BIOS_DATE, "01/19/2017"),
},
},
{}
--
2.11.0
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2017-05-15 13:20 +0200 |
| Subject | Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems |
| Message-ID | <tHmcG-7ob-11@gated-at.bofh.it> |
| In reply to | #1641543 |
On Mon, 2017-05-15 at 14:01 +0300, Mika Westerberg wrote: > It turns out there are quite many Chromebooks out there that have the > same keyboard issue than Acer Chromebook. All of them are based on > Intel_Strago reference and report their DMI_PRODUCT_FAMILY as > "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are > exceptions > for which we add separate entries). > > Instead of adding each machine to the quirk table, we use > DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the > machines out there currently. > > > + .ident = "Intel_Strago based Chromebooks", > + .ident = "Cyan Chromebook", > + .ident = "Samsung Chromebook 3", I would do something like below (though I'm fine with current as well). .ident = "Intel_Strago based Chromebooks (All models)", .ident = "Intel_Strago based Chromebooks (Cyan)", .ident = "Samsung Chromebook 3 (Celes)", -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
[toc] | [prev] | [next] | [standalone]
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Date | 2017-05-15 13:20 +0200 |
| Subject | Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems |
| Message-ID | <tHmcG-7ob-23@gated-at.bofh.it> |
| In reply to | #1641553 |
On Mon, May 15, 2017 at 02:14:38PM +0300, Andy Shevchenko wrote: > On Mon, 2017-05-15 at 14:01 +0300, Mika Westerberg wrote: > > It turns out there are quite many Chromebooks out there that have the > > same keyboard issue than Acer Chromebook. All of them are based on > > Intel_Strago reference and report their DMI_PRODUCT_FAMILY as > > "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are > > exceptions > > for which we add separate entries). > > > > Instead of adding each machine to the quirk table, we use > > DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the > > machines out there currently. > > > > > > > + .ident = "Intel_Strago based Chromebooks", > > > + .ident = "Cyan Chromebook", > > > + .ident = "Samsung Chromebook 3", > > I would do something like below (though I'm fine with current as well). > > .ident = "Intel_Strago based Chromebooks (All models)", > .ident = "Intel_Strago based Chromebooks (Cyan)", > .ident = "Samsung Chromebook 3 (Celes)", Works for me :) I will change this in v2 accordinly. Thanks.
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-05-16 00:30 +0200 |
| Subject | Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems |
| Message-ID | <tHwF4-5y6-3@gated-at.bofh.it> |
| In reply to | #1641553 |
On Mon, May 15, 2017 at 4:14 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Mon, 2017-05-15 at 14:01 +0300, Mika Westerberg wrote: >> It turns out there are quite many Chromebooks out there that have the >> same keyboard issue than Acer Chromebook. All of them are based on >> Intel_Strago reference and report their DMI_PRODUCT_FAMILY as >> "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are >> exceptions >> for which we add separate entries). >> >> Instead of adding each machine to the quirk table, we use >> DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the >> machines out there currently. >> >> > >> + .ident = "Intel_Strago based Chromebooks", > >> + .ident = "Cyan Chromebook", > >> + .ident = "Samsung Chromebook 3", > > I would do something like below (though I'm fine with current as well). > > .ident = "Intel_Strago based Chromebooks (All models)", > .ident = "Intel_Strago based Chromebooks (Cyan)", I think this one should be "Acer Chromebook R11 (Cyan)" Thanks. -- Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web