Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641541 > unrolled thread

Re: [PATCH] mmc: sdricoh_cs: remove redundant check if len is non-zero

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] mmc: sdricoh_cs: remove redundant check if len is non-zero Ulf Hansson <ulf.hansson@linaro.org> - 2017-05-15 13:00 +0200

#1641541 — Re: [PATCH] mmc: sdricoh_cs: remove redundant check if len is non-zero

On 9 May 2017 at 17:45, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> At the end of either of the read or write loops len is always zero
> and hence the non-zero check on len and return of -EIO is redundant
> and can be removed.
>
> Detected by CoverityScan, CID#114293 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied for next!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdricoh_cs.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c
> index 5ff26ab81eb1..70cb00aa79a0 100644
> --- a/drivers/mmc/host/sdricoh_cs.c
> +++ b/drivers/mmc/host/sdricoh_cs.c
> @@ -256,9 +256,6 @@ static int sdricoh_blockio(struct sdricoh_host *host, int read,
>                 }
>         }
>
> -       if (len)
> -               return -EIO;
> -
>         return 0;
>  }
>
> --
> 2.11.0
>

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web