Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1641461 > unrolled thread

[PATCHv3 14/14] pinctrl: mcp23s08: fix comment for mcp23s08_platform_data.base

Started bySebastian Reichel <sebastian.reichel@collabora.co.uk>
First post2017-05-15 11:30 +0200
Last post2017-05-15 11:30 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCHv3 14/14] pinctrl: mcp23s08: fix comment for mcp23s08_platform_data.base Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200

#1641461 — [PATCHv3 14/14] pinctrl: mcp23s08: fix comment for mcp23s08_platform_data.base

FromSebastian Reichel <sebastian.reichel@collabora.co.uk>
Date2017-05-15 11:30 +0200
Subject[PATCHv3 14/14] pinctrl: mcp23s08: fix comment for mcp23s08_platform_data.base
Message-ID<tHkud-6eH-1@gated-at.bofh.it>
The comment does not match the driver, which actually supports
automatic assignment. Fix this by updating the comment.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
---
 include/linux/spi/mcp23s08.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/spi/mcp23s08.h b/include/linux/spi/mcp23s08.h
index 4354beefd584..82d96a346e6f 100644
--- a/include/linux/spi/mcp23s08.h
+++ b/include/linux/spi/mcp23s08.h
@@ -7,11 +7,11 @@ struct mcp23s08_platform_data {
 	 */
 	u32 spi_present_mask;
 
-	/* "base" is the number of the first GPIO.  Dynamic assignment is
-	 * not currently supported, and even if there are gaps in chip
-	 * addressing the GPIO numbers are sequential .. so for example
-	 * if only slaves 0 and 3 are present, their GPIOs range from
-	 * base to base+15 (or base+31 for s17 variant).
+	/* "base" is the number of the first GPIO or -1 for dynamic
+	 * assignment. If there are gaps in chip addressing the GPIO
+	 * numbers are sequential .. so for example if only slaves 0
+	 * and 3 are present, their GPIOs range from base to base+15
+	 * (or base+31 for s17 variant).
 	 */
 	unsigned	base;
 };
-- 
2.11.0

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web