Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642813 > unrolled thread

Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

Started byChris Packham <Chris.Packham@alliedtelesis.co.nz>
First post2017-05-16 22:40 +0200
Last post2017-05-18 06:10 +0200
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-05-16 22:40 +0200
    Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing Guenter Roeck <linux@roeck-us.net> - 2017-05-17 00:10 +0200
    Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature  smoothing Ye Xiaolong <xiaolong.ye@intel.com> - 2017-05-17 05:10 +0200
      Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature  smoothing Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-05-17 05:30 +0200
        Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature  smoothing Ye Xiaolong <xiaolong.ye@intel.com> - 2017-05-17 06:50 +0200
          Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature  smoothing Guenter Roeck <linux@roeck-us.net> - 2017-05-17 07:30 +0200
            Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature  smoothing Ye Xiaolong <xiaolong.ye@intel.com> - 2017-05-18 05:10 +0200
              Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature  smoothing Guenter Roeck <linux@roeck-us.net> - 2017-05-18 06:10 +0200

#1642813 — Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

FromChris Packham <Chris.Packham@alliedtelesis.co.nz>
Date2017-05-16 22:40 +0200
SubjectRe: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing
Message-ID<tHRqa-1So-11@gated-at.bofh.it>
On 16/05/17 20:23, kbuild test robot wrote:
> Hi Chris,
>
> [auto build test ERROR on hwmon/hwmon-next]
> [also build test ERROR on v4.12-rc1 next-20170516]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
> config: x86_64-rhel (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
>    drivers/hwmon/adt7475.c: In function 'set_temp_st':
>>> drivers/hwmon/adt7475.c:622:9: error: implicit declaration of function 'find_closest_descending' [-Werror=implicit-function-declaration]
>       val = find_closest_descending(val, ad7475_st_map,
>             ^~~~~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
>
> vim +/find_closest_descending +622 drivers/hwmon/adt7475.c
>
>    616			shift = 4;
>    617			idx = 1;
>    618			break;
>    619		}
>    620	
>    621		if (val > 0) {
>  > 622			val = find_closest_descending(val, ad7475_st_map,
>    623						      ARRAY_SIZE(ad7475_st_map));
>    624			val |= 0x8;
>    625		}
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>

I'm not sure how this is failing. find_closest_descending() is a macro 
defined in linux/util_macros.h which is explicitly included in 
drivers/hwmon/adt7475.c. Aside from the include guards there's nothing 
conditional about it.

[toc] | [next] | [standalone]

#1642860

FromGuenter Roeck <linux@roeck-us.net>
Date2017-05-17 00:10 +0200
Message-ID<tHSPg-31N-5@gated-at.bofh.it>
In reply to#1642813
On Tue, May 16, 2017 at 08:30:52PM +0000, Chris Packham wrote:
> On 16/05/17 20:23, kbuild test robot wrote:
> > Hi Chris,
> >
> > [auto build test ERROR on hwmon/hwmon-next]
> > [also build test ERROR on v4.12-rc1 next-20170516]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >
> > url:    https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
> > config: x86_64-rhel (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=x86_64
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/hwmon/adt7475.c: In function 'set_temp_st':
> >>> drivers/hwmon/adt7475.c:622:9: error: implicit declaration of function 'find_closest_descending' [-Werror=implicit-function-declaration]
> >       val = find_closest_descending(val, ad7475_st_map,
> >             ^~~~~~~~~~~~~~~~~~~~~~~
> >    cc1: some warnings being treated as errors
> >
> > vim +/find_closest_descending +622 drivers/hwmon/adt7475.c
> >
> >    616			shift = 4;
> >    617			idx = 1;
> >    618			break;
> >    619		}
> >    620	
> >    621		if (val > 0) {
> >  > 622			val = find_closest_descending(val, ad7475_st_map,
> >    623						      ARRAY_SIZE(ad7475_st_map));
> >    624			val |= 0x8;
> >    625		}
> >
> > ---
> > 0-DAY kernel test infrastructure                Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> >
> 
> I'm not sure how this is failing. find_closest_descending() is a macro 
> defined in linux/util_macros.h which is explicitly included in 
> drivers/hwmon/adt7475.c. Aside from the include guards there's nothing 
> conditional about it.

I suspect it was tested out of sequence, without the preceding patches,
and the header file include was missing.

Guenter

[toc] | [prev] | [next] | [standalone]

#1642927 — Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

FromYe Xiaolong <xiaolong.ye@intel.com>
Date2017-05-17 05:10 +0200
SubjectRe: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing
Message-ID<tHXvA-634-19@gated-at.bofh.it>
In reply to#1642813
On 05/16, Chris Packham wrote:
>On 16/05/17 20:23, kbuild test robot wrote:
>> Hi Chris,
>>
>> [auto build test ERROR on hwmon/hwmon-next]
>> [also build test ERROR on v4.12-rc1 next-20170516]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>
>> url:    https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
>> config: x86_64-rhel (attached as .config)
>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>> reproduce:
>>         # save the attached .config to linux build tree
>>         make ARCH=x86_64
>>
>> All errors (new ones prefixed by >>):
>>
>>    drivers/hwmon/adt7475.c: In function 'set_temp_st':
>>>> drivers/hwmon/adt7475.c:622:9: error: implicit declaration of function 'find_closest_descending' [-Werror=implicit-function-declaration]
>>       val = find_closest_descending(val, ad7475_st_map,
>>             ^~~~~~~~~~~~~~~~~~~~~~~
>>    cc1: some warnings being treated as errors
>>
>> vim +/find_closest_descending +622 drivers/hwmon/adt7475.c
>>
>>    616			shift = 4;
>>    617			idx = 1;
>>    618			break;
>>    619		}
>>    620	
>>    621		if (val > 0) {
>>  > 622			val = find_closest_descending(val, ad7475_st_map,
>>    623						      ARRAY_SIZE(ad7475_st_map));
>>    624			val |= 0x8;
>>    625		}
>>
>> ---
>> 0-DAY kernel test infrastructure                Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>>
>
>I'm not sure how this is failing. find_closest_descending() is a macro 
>defined in linux/util_macros.h which is explicitly included in 
>drivers/hwmon/adt7475.c. Aside from the include guards there's nothing 
>conditional about it.

Hi,

0day bot applied your patchset on top of commit 6eaaea1 ("hwmon: (pmbus) Add client driver for IR35221"),
is it wrong or you have some prerequisite patches?

Thanks,
Xiaolong
>_______________________________________________
>kbuild-all mailing list
>kbuild-all@lists.01.org
>https://lists.01.org/mailman/listinfo/kbuild-all

[toc] | [prev] | [next] | [standalone]

#1642928 — Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

FromChris Packham <Chris.Packham@alliedtelesis.co.nz>
Date2017-05-17 05:30 +0200
SubjectRe: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing
Message-ID<tHXOV-69n-3@gated-at.bofh.it>
In reply to#1642927
On 17/05/17 15:09, Ye Xiaolong wrote:
> On 05/16, Chris Packham wrote:
>> On 16/05/17 20:23, kbuild test robot wrote:
>>> Hi Chris,
>>>
>>> [auto build test ERROR on hwmon/hwmon-next]
>>> [also build test ERROR on v4.12-rc1 next-20170516]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>
>>> url:    https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530
>>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
>>> config: x86_64-rhel (attached as .config)
>>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>>> reproduce:
>>>         # save the attached .config to linux build tree
>>>         make ARCH=x86_64
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>    drivers/hwmon/adt7475.c: In function 'set_temp_st':
>>>>> drivers/hwmon/adt7475.c:622:9: error: implicit declaration of function 'find_closest_descending' [-Werror=implicit-function-declaration]
>>>       val = find_closest_descending(val, ad7475_st_map,
>>>             ^~~~~~~~~~~~~~~~~~~~~~~
>>>    cc1: some warnings being treated as errors
>>>
>>> vim +/find_closest_descending +622 drivers/hwmon/adt7475.c
>>>
>>>    616			shift = 4;
>>>    617			idx = 1;
>>>    618			break;
>>>    619		}
>>>    620	
>>>    621		if (val > 0) {
>>>  > 622			val = find_closest_descending(val, ad7475_st_map,
>>>    623						      ARRAY_SIZE(ad7475_st_map));
>>>    624			val |= 0x8;
>>>    625		}
>>>
>>> ---
>>> 0-DAY kernel test infrastructure                Open Source Technology Center
>>> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>>>
>>
>> I'm not sure how this is failing. find_closest_descending() is a macro
>> defined in linux/util_macros.h which is explicitly included in
>> drivers/hwmon/adt7475.c. Aside from the include guards there's nothing
>> conditional about it.
>
> Hi,
>
> 0day bot applied your patchset on top of commit 6eaaea1 ("hwmon: (pmbus) Add client driver for IR35221"),
> is it wrong or you have some prerequisite patches?
>

Looks like it's missing 
https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=bbb4dd0ff 
which was part of the series but was applied after v3 so I didn't send 
it out with v4.

[toc] | [prev] | [next] | [standalone]

#1642969 — Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

FromYe Xiaolong <xiaolong.ye@intel.com>
Date2017-05-17 06:50 +0200
SubjectRe: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing
Message-ID<tHZ4m-6Ti-11@gated-at.bofh.it>
In reply to#1642928
On 05/17, Chris Packham wrote:
>On 17/05/17 15:09, Ye Xiaolong wrote:
>> On 05/16, Chris Packham wrote:
>>> On 16/05/17 20:23, kbuild test robot wrote:
>>>> Hi Chris,
>>>>
>>>> [auto build test ERROR on hwmon/hwmon-next]
>>>> [also build test ERROR on v4.12-rc1 next-20170516]
>>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>>
>>>> url:    https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530
>>>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
>>>> config: x86_64-rhel (attached as .config)
>>>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>>>> reproduce:
>>>>         # save the attached .config to linux build tree
>>>>         make ARCH=x86_64
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>>    drivers/hwmon/adt7475.c: In function 'set_temp_st':
>>>>>> drivers/hwmon/adt7475.c:622:9: error: implicit declaration of function 'find_closest_descending' [-Werror=implicit-function-declaration]
>>>>       val = find_closest_descending(val, ad7475_st_map,
>>>>             ^~~~~~~~~~~~~~~~~~~~~~~
>>>>    cc1: some warnings being treated as errors
>>>>
>>>> vim +/find_closest_descending +622 drivers/hwmon/adt7475.c
>>>>
>>>>    616			shift = 4;
>>>>    617			idx = 1;
>>>>    618			break;
>>>>    619		}
>>>>    620	
>>>>    621		if (val > 0) {
>>>>  > 622			val = find_closest_descending(val, ad7475_st_map,
>>>>    623						      ARRAY_SIZE(ad7475_st_map));
>>>>    624			val |= 0x8;
>>>>    625		}
>>>>
>>>> ---
>>>> 0-DAY kernel test infrastructure                Open Source Technology Center
>>>> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>>>>
>>>
>>> I'm not sure how this is failing. find_closest_descending() is a macro
>>> defined in linux/util_macros.h which is explicitly included in
>>> drivers/hwmon/adt7475.c. Aside from the include guards there's nothing
>>> conditional about it.
>>
>> Hi,
>>
>> 0day bot applied your patchset on top of commit 6eaaea1 ("hwmon: (pmbus) Add client driver for IR35221"),
>> is it wrong or you have some prerequisite patches?

Thanks for the info, seems we need to improve the kbuild bot by pulling the
latest tree before applying new patches.

Thanks,
Xiaolong
>>
>
>Looks like it's missing 
>https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=bbb4dd0ff 
>which was part of the series but was applied after v3 so I didn't send 
>it out with v4.

[toc] | [prev] | [next] | [standalone]

#1642981 — Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

FromGuenter Roeck <linux@roeck-us.net>
Date2017-05-17 07:30 +0200
SubjectRe: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing
Message-ID<tHZH3-7oQ-9@gated-at.bofh.it>
In reply to#1642969
On 05/16/2017 09:39 PM, Ye Xiaolong wrote:
> On 05/17, Chris Packham wrote:
>> On 17/05/17 15:09, Ye Xiaolong wrote:
>>> On 05/16, Chris Packham wrote:
>>>> On 16/05/17 20:23, kbuild test robot wrote:
>>>>> Hi Chris,
>>>>>
>>>>> [auto build test ERROR on hwmon/hwmon-next]
>>>>> [also build test ERROR on v4.12-rc1 next-20170516]
>>>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>>>
>>>>> url:    https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530
>>>>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
>>>>> config: x86_64-rhel (attached as .config)
>>>>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>>>>> reproduce:
>>>>>         # save the attached .config to linux build tree
>>>>>         make ARCH=x86_64
>>>>>
>>>>> All errors (new ones prefixed by >>):
>>>>>
>>>>>    drivers/hwmon/adt7475.c: In function 'set_temp_st':
>>>>>>> drivers/hwmon/adt7475.c:622:9: error: implicit declaration of function 'find_closest_descending' [-Werror=implicit-function-declaration]
>>>>>       val = find_closest_descending(val, ad7475_st_map,
>>>>>             ^~~~~~~~~~~~~~~~~~~~~~~
>>>>>    cc1: some warnings being treated as errors
>>>>>
>>>>> vim +/find_closest_descending +622 drivers/hwmon/adt7475.c
>>>>>
>>>>>    616			shift = 4;
>>>>>    617			idx = 1;
>>>>>    618			break;
>>>>>    619		}
>>>>>    620	
>>>>>    621		if (val > 0) {
>>>>>  > 622			val = find_closest_descending(val, ad7475_st_map,
>>>>>    623						      ARRAY_SIZE(ad7475_st_map));
>>>>>    624			val |= 0x8;
>>>>>    625		}
>>>>>
>>>>> ---
>>>>> 0-DAY kernel test infrastructure                Open Source Technology Center
>>>>> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>>>>>
>>>>
>>>> I'm not sure how this is failing. find_closest_descending() is a macro
>>>> defined in linux/util_macros.h which is explicitly included in
>>>> drivers/hwmon/adt7475.c. Aside from the include guards there's nothing
>>>> conditional about it.
>>>
>>> Hi,
>>>
>>> 0day bot applied your patchset on top of commit 6eaaea1 ("hwmon: (pmbus) Add client driver for IR35221"),
>>> is it wrong or you have some prerequisite patches?
>
> Thanks for the info, seems we need to improve the kbuild bot by pulling the
> latest tree before applying new patches.
>

No worries. I don't mind the occasional false positive. Better a false positive than a missed bug.

Guenter

> Thanks,
> Xiaolong
>>>
>>
>> Looks like it's missing
>> https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=bbb4dd0ff
>> which was part of the series but was applied after v3 so I didn't send
>> it out with v4.
>

[toc] | [prev] | [next] | [standalone]

#1643756 — Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

FromYe Xiaolong <xiaolong.ye@intel.com>
Date2017-05-18 05:10 +0200
SubjectRe: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing
Message-ID<tIjZ7-3Q2-3@gated-at.bofh.it>
In reply to#1642981
On 05/16, Guenter Roeck wrote:
>>>>0day bot applied your patchset on top of commit 6eaaea1 ("hwmon: (pmbus) Add client driver for IR35221"),
>>>>is it wrong or you have some prerequisite patches?
>>
>>Thanks for the info, seems we need to improve the kbuild bot by pulling the
>>latest tree before applying new patches.
>>
>
>No worries. I don't mind the occasional false positive. Better a false positive than a missed bug.
>

Just curiosity, I noticed you committed the missing patch bbb4dd0fff ("hwmon:
(adt7475) replace find_nearest() with find_closest()") at May 14, did you push
it to git.kernel.org immediately or sometime after that? Since 0day makes
mirror based on repos in git.kernel.org in this case.

Thanks,
Xiaolong

>Guenter
>
>>Thanks,
>>Xiaolong
>>>>
>>>
>>>Looks like it's missing
>>>https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=bbb4dd0ff
>>>which was part of the series but was applied after v3 so I didn't send
>>>it out with v4.
>>
>

[toc] | [prev] | [next] | [standalone]

#1643780 — Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

FromGuenter Roeck <linux@roeck-us.net>
Date2017-05-18 06:10 +0200
SubjectRe: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing
Message-ID<tIkVb-4yB-21@gated-at.bofh.it>
In reply to#1643756
On 05/17/2017 08:05 PM, Ye Xiaolong wrote:
> On 05/16, Guenter Roeck wrote:
>>>>> 0day bot applied your patchset on top of commit 6eaaea1 ("hwmon: (pmbus) Add client driver for IR35221"),
>>>>> is it wrong or you have some prerequisite patches?
>>>
>>> Thanks for the info, seems we need to improve the kbuild bot by pulling the
>>> latest tree before applying new patches.
>>>
>>
>> No worries. I don't mind the occasional false positive. Better a false positive than a missed bug.
>>
>
> Just curiosity, I noticed you committed the missing patch bbb4dd0fff ("hwmon:
> (adt7475) replace find_nearest() with find_closest()") at May 14, did you push
> it to git.kernel.org immediately or sometime after that? Since 0day makes
> mirror based on repos in git.kernel.org in this case.
>

I don't recall, sorry. Most likely I didn't push it immediately.

Guenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web