Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1642840 > unrolled thread
| Started by | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| First post | 2017-05-16 23:40 +0200 |
| Last post | 2017-05-16 23:40 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH V1] i2c: xgene: Add support for I2C_FUNC_I2C functionality Wolfram Sang <wsa@the-dreams.de> - 2017-05-16 23:40 +0200
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-05-16 23:40 +0200 |
| Subject | Re: [PATCH V1] i2c: xgene: Add support for I2C_FUNC_I2C functionality |
| Message-ID | <tHSme-2zE-11@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Apr 26, 2017 at 11:41:45AM +0700, tnhuynh@apm.com wrote: > From: Tin Huynh <tnhuynh@apm.com> > > Certain I2C slave drivers, such as the pca95xx, require > only I2C operations instead of SMBus extensions. > This patch adds I2C_FUNC_I2C functionally to support those drivers. No Signed-off, please run checkpatch on your patches! > - return I2C_FUNC_SMBUS_BYTE | > + return I2C_FUNC_I2C | > + I2C_FUNC_SMBUS_BYTE | Does this really work? You don't have a master_xfer function, so I think it cannot work. You don't seem to have I2C_FUNC_I2C support in your driver. > I2C_FUNC_SMBUS_BYTE_DATA | > I2C_FUNC_SMBUS_WORD_DATA | > I2C_FUNC_SMBUS_BLOCK_DATA | > -- > 1.7.1 >
Back to top | Article view | linux.kernel
csiph-web